From: "Pali Rohár" <pali@kernel.org>
To: Simon Glass <sjg@chromium.org>, Steve Bennett <steveb@workware.net.au>
Cc: u-boot@lists.denx.de
Subject: [PATCH] Revert "cli_readline: Only insert printable chars"
Date: Wed, 2 Nov 2022 00:40:46 +0100 [thread overview]
Message-ID: <20221101234046.5002-1-pali@kernel.org> (raw)
This reverts commit d2e64d29c44dee6d455f7705dd1cf1af8674ad9a.
This commit broke support for pound sign (£) and euro sign (€) keys on
Nokia N900 keypad.
Signed-off-by: Pali Rohár <pali@kernel.org>
---
common/cli_readline.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/common/cli_readline.c b/common/cli_readline.c
index f6e2bcdeceb2..d6444f5fc1d3 100644
--- a/common/cli_readline.c
+++ b/common/cli_readline.c
@@ -517,10 +517,8 @@ static int cread_line(const char *const prompt, char *buf, unsigned int *len,
}
#endif
default:
- if (ichar >= ' ' && ichar <= '~') {
- cread_add_char(ichar, insert, &num, &eol_num,
- buf, *len);
- }
+ cread_add_char(ichar, insert, &num, &eol_num, buf,
+ *len);
break;
}
}
--
2.20.1
next reply other threads:[~2022-11-01 23:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 23:40 Pali Rohár [this message]
2022-11-02 3:07 ` [PATCH] Revert "cli_readline: Only insert printable chars" Simon Glass
2022-11-20 17:12 ` Pali Rohár
2022-11-21 17:34 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221101234046.5002-1-pali@kernel.org \
--to=pali@kernel.org \
--cc=sjg@chromium.org \
--cc=steveb@workware.net.au \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox