* [PATCH v6] imx: imx8qm: cgtqmx8: switch to binman
@ 2022-11-02 9:10 Oliver Graute
2022-11-02 12:56 ` Fabio Estevam
0 siblings, 1 reply; 5+ messages in thread
From: Oliver Graute @ 2022-11-02 9:10 UTC (permalink / raw)
To: sbabic
Cc: oliver.graute, oliver.graute, festevam, peng.fan, uboot-imx,
Horia Geantă, Gaurav Jain, Marcel Ziswiler, Denys Drozdov,
Ye Li, u-boot
Switch to use binman to pack images
Signed-off-by: Oliver Graute <oliver.graute@kococonnector.com>
Reviewed-by: Fabio Estevam <festevam@denx.de>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
---
Changes for v6
- added CONFIG_SPL_BINMAN_UBOOT_SYMBOLS is not set
Changes for v5
- added CONFIG_FIT_EXTERNAL_OFFSET
Changes for v4
- rebased on master
Changes for v3
-added Reviewed-by
- rebased on master
arch/arm/dts/imx8qm-cgtqmx8.dts | 1 +
arch/arm/mach-imx/imx8/Kconfig | 1 +
board/congatec/cgtqmx8/imximage.cfg | 4 ++--
configs/cgtqmx8_defconfig | 4 +++-
doc/board/congatec/cgtqmx8.rst | 3 +--
5 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/arch/arm/dts/imx8qm-cgtqmx8.dts b/arch/arm/dts/imx8qm-cgtqmx8.dts
index 555c357f6f..919d00644f 100644
--- a/arch/arm/dts/imx8qm-cgtqmx8.dts
+++ b/arch/arm/dts/imx8qm-cgtqmx8.dts
@@ -12,6 +12,7 @@
/memreserve/ 0x80000000 0x00020000;
#include "fsl-imx8qm.dtsi"
+#include "imx8qm-u-boot.dtsi"
/ {
model = "Congatec QMX8 Qseven series";
diff --git a/arch/arm/mach-imx/imx8/Kconfig b/arch/arm/mach-imx/imx8/Kconfig
index a7e3af57dc..d423cf8563 100644
--- a/arch/arm/mach-imx/imx8/Kconfig
+++ b/arch/arm/mach-imx/imx8/Kconfig
@@ -76,6 +76,7 @@ config TARGET_IMX8QM_MEK
config TARGET_CONGA_QMX8
bool "Support congatec conga-QMX8 board"
+ select BINMAN
select BOARD_LATE_INIT
select SUPPORT_SPL
select IMX8QM
diff --git a/board/congatec/cgtqmx8/imximage.cfg b/board/congatec/cgtqmx8/imximage.cfg
index 5ecde0c530..43035088e3 100644
--- a/board/congatec/cgtqmx8/imximage.cfg
+++ b/board/congatec/cgtqmx8/imximage.cfg
@@ -4,8 +4,8 @@
*/
-/* Boot from SD, sector size 0x400 */
-BOOT_FROM SD 0x400
+BOOT_FROM sd
+
/* SoC type IMX8QM */
SOC_TYPE IMX8QM
/* Append seco container image */
diff --git a/configs/cgtqmx8_defconfig b/configs/cgtqmx8_defconfig
index ddc65a06b9..4d1dfe4212 100644
--- a/configs/cgtqmx8_defconfig
+++ b/configs/cgtqmx8_defconfig
@@ -20,8 +20,10 @@ CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x80200000
CONFIG_REMAKE_ELF=y
CONFIG_FIT=y
+CONFIG_FIT_EXTERNAL_OFFSET=0x3000
CONFIG_SPL_LOAD_FIT=y
-CONFIG_SPL_FIT_GENERATOR="arch/arm/mach-imx/mkimage_fit_atf.sh"
+# CONFIG_USE_SPL_FIT_GENERATOR is not set
+# CONFIG_SPL_BINMAN_UBOOT_SYMBOLS is not set
CONFIG_OF_BOARD_SETUP=y
CONFIG_BOOTDELAY=3
CONFIG_USE_BOOTCOMMAND=y
diff --git a/doc/board/congatec/cgtqmx8.rst b/doc/board/congatec/cgtqmx8.rst
index bccdef2f16..16711a844d 100644
--- a/doc/board/congatec/cgtqmx8.rst
+++ b/doc/board/congatec/cgtqmx8.rst
@@ -57,8 +57,7 @@ Build U-Boot
$ export ATF_LOAD_ADDR=0x80000000
$ export BL33_LOAD_ADDR=0x80020000
$ make cgtqmx8_defconfig
- $ make u-boot.bin
- $ make flash.bin
+ $ make
Flash the binary into the SD card
---------------------------------
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v6] imx: imx8qm: cgtqmx8: switch to binman
2022-11-02 9:10 [PATCH v6] imx: imx8qm: cgtqmx8: switch to binman Oliver Graute
@ 2022-11-02 12:56 ` Fabio Estevam
2022-11-02 14:42 ` Oliver Graute
0 siblings, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2022-11-02 12:56 UTC (permalink / raw)
To: Oliver Graute
Cc: sbabic, oliver.graute, peng.fan, uboot-imx, Horia Geantă,
Gaurav Jain, Marcel Ziswiler, Denys Drozdov, Ye Li, u-boot
Hi Oliver,
On Wed, Nov 2, 2022 at 6:12 AM Oliver Graute
<oliver.graute@kococonnector.com> wrote:
> #include "fsl-imx8qm.dtsi"
> +#include "imx8qm-u-boot.dtsi"
This file does not exist in U-Boot mainline.
I know you added it as part of another patch, but please send a patch
series so that all dependencies are available.
What about the other imx8mq boards? Do you plan to convert them too?
If so, please send a series doing the full binman conversion of all
imx8qm boards.
Thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v6] imx: imx8qm: cgtqmx8: switch to binman
2022-11-02 12:56 ` Fabio Estevam
@ 2022-11-02 14:42 ` Oliver Graute
2022-11-02 14:45 ` Fabio Estevam
0 siblings, 1 reply; 5+ messages in thread
From: Oliver Graute @ 2022-11-02 14:42 UTC (permalink / raw)
To: Fabio Estevam
Cc: sbabic, peng.fan, uboot-imx, Horia Geantă, Gaurav Jain,
Marcel Ziswiler, Denys Drozdov, Ye Li, u-boot
On 02/11/22, Fabio Estevam wrote:
> Hi Oliver,
>
> On Wed, Nov 2, 2022 at 6:12 AM Oliver Graute
> <oliver.graute@kococonnector.com> wrote:
>
> > #include "fsl-imx8qm.dtsi"
> > +#include "imx8qm-u-boot.dtsi"
>
> This file does not exist in U-Boot mainline.
>
> I know you added it as part of another patch, but please send a patch
> series so that all dependencies are available.
Ok, I try to send them all as series next time.
>
> What about the other imx8mq boards? Do you plan to convert them too?
I have these boards in mind for missing binman support:
imx8qm-rom7720, cgtqmx8, imx8qxp, imx8qm_mek, giedi, deneb,
colibri_imx8x, apalis_imx8
After checking arch/arm/mach-imx/imx8/Kconfig and
arch/arm/mach-imx/imx8m/Kconfig I see no more imx8mq boards which needs
porting to binman.
But nxp naming is easy to confuse so perhaps I missed some boards. Can
you tell me which imx8mq boards you mean exactly? then I would try port
them to.
>
> If so, please send a series doing the full binman conversion of all
> imx8qm boards.
Ok
Best Regards,
Oliver
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v6] imx: imx8qm: cgtqmx8: switch to binman
2022-11-02 14:42 ` Oliver Graute
@ 2022-11-02 14:45 ` Fabio Estevam
0 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2022-11-02 14:45 UTC (permalink / raw)
To: Fabio Estevam, sbabic, peng.fan, uboot-imx, Horia Geantă,
Gaurav Jain, Marcel Ziswiler, Denys Drozdov, Ye Li, u-boot
On Wed, Nov 2, 2022 at 11:42 AM Oliver Graute <oliver.graute@gmail.com> wrote:
> I have these boards in mind for missing binman support:
>
> imx8qm-rom7720, cgtqmx8, imx8qxp, imx8qm_mek, giedi, deneb,
> colibri_imx8x, apalis_imx8
>
> After checking arch/arm/mach-imx/imx8/Kconfig and
> arch/arm/mach-imx/imx8m/Kconfig I see no more imx8mq boards which needs
> porting to binman.
>
> But nxp naming is easy to confuse so perhaps I missed some boards. Can
> you tell me which imx8mq boards you mean exactly? then I would try port
> them to.
Your list is complete:
git grep CONFIG_ARCH_IMX8=y configs/
configs/apalis-imx8_defconfig:CONFIG_ARCH_IMX8=y
configs/cgtqmx8_defconfig:CONFIG_ARCH_IMX8=y
configs/colibri-imx8x_defconfig:CONFIG_ARCH_IMX8=y
configs/deneb_defconfig:CONFIG_ARCH_IMX8=y
configs/giedi_defconfig:CONFIG_ARCH_IMX8=y
configs/imx8qm_mek_defconfig:CONFIG_ARCH_IMX8=y
configs/imx8qm_rom7720_a1_4G_defconfig:CONFIG_ARCH_IMX8=y
configs/imx8qxp_mek_defconfig:CONFIG_ARCH_IMX8=y
Thanks for working on this.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 0/8] imx8: switch missing boards to binman
@ 2022-11-02 15:56 Oliver Graute
2022-11-02 15:56 ` [PATCH v6] imx: imx8qm: cgtqmx8: switch " Oliver Graute
0 siblings, 1 reply; 5+ messages in thread
From: Oliver Graute @ 2022-11-02 15:56 UTC (permalink / raw)
To: sbabic
Cc: oliver.graute, oliver.graute, festevam, peng.fan, uboot-imx,
Marcel Ziswiler, Ye Li, Horia Geantă, Gaurav Jain,
Denys Drozdov, u-boot
This patchsets switches the remaining imx8 boards to binman.
Oliver Graute (8):
imx: imx8qm-rom7720: switch to binman
imx: imx8qm: cgtqmx8: switch to binman
imx: imx8qxp: imx8qxp_mek switch to binman
imx: imx8qm: imx8qm_mek switch to binman
imx: imx8qxp: giedi switch to binman
imx: imx8qxp: deneb switch to binman
imx: imx8x: colibri: switch to binman
imx: imx8: apalis: switch to binman
arch/arm/dts/fsl-imx8qm-apalis-u-boot.dtsi | 104 ++++++++++++++
arch/arm/dts/fsl-imx8qm-mek-u-boot.dtsi | 2 +
arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi | 104 ++++++++++++++
arch/arm/dts/fsl-imx8qxp-mek-u-boot.dtsi | 127 +++++++++++++++++
arch/arm/dts/imx8qm-cgtqmx8.dts | 1 +
arch/arm/dts/imx8qm-rom7720-a1.dts | 1 +
arch/arm/dts/imx8qm-u-boot.dtsi | 133 ++++++++++++++++++
arch/arm/dts/imx8qxp-capricorn-u-boot.dtsi | 127 +++++++++++++++++
arch/arm/mach-imx/imx8/Kconfig | 8 ++
.../advantech/imx8qm_rom7720_a1/imximage.cfg | 4 +-
board/congatec/cgtqmx8/imximage.cfg | 4 +-
board/freescale/imx8qm_mek/README | 2 +-
board/freescale/imx8qxp_mek/imximage.cfg | 3 +-
board/siemens/capricorn/imximage.cfg | 2 +-
configs/apalis-imx8_defconfig | 1 +
configs/cgtqmx8_defconfig | 4 +-
configs/colibri-imx8x_defconfig | 1 +
configs/deneb_defconfig | 2 +
configs/giedi_defconfig | 2 +
configs/imx8qm_mek_defconfig | 2 +
configs/imx8qm_rom7720_a1_4G_defconfig | 3 +-
configs/imx8qxp_mek_defconfig | 2 +
doc/board/advantech/imx8qm-rom7720-a1.rst | 3 +-
doc/board/congatec/cgtqmx8.rst | 3 +-
doc/board/nxp/imx8qxp_mek.rst | 2 +-
25 files changed, 632 insertions(+), 15 deletions(-)
create mode 100644 arch/arm/dts/imx8qm-u-boot.dtsi
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v6] imx: imx8qm: cgtqmx8: switch to binman
2022-11-02 15:56 [PATCH 0/8] imx8: switch missing boards " Oliver Graute
@ 2022-11-02 15:56 ` Oliver Graute
0 siblings, 0 replies; 5+ messages in thread
From: Oliver Graute @ 2022-11-02 15:56 UTC (permalink / raw)
To: sbabic
Cc: oliver.graute, oliver.graute, festevam, peng.fan, uboot-imx,
Marcel Ziswiler, Horia Geantă, Denys Drozdov, Ye Li,
Gaurav Jain, u-boot
Switch to use binman to pack images
Signed-off-by: Oliver Graute <oliver.graute@kococonnector.com>
Reviewed-by: Fabio Estevam <festevam@denx.de>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
---
Changes for v6
- added CONFIG_SPL_BINMAN_UBOOT_SYMBOLS is not set
Changes for v5
- added CONFIG_FIT_EXTERNAL_OFFSET
Changes for v4
- rebased on master
Changes for v3
-added Reviewed-by
- rebased on master
arch/arm/dts/imx8qm-cgtqmx8.dts | 1 +
arch/arm/mach-imx/imx8/Kconfig | 1 +
board/congatec/cgtqmx8/imximage.cfg | 4 ++--
configs/cgtqmx8_defconfig | 4 +++-
doc/board/congatec/cgtqmx8.rst | 3 +--
5 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/arch/arm/dts/imx8qm-cgtqmx8.dts b/arch/arm/dts/imx8qm-cgtqmx8.dts
index 555c357f6f..919d00644f 100644
--- a/arch/arm/dts/imx8qm-cgtqmx8.dts
+++ b/arch/arm/dts/imx8qm-cgtqmx8.dts
@@ -12,6 +12,7 @@
/memreserve/ 0x80000000 0x00020000;
#include "fsl-imx8qm.dtsi"
+#include "imx8qm-u-boot.dtsi"
/ {
model = "Congatec QMX8 Qseven series";
diff --git a/arch/arm/mach-imx/imx8/Kconfig b/arch/arm/mach-imx/imx8/Kconfig
index a7e3af57dc..d423cf8563 100644
--- a/arch/arm/mach-imx/imx8/Kconfig
+++ b/arch/arm/mach-imx/imx8/Kconfig
@@ -76,6 +76,7 @@ config TARGET_IMX8QM_MEK
config TARGET_CONGA_QMX8
bool "Support congatec conga-QMX8 board"
+ select BINMAN
select BOARD_LATE_INIT
select SUPPORT_SPL
select IMX8QM
diff --git a/board/congatec/cgtqmx8/imximage.cfg b/board/congatec/cgtqmx8/imximage.cfg
index 5ecde0c530..43035088e3 100644
--- a/board/congatec/cgtqmx8/imximage.cfg
+++ b/board/congatec/cgtqmx8/imximage.cfg
@@ -4,8 +4,8 @@
*/
-/* Boot from SD, sector size 0x400 */
-BOOT_FROM SD 0x400
+BOOT_FROM sd
+
/* SoC type IMX8QM */
SOC_TYPE IMX8QM
/* Append seco container image */
diff --git a/configs/cgtqmx8_defconfig b/configs/cgtqmx8_defconfig
index ddc65a06b9..4d1dfe4212 100644
--- a/configs/cgtqmx8_defconfig
+++ b/configs/cgtqmx8_defconfig
@@ -20,8 +20,10 @@ CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x80200000
CONFIG_REMAKE_ELF=y
CONFIG_FIT=y
+CONFIG_FIT_EXTERNAL_OFFSET=0x3000
CONFIG_SPL_LOAD_FIT=y
-CONFIG_SPL_FIT_GENERATOR="arch/arm/mach-imx/mkimage_fit_atf.sh"
+# CONFIG_USE_SPL_FIT_GENERATOR is not set
+# CONFIG_SPL_BINMAN_UBOOT_SYMBOLS is not set
CONFIG_OF_BOARD_SETUP=y
CONFIG_BOOTDELAY=3
CONFIG_USE_BOOTCOMMAND=y
diff --git a/doc/board/congatec/cgtqmx8.rst b/doc/board/congatec/cgtqmx8.rst
index bccdef2f16..16711a844d 100644
--- a/doc/board/congatec/cgtqmx8.rst
+++ b/doc/board/congatec/cgtqmx8.rst
@@ -57,8 +57,7 @@ Build U-Boot
$ export ATF_LOAD_ADDR=0x80000000
$ export BL33_LOAD_ADDR=0x80020000
$ make cgtqmx8_defconfig
- $ make u-boot.bin
- $ make flash.bin
+ $ make
Flash the binary into the SD card
---------------------------------
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-11-02 15:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-02 9:10 [PATCH v6] imx: imx8qm: cgtqmx8: switch to binman Oliver Graute
2022-11-02 12:56 ` Fabio Estevam
2022-11-02 14:42 ` Oliver Graute
2022-11-02 14:45 ` Fabio Estevam
-- strict thread matches above, loose matches on Subject: below --
2022-11-02 15:56 [PATCH 0/8] imx8: switch missing boards " Oliver Graute
2022-11-02 15:56 ` [PATCH v6] imx: imx8qm: cgtqmx8: switch " Oliver Graute
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox