From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 289BCC4332F for ; Thu, 3 Nov 2022 21:37:02 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3E05C850DE; Thu, 3 Nov 2022 22:36:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=jannau.net Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 44B27850BB; Thu, 3 Nov 2022 22:36:36 +0100 (CET) Received: from soltyk.jannau.net (soltyk.jannau.net [144.76.91.90]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0471D8510E for ; Thu, 3 Nov 2022 22:36:28 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=jannau.net Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=janne@jannau.net Received: by soltyk.jannau.net (Postfix, from userid 1000) id 9982B26F2D2; Thu, 3 Nov 2022 22:36:27 +0100 (CET) Date: Thu, 3 Nov 2022 22:36:27 +0100 From: Janne Grunau To: Simon Glass Cc: Marek Vasut , Tom Rini , Lukasz Majewski , U-Boot Mailing List , AKASHI Takahiro Subject: Re: [PATCH v2 1/1] usb: storage: continue probe on "Invalid device" Message-ID: <20221103213627.GN4024@jannau.net> References: <20220810195422.4334-1-j@jannau.net> <20220926050709.GI4024@jannau.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 2022-09-28 04:20:52 -0600, Simon Glass wrote: > +Marek Vasut > +Tom Rini > > On Sun, 25 Sept 2022 at 23:07, Janne Grunau wrote: > > > > On 2022-08-10 21:54:22 +0200, Janne Grunau wrote: > > > Fixes a crash during probing of sd card readers without medium present. > > > > > > Link: https://github.com/AsahiLinux/linux/issues/44 > > > Link: https://lists.denx.de/pipermail/u-boot/2022-July/489717.html > > > Signed-off-by: Janne Grunau > > > --- > > > Changes since v1: > > > - changed unconditiona return to "continue" as proposed by AKASHI Takahiro > > > > > > common/usb_storage.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/common/usb_storage.c b/common/usb_storage.c > > > index eaa31374ef73..f9204552a683 100644 > > > --- a/common/usb_storage.c > > > +++ b/common/usb_storage.c > > > @@ -239,6 +239,7 @@ static int usb_stor_probe_device(struct usb_device *udev) > > > ret = device_unbind(dev); > > > if (ret) > > > return ret; > > > + continue; > > > } > > > > > > ret = blk_probe_or_unbind(dev); > > > > ping. Is there anything holding up merging this fix? ping2 This fixes a 100% reproducible crash when an USB storage device with "medium not ready" is connected. Janne