Re: [PATCH v1] imx: imx8: apalis: switch to binman

[Oliver Graute <oliver.graute@gmail.com>]

On 04/11/22, Oliver Graute wrote:
> On 02/11/22, Fabio Estevam wrote:
> > On Wed, Nov 2, 2022 at 12:59 PM Oliver Graute
> > <oliver.graute@kococonnector.com> wrote:
> > 
> > Please add a commit log.
> 
> ok
> 
> > 
> > > Signed-off-by: Oliver Graute <oliver.graute@kococonnector.com>
> > 
> > > +&binman {
> > > +
> > > +       itb {
> > > +               filename = "u-boot.itb";
> > > +
> > > +               fit {
> > > +                       description = "Configuration to load ATF before U-Boot";
> > > +                       fit,external-offset = <CONFIG_FIT_EXTERNAL_OFFSET>;
> > 
> > Can't all boards use the common the binman nodes from
> > arch/arm/dts/imx8qm-u-boot.dtsi instead?
> 
> I'am about to try that but I run into the following error:
> 
> binman: Filename 'spl/u-boot-spl.bin' not found in input path (.,.,./board/toradex/apalis-imx8,arch/arm/dts) (cwd='/home/graute/u-boot-upstream')
> Makefile:1109: recipe for target 'all' failed
> make: *** [all] Error 1
> 
> The error disappear if I remove binman/u-boot-spl-ddr and binman/spl
> node in the common file.
> 
> So some of these boards needs the binman/u-boot-spl-ddr and binman/spl
> node and others not. What is the proper solution to deal with this
> difference here?

according to this commit there are indeed different requirements:

commit 8e0d963b19adfb98e8c7c941f44e0f36e9f91303
Author: Peng Fan <peng.fan@nxp.com>
Date:   Fri Dec 21 06:21:26 2018 +0000

    dts: imx8qxp-mek: introduce u-boot dtsi

    Introduce u-boot dtsi for i.MX8QXP MEK board.
    we do not introduce a common dtsi for SoC, because different board
    has different requirement on which needs to be enabled in SPL DM.

So any proposal?

Best regards,

Oliver