From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C9026C4332F for ; Tue, 8 Nov 2022 11:40:00 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 90DF18070B; Tue, 8 Nov 2022 12:39:58 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="qPt5bX59"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id ED1AF84C17; Tue, 8 Nov 2022 12:39:56 +0100 (CET) Received: from mail-oa1-x32.google.com (mail-oa1-x32.google.com [IPv6:2001:4860:4864:20::32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 446AD80705 for ; Tue, 8 Nov 2022 12:39:54 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=festevam@gmail.com Received: by mail-oa1-x32.google.com with SMTP id 586e51a60fabf-13bd19c3b68so15910010fac.7 for ; Tue, 08 Nov 2022 03:39:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=wlVRY/m7il1rNXD0vN9ZVhKnrLpLkOOhspLuOBGKG98=; b=qPt5bX597h/PRuJvsNMYPXRutFboRj3MIdCg74ZcpcmADNQft2zugaI/hekeYLAfA9 dphwBJmkl/SOd9amL4IAggVWSAeAZyoO4CufoBGlIDMkBMJx0pjtvvwxc9ZJc2LNSgDU 4hP/1KKujtjqREJcrKHxrVlnD/zNkocL6T3Yg0GEs702UAgKiOXORJof4i+u6khvcb// nH+52UTrL1HfBXvQkwZ7hiMlx3SqMarlHg7ue59uW2/aBfTpiRO7cZ+FjiLvLBGwNMyO d3xvcTUGWXwpdHdXEuH7QTk9s5jCwP9j6rSBhSiSqP+C49gShVVfr6fKO1v/g4VmjxXJ Xmvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wlVRY/m7il1rNXD0vN9ZVhKnrLpLkOOhspLuOBGKG98=; b=Qm0E+A3+ByzI6r4DlQtd18/guiYcN6VkSz7GbIvCf8So0hn3V0yVA5r7cczmyiEiFn huoRjDM5+yigaA494ALqh5KFwU0YmS2Pe4nTN8Hn/fensLGw+QLNPSCrm2Jtc/coAPp/ Kw9AuOU26RZepbrQjShQGqOLNvH9r9/kwXTRYvo7JyZ/9kT4TfX+4ZNP8p5acWX5KsO3 hITa2Ve/EMFo1tdlJQ6lnD8KUQg+kgKPypnoZh4LFbpHXEACZWONs7JCra7B0WnYMGtb S0N7iYXjOTNnrL3h5KR0zLzevE0rhMZlOa5xGpGSc7NRu+lz66aFWVpyYnxZAMXsrtd8 spwQ== X-Gm-Message-State: ACrzQf26xuHBQ3V3ozMGakCps7jD+h4QgFo/m9otVFoIZwkoO38aamIw FHI9HZLARqZZ+euiF1/rxpE= X-Google-Smtp-Source: AMsMyM5q5dgwwJYOibsND69i3MwE2KI1l9BC9OA3sSHwQFYCf3VPb8sDpwN8IZePB/LI0F5txzI1oQ== X-Received: by 2002:a05:6870:51c6:b0:13c:9911:2539 with SMTP id b6-20020a05687051c600b0013c99112539mr33587203oaj.22.1667907592916; Tue, 08 Nov 2022 03:39:52 -0800 (PST) Received: from localhost.localdomain ([2804:14c:485:4b69:e875:2c16:cac7:5090]) by smtp.gmail.com with ESMTPSA id 5-20020a9d0685000000b0066c47384ffesm3891274otx.74.2022.11.08.03.39.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Nov 2022 03:39:52 -0800 (PST) From: Fabio Estevam To: sbabic@denx.de Cc: u-boot@lists.denx.de, uboot-imx@nxp.com, tharvey@gateworks.com, johannes.schneider@leica-geosystems.com, Fabio Estevam Subject: [PATCH] Revert "serial: mxc: have putc use the TXFIFO" Date: Tue, 8 Nov 2022 08:39:33 -0300 Message-Id: <20221108113933.1437745-1-festevam@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean From: Fabio Estevam This reverts commit c7878a0483c59c48a730123bc0f4659fd40921bf. Since commit c7878a0483c5 ("serial: mxc: have putc use the TXFIFO"), serial console corruption can be seen when priting inside board_init(). Revert it to avoid the regression. Reported-by: Tim Harvey Signed-off-by: Fabio Estevam --- drivers/serial/serial_mxc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/serial/serial_mxc.c b/drivers/serial/serial_mxc.c index 4cf79c1ca24f..82c0d84628d5 100644 --- a/drivers/serial/serial_mxc.c +++ b/drivers/serial/serial_mxc.c @@ -311,7 +311,7 @@ static int mxc_serial_putc(struct udevice *dev, const char ch) struct mxc_serial_plat *plat = dev_get_plat(dev); struct mxc_uart *const uart = plat->reg; - if (readl(&uart->ts) & UTS_TXFULL) + if (!(readl(&uart->ts) & UTS_TXEMPTY)) return -EAGAIN; writel(ch, &uart->txd); -- 2.25.1