Re: [PATCH 1/2] mach-snapdragon/mach-ipq40xx: fix, merge and refactoring

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1747 bytes --]

On Sun, Nov 06, 2022 at 02:52:56AM +0100, Andrey VOLKOV wrote:
> Hi Robert, Tom,
> 
> Updated patches are following, could you review/accept them?
> 
> Le 04/11/2022 à 12:05, Robert Marko a écrit :
> > On Tue, Oct 25, 2022 at 3:31 AM Andrey Volkov<andrey@volkov.fr>  wrote:
> >> SoC: qcom: Add missing Qualcomm's SOCs definitions to the arch KConfig
> >>
> >> From: Andrey VOLKOV<andrey@volkov.fr>
> >>
> >> Add APQ8016/APQ8096/QCS40X decls to the KConfig, convert SDM845 declaration to the hidden one (selected by target),
> >> and update mach-snapdragon/Makefile accordingly.
> >>
> >> Also move 'CONFIG_ARM64' choice to the new declarations, since 'Snapdragon' contains Cortex A7A members too.
> >>
> >> Signed-off-by: Andrey VOLKOV<andrey@volkov.fr>
> > I like this cleanup effort, however, can you rebase this to apply on the master?
> > I would like to use this as a base of moving IPQ40xx to use Linux DTS
> > and keep it in sync.
> 
> It's nice idea, except that full blown DTS is huge enough (+some KiB at least),
> and i'm afraid it's an old, old story about failing to make it :(.
> Probably will be better if we will have some option that allowed to import and
> reuse DTS files directly from the kernel.
> Something like CONFIG_DTS_FILE_PATH/CONFIG_DTS_INCLUDES/...
> 
> @Tom, any additional comments/objections?
> 
> Btw As far as I remember, this topic (reuse kernel's DTS) has been discussed
> repeatedly since the mid-2000s, but I don't remember why it was not implemented yet.

Is the problem that the full DTS would make the resulting binary too
large to fit in some restricted and can't be changed easily space?
Generally we do want to keep the DTS files in-sync with the kernel.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]