From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D882C4332F for ; Tue, 8 Nov 2022 16:40:21 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 95E8C8507C; Tue, 8 Nov 2022 17:39:40 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1667925580; bh=qUYu0w/Vgcpf0ZyvfZBf5Lvai1U06JHA1n9cfbRqF/g=; h=From:To:Subject:In-reply-to:Date:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From; b=u4qyDH+NQ7MtotDNdklr6bhX1oHICMYQhcJ4rpNkVdQvfOQaEXVWlOXP9dBa+/FqD 38xUrZ7Kz2/szJof1IMs10lhJ/1mV6BcFw+TXJo8DxOaF/yAsOrIR8rLkRCwLsUuG6 gHYyLlJKour8FKGxtZy/YTEn3JNxNvwR9KhpfRDuUYMC4KSuIjf8SmKhQP+LtEC7VF eTz3F/id5qS3T+N+e/bazR88k0Fby2a5amp7ZAqTSGNclX26pYNtYS2Y4tVCAwuyCi 7pikYZKCjy7xR3oUjDUGOiMnKjjFo4C458ucuORIgw9W8mUz6uXmJTMcGIo/nEEPgr TTZa8JLXm/jUA== Received: by phobos.denx.de (Postfix, from userid 109) id 305F285010; Tue, 8 Nov 2022 17:38:54 +0100 (CET) Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A1B9885063 for ; Tue, 8 Nov 2022 17:38:23 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sbabic@denx.de Received: from frontend03.mail.m-online.net (unknown [192.168.6.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4N6DLM341Sz1r1Mv; Tue, 8 Nov 2022 17:38:19 +0100 (CET) Received: from localhost (dynscan3.mnet-online.de [192.168.6.84]) by mail.m-online.net (Postfix) with ESMTP id 4N6DLM2w2Gz1qqlR; Tue, 8 Nov 2022 17:38:19 +0100 (CET) X-Amavis-Alert: BAD HEADER SECTION, Missing required header field: "Date" Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan3.mail.m-online.net [192.168.6.84]) (amavisd-new, port 10024) with ESMTP id czRA4donN_bs; Tue, 8 Nov 2022 17:38:18 +0100 (CET) Received: from papero (host-88-217-136-221.customer.m-online.net [88.217.136.221]) by mail.mnet-online.de (Postfix) with ESMTP; Tue, 8 Nov 2022 17:38:18 +0100 (CET) From: sbabic@denx.de X-Patchwork-Submitter: Adam Ford X-Patchwork-Id: 1693397 X-Patchwork-Delegate: sbabic@denx.de To: Adam Ford ,u-boot@lists.denx.de Subject: [PATCH V2 2/4] regulator: bd718x7: Only bind children when PMIC_CHILDREN is enabled In-reply-to: <20221022134345.7613-2-aford173@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Message-Id: <20221108163854.305F285010@phobos.denx.de> Date: Tue, 8 Nov 2022 17:38:48 +0100 (CET) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean > If the bd718x7 is required, but PMIC_CHILDREN is disabled, this > driver throws a compile error. Fix this by putting the function > to bind children into an if-statement checking for PMIC_CHILDREN. > Allowing PMIC_CHILDREN to be disabled in SPL saves some space and > still permits some read/write functions to access the PMIC in > early startup. > Signed-off-by: Adam Ford > Reviewed-by: Simon Glass > Reviewed-by: Fabio Estevam > diff --git a/drivers/power/pmic/bd71837.c b/drivers/power/pmic/bd71837.c > index cb9238972f..fdbbd6f559 100644 > --- a/drivers/power/pmic/bd71837.c > +++ b/drivers/power/pmic/bd71837.c > @@ -63,10 +63,11 @@ static int bd71837_bind(struct udevice *dev) > > debug("%s: '%s' - found regulators subnode\n", __func__, dev->name); > > - children = pmic_bind_children(dev, regulators_node, pmic_children_info); > - if (!children) > - debug("%s: %s - no child found\n", __func__, dev->name); > - > + if (CONFIG_IS_ENABLED(PMIC_CHILDREN)) { > + children = pmic_bind_children(dev, regulators_node, pmic_children_info); > + if (!children) > + debug("%s: %s - no child found\n", __func__, dev->name); > + } > /* Always return success for this device */ > return 0; > } Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de =====================================================================