From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF7BAC43217 for ; Fri, 11 Nov 2022 01:11:15 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 217868509A; Fri, 11 Nov 2022 02:11:13 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id CEAC084D17; Fri, 11 Nov 2022 02:11:04 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id A42C584D17 for ; Fri, 11 Nov 2022 02:11:00 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2EB651FB; Thu, 10 Nov 2022 17:11:06 -0800 (PST) Received: from slackpad.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 556433F703; Thu, 10 Nov 2022 17:10:59 -0800 (PST) Date: Fri, 11 Nov 2022 01:09:37 +0000 From: Andre Przywara To: Samuel Holland Cc: Jagan Teki , u-boot@lists.denx.de Subject: Re: [PATCH 02/22] sunxi: Remove unnecessary Kconfig selections Message-ID: <20221111010937.148a5d13@slackpad.lan> In-Reply-To: <20221101050835.2421-3-samuel@sholland.org> References: <20221101050835.2421-1-samuel@sholland.org> <20221101050835.2421-3-samuel@sholland.org> Organization: Arm Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Tue, 1 Nov 2022 00:08:14 -0500 Samuel Holland wrote: > Two of these selections are redundant and have no effect: > - DM_KEYBOARD is selected by USB_KEYBOARD > - DM_MMC is selected by MMC > > This selection has no effect by default and is unnecessarily strong: > - USB_STORAGE is implied by DISTRO_DEFAULTS With patch 01/22 removed (for now), this disables DM_KEYBOARD on 15 boards, it looks like for those without USB. I wouldn't be aware of any other keyboard type supported on Allwinner boards, so the change is fine: > Signed-off-by: Samuel Holland Reviewed-by: Andre Przywara Cheers, Andre > --- > > arch/arm/Kconfig | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index d3a1f03b36..939f76867e 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -1144,8 +1144,6 @@ config ARCH_SUNXI > select DM_I2C if I2C > select DM_SPI if SPI > select DM_SPI_FLASH if SPI > - select DM_KEYBOARD > - select DM_MMC if MMC > select DM_SCSI if SCSI > select DM_SERIAL > select GPIO_EXTRA_HEADER > @@ -1163,7 +1161,6 @@ config ARCH_SUNXI > select SYS_THUMB_BUILD if !ARM64 > select USB if DISTRO_DEFAULTS > select USB_KEYBOARD if DISTRO_DEFAULTS && USB_HOST > - select USB_STORAGE if DISTRO_DEFAULTS && USB_HOST > select SPL_USE_TINY_PRINTF > select USE_PREBOOT > select SYS_RELOC_GD_ENV_ADDR