From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 26C93C4332F for ; Fri, 11 Nov 2022 01:12:58 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DD255850D4; Fri, 11 Nov 2022 02:12:55 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id BA45B850DE; Fri, 11 Nov 2022 02:12:53 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id 3017B84FB2 for ; Fri, 11 Nov 2022 02:12:51 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D342B1FB; Thu, 10 Nov 2022 17:12:56 -0800 (PST) Received: from slackpad.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 08C803F703; Thu, 10 Nov 2022 17:12:49 -0800 (PST) Date: Fri, 11 Nov 2022 01:11:28 +0000 From: Andre Przywara To: Samuel Holland Cc: Jagan Teki , u-boot@lists.denx.de Subject: Re: [PATCH 03/22] sunxi: Add missing dependencies to Kconfig selections Message-ID: <20221111011128.50c77032@slackpad.lan> In-Reply-To: <20221101050835.2421-4-samuel@sholland.org> References: <20221101050835.2421-1-samuel@sholland.org> <20221101050835.2421-4-samuel@sholland.org> Organization: Arm Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Tue, 1 Nov 2022 00:08:15 -0500 Samuel Holland wrote: > Some of the selected symbols have a user-visible dependency. Make the > selections conditional on that dependency to avoid creating invalid > configurations. No change in any of the generated configs, so looks fine: > Signed-off-by: Samuel Holland Reviewed-by: Andre Przywara Thanks, Andre > --- > > arch/arm/Kconfig | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 939f76867e..4e5daa9e7f 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -1134,30 +1134,30 @@ config ARCH_SOCFPGA > config ARCH_SUNXI > bool "Support sunxi (Allwinner) SoCs" > select BINMAN > - select CMD_GPIO > + select CMD_GPIO if GPIO > select CMD_MMC if MMC > select CMD_USB if DISTRO_DEFAULTS && USB_HOST > select CLK > select DM > - select DM_ETH > - select DM_GPIO > + select DM_ETH if NET > + select DM_GPIO if GPIO > select DM_I2C if I2C > + select DM_SCSI if BLK && SCSI > + select DM_SERIAL if SERIAL > select DM_SPI if SPI > select DM_SPI_FLASH if SPI > - select DM_SCSI if SCSI > - select DM_SERIAL > select GPIO_EXTRA_HEADER > select OF_BOARD_SETUP > select OF_CONTROL > select OF_SEPARATE > select PINCTRL > - select SPECIFY_CONSOLE_INDEX > + select SPECIFY_CONSOLE_INDEX if SERIAL > select SPL_SEPARATE_BSS if SPL > select SPL_STACK_R if SPL > select SPL_SYS_MALLOC_SIMPLE if SPL > select SPL_SYS_THUMB_BUILD if !ARM64 > - select SUNXI_GPIO > - select SYS_NS16550 > + select SUNXI_GPIO if GPIO > + select SYS_NS16550 if SERIAL > select SYS_THUMB_BUILD if !ARM64 > select USB if DISTRO_DEFAULTS > select USB_KEYBOARD if DISTRO_DEFAULTS && USB_HOST