From: Andre Przywara <andre.przywara@arm.com>
To: Samuel Holland <samuel@sholland.org>
Cc: Jagan Teki <jagan@amarulasolutions.com>, u-boot@lists.denx.de
Subject: Re: [PATCH 04/22] sunxi: Hide image type selection if SPL is disabled
Date: Fri, 11 Nov 2022 01:12:35 +0000 [thread overview]
Message-ID: <20221111011235.503f378a@slackpad.lan> (raw)
In-Reply-To: <20221101050835.2421-5-samuel@sholland.org>
On Tue, 1 Nov 2022 00:08:16 -0500
Samuel Holland <samuel@sholland.org> wrote:
> This choice is meaningless when SPL is disabled. Hide it to avoid any
> possible confusion.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Cheers,
Andre
> ---
>
> board/sunxi/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/board/sunxi/Kconfig b/board/sunxi/Kconfig
> index 084a8b0c6c..42f61df5c5 100644
> --- a/board/sunxi/Kconfig
> +++ b/board/sunxi/Kconfig
> @@ -1,5 +1,6 @@
> choice
> prompt "SPL Image Type"
> + depends on SPL
> default SPL_IMAGE_TYPE_SUNXI_EGON
>
> config SPL_IMAGE_TYPE_SUNXI_EGON
next prev parent reply other threads:[~2022-11-11 1:14 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 5:08 [PATCH 00/22] sunxi: Prepare platform Kconfig to support multiple architectures Samuel Holland
2022-11-01 5:08 ` [PATCH 01/22] sunxi: Fix default-enablement of USB host drivers Samuel Holland
2022-11-11 1:09 ` Andre Przywara
2022-11-01 5:08 ` [PATCH 02/22] sunxi: Remove unnecessary Kconfig selections Samuel Holland
2022-11-11 1:09 ` Andre Przywara
2022-11-01 5:08 ` [PATCH 03/22] sunxi: Add missing dependencies to " Samuel Holland
2022-11-11 1:11 ` Andre Przywara
2022-11-01 5:08 ` [PATCH 04/22] sunxi: Hide image type selection if SPL is disabled Samuel Holland
2022-11-11 1:12 ` Andre Przywara [this message]
2022-11-01 5:08 ` [PATCH 05/22] sunxi: Share the board Kconfig across architectures Samuel Holland
2022-11-01 5:08 ` [PATCH 06/22] sunxi: Move most Kconfig selections to the board Kconfig Samuel Holland
2022-11-01 5:08 ` [PATCH 07/22] sunxi: Globally enable SUPPORT_SPL Samuel Holland
2022-11-01 5:08 ` [PATCH 08/22] sunxi: Downgrade driver selections to implications Samuel Holland
2022-11-01 5:08 ` [PATCH 09/22] sunxi: Enable the I2C driver by default Samuel Holland
2022-11-01 5:08 ` [PATCH 10/22] sunxi: Move default values to the board Kconfig Samuel Holland
2022-11-01 5:08 ` [PATCH 11/22] sunxi: Hide the SUNXI_MINIMUM_DRAM_MB symbol Samuel Holland
2022-11-01 5:08 ` [PATCH 12/22] sunxi: Clean up the SPL_STACK_R_ADDR defaults Samuel Holland
2022-11-01 5:08 ` [PATCH 13/22] sunxi: Move PRE_CON_BUF_ADDR to the board Kconfig Samuel Holland
2022-11-01 5:08 ` [PATCH 14/22] sunxi: Move SPL_BSS_START_ADDR " Samuel Holland
2022-11-01 5:08 ` [PATCH 15/22] sunxi: Move SPL_TEXT_BASE " Samuel Holland
2022-11-01 5:08 ` [PATCH 16/22] sunxi: Move SYS_LOAD_ADDR " Samuel Holland
2022-11-01 5:08 ` [PATCH 17/22] sunxi: Move TEXT_BASE " Samuel Holland
2022-11-01 5:08 ` [PATCH 18/22] sunxi: Move most board options " Samuel Holland
2022-11-01 5:08 ` [PATCH 19/22] env: sunxi: Replace ARCH_SUNXI with BOARD_SUNXI Samuel Holland
2022-11-01 5:08 ` [PATCH 20/22] drivers: " Samuel Holland
2022-11-01 5:08 ` [PATCH 21/22] disk: " Samuel Holland
2022-11-01 5:08 ` [PATCH 22/22] spl: " Samuel Holland
2022-11-03 16:46 ` [PATCH 00/22] sunxi: Prepare platform Kconfig to support multiple architectures Andre Przywara
2022-11-06 22:32 ` Samuel Holland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221111011235.503f378a@slackpad.lan \
--to=andre.przywara@arm.com \
--cc=jagan@amarulasolutions.com \
--cc=samuel@sholland.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox