From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 88E38C43219 for ; Fri, 11 Nov 2022 01:14:04 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4B078850D4; Fri, 11 Nov 2022 02:14:02 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id C0A78850DE; Fri, 11 Nov 2022 02:14:00 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id 639C285041 for ; Fri, 11 Nov 2022 02:13:58 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0DDD71FB; Thu, 10 Nov 2022 17:14:04 -0800 (PST) Received: from slackpad.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 36F5D3F703; Thu, 10 Nov 2022 17:13:57 -0800 (PST) Date: Fri, 11 Nov 2022 01:12:35 +0000 From: Andre Przywara To: Samuel Holland Cc: Jagan Teki , u-boot@lists.denx.de Subject: Re: [PATCH 04/22] sunxi: Hide image type selection if SPL is disabled Message-ID: <20221111011235.503f378a@slackpad.lan> In-Reply-To: <20221101050835.2421-5-samuel@sholland.org> References: <20221101050835.2421-1-samuel@sholland.org> <20221101050835.2421-5-samuel@sholland.org> Organization: Arm Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Tue, 1 Nov 2022 00:08:16 -0500 Samuel Holland wrote: > This choice is meaningless when SPL is disabled. Hide it to avoid any > possible confusion. > > Signed-off-by: Samuel Holland Reviewed-by: Andre Przywara Cheers, Andre > --- > > board/sunxi/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/board/sunxi/Kconfig b/board/sunxi/Kconfig > index 084a8b0c6c..42f61df5c5 100644 > --- a/board/sunxi/Kconfig > +++ b/board/sunxi/Kconfig > @@ -1,5 +1,6 @@ > choice > prompt "SPL Image Type" > + depends on SPL > default SPL_IMAGE_TYPE_SUNXI_EGON > > config SPL_IMAGE_TYPE_SUNXI_EGON