From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6CC4DC4332F for ; Fri, 11 Nov 2022 15:36:07 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6595B850E2; Fri, 11 Nov 2022 16:36:05 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="gIyScFKX"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3BC1F85100; Fri, 11 Nov 2022 16:36:03 +0100 (CET) Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E23BC850E2 for ; Fri, 11 Nov 2022 16:35:59 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x731.google.com with SMTP id i9so3146464qki.10 for ; Fri, 11 Nov 2022 07:35:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Uh888O1ozV1OTLVz2gHHnGfnb0/ZnWiDC5D7GSlZ/fk=; b=gIyScFKXk1nli1hYT9q7TTlAlm8butMtp+xVa+XqBezHQrEsENzWyhkK8HA8Ey+KcD uBE93IOzhSLoJRNingSMLZpfNBK+zY2DUn4yJHdXJ+wdp8f4MkXO4ZXUBe3RT0xvvHL3 Feyr5ZILyPPrAx1iblW95mQcQRRdIgS/S9c18= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Uh888O1ozV1OTLVz2gHHnGfnb0/ZnWiDC5D7GSlZ/fk=; b=R3jcKJOuAi0wHtbZVL+csCRozaFF5KmdD06PgEjp4d7aqap45NlU/kIVi+ZTfsKotT zZOV9XYfSKddNFrc7rRvUUIdB7ROUMcMIp535RxJndg3cfpwoQ3oCUMrM0miE0prc5YL RYANWi3GedGHwlTUcAH3WQlYx/v5xl5fy5p+HP9/UjBwnZTsdVyKykGIkRP9EojQocey NtwpN7mHEvTpWy6w6GTUpa496jwLsCJY6Eq8Uci19fMWfsiXetkFEvqTHfhJ/wszkTkH 2bKAVAn6uCv5dX7Oi8KT6kAzIqarDVL7bM0hFjgg23sckqT/d5LG0L+jkxyZrOpja5Hd VhBg== X-Gm-Message-State: ANoB5pkGLku0fe62at8YN2qEDV3wNtchlsP+2AI0r8gOn222gQyOsmJg O/TVtL1iivl5aFwJd49IWtGNsg== X-Google-Smtp-Source: AA0mqf6GBQxgbyK5G4MopqKuBuOdvPPqZBmNZPel/9eqBS+YU1CZYtI+kv1ZYqSEZw3v1u8IDeoU7Q== X-Received: by 2002:a05:620a:a56:b0:6bb:572:3d5a with SMTP id j22-20020a05620a0a5600b006bb05723d5amr1477084qka.476.1668180958534; Fri, 11 Nov 2022 07:35:58 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-f01b-b001-30c4-7060.res6.spectrum.com. [2603:6081:7b00:6400:f01b:b001:30c4:7060]) by smtp.gmail.com with ESMTPSA id ay40-20020a05620a17a800b006cbe3be300esm1609294qkb.12.2022.11.11.07.35.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Nov 2022 07:35:58 -0800 (PST) Date: Fri, 11 Nov 2022 10:35:56 -0500 From: Tom Rini To: Detlev Casanova Cc: u-boot@lists.denx.de, Stefano Babic , Fabio Estevam , "NXP i . MX U-Boot Team" Subject: Re: [PATCH] dts: Re-add aliases for imx6qdl-sabrelite devices Message-ID: <20221111153556.GF7282@bill-the-cat> References: <20221027152252.46552-1-detlev.casanova@collabora.com> <20221027183051.GN2020586@bill-the-cat> <13125638.O9o76ZdvQC@falcon9> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="19uQFt6ulqmgNgg1" Content-Disposition: inline In-Reply-To: <13125638.O9o76ZdvQC@falcon9> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --19uQFt6ulqmgNgg1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 11, 2022 at 10:28:43AM -0500, Detlev Casanova wrote: > On Thursday, October 27, 2022 2:30:51 P.M. EST Tom Rini wrote: > > On Thu, Oct 27, 2022 at 11:22:52AM -0400, Detlev Casanova wrote: > > > In commit d0399a46e7cda63c07e3eb8558bef84cfb068028, the device tree w= as > > > synchronized from linux and the aliases were dropped. > > >=20 > > > They need to be kept so that the mmc cards are in the right order. > > > Without the aliases, u-boot reports: > > > MMC: FSL_SDHC: 2, FSL_SDHC: 3 > > >=20 > > > With the aliases, u-boot reports: > > > MMC: FSL_SDHC: 0, FSL_SDHC: 1 > > >=20 > > > Signed-off-by: Detlev Casanova > > > --- > > >=20 > > > arch/arm/dts/imx6qdl-sabrelite.dtsi | 7 +++++++ > > > 1 file changed, 7 insertions(+) > > >=20 > > > diff --git a/arch/arm/dts/imx6qdl-sabrelite.dtsi > > > b/arch/arm/dts/imx6qdl-sabrelite.dtsi index 22f8e2783c..6564e3b82c 10= 0644 > > > --- a/arch/arm/dts/imx6qdl-sabrelite.dtsi > > > +++ b/arch/arm/dts/imx6qdl-sabrelite.dtsi > > > @@ -10,6 +10,13 @@ > > >=20 > > > #include > > > =20 > > > / { > > >=20 > > > + aliases { > > > + mmc0 =3D &usdhc3; > > > + mmc1 =3D &usdhc4; > > > + pwm_lcd =3D &pwm1; > > > + pwm_lvds =3D &pwm4; > > > + }; > > > + > > >=20 > > > chosen { > > > =09 > > > stdout-path =3D &uart2; > > > =09 > > > }; > >=20 > > This really belongs in the upstream dts file so they aren't lost again > > and again. >=20 > Forwaded to upstream kernel: https://lore.kernel.org/lkml/20221028141811.= 101122-1-detlev.casanova@collabora.com/[1] >=20 > Would it make sense to still add this one in u-boot before the devices tr= ees are copied again ? Yes, it would make sense to pick it up now to fix the regression here. Thanks for pushing it upstream! --=20 Tom --19uQFt6ulqmgNgg1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmNua9UACgkQFHw5/5Y0 tywHJQwAlTRF3RDzspcLAmeILAQ/Gz/1UPZZ/zvVpqWmgRJ0lUkiVD/UUtPyeg/X q/x5sxw+FsS7sWzs2JAJ1R7SyEdAwmey0HrctyRf+POLx9FZOcUPO51SO8jbT0tS ZJDBxVaIfWG1YnHW8xfd9pAjhfmC5FdmL6MdNiGulYnw5FQqHEJSSwPAHHr+2zuL P4VAkHaLakolSBBPCqAmLrg0w40jdyl1TYkrr4Md5IX5bLcBcXh/UMLZ91Q5VbHS 0Z/PpY8x0/o6RqRLpIMoJoC9/8+u6wqvDURFB3MqlLphRqXy60m2A9TCLQe4nLuX 8PCL0SuOORtflMqe9UM6VIcrcwntiCy5PZ4aUqztfZEEjBJR5bkQXwB1p26Jsidx KEK3+HqSzVu4HnalfB+5njjn4HFtR3TA8rmwVbguAjT44UCRMVa2CJDenwsrKeqf ODQen4iozpEW2fWMqBlZNXDehiEnXt34NeaTxTZ2pT6q1wkZRbZLiAMLO7z6tptw Ql19sFxT =22vr -----END PGP SIGNATURE----- --19uQFt6ulqmgNgg1--