From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A91B1C4332F for ; Fri, 18 Nov 2022 13:48:25 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E87318524D; Fri, 18 Nov 2022 14:48:22 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="SwRrfITV"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 392718515F; Fri, 18 Nov 2022 14:48:21 +0100 (CET) Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 722488515F for ; Fri, 18 Nov 2022 14:48:18 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=oliver.graute@gmail.com Received: by mail-ej1-x633.google.com with SMTP id ud5so13180510ejc.4 for ; Fri, 18 Nov 2022 05:48:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=1UV/8ksii2zJQaIbLK2KlJ6b7bZzeXqz74wVVbIVU/0=; b=SwRrfITVVgDharYtx2Xy2kJ8A9vsgJMuRGY/lxJEfPxr3qwZ/Qh6332K3p5Fj9F586 OYTAfM7Cevd6H6+RDjO40/8Iv420o3A/rcZ91QSV67yjOPMtGKPIcyZBpEvf5q0LVQjn Fvi8b2Barn1NTd8PNIv0nmaLESvpFH0XMz6UxFezwQieLSF/RFFxxIc3+U/I7Q+Mv98H d9CxvtpuOQBpp9NTLjyxqf7Hu9WDnk/gXaEUvNIMa2+6K3uU5MuMBz0cEdhkJcW1ogSk X4cR7oUepleVT3lKcSMcnvs8gZlbkQdqqsEL12DY8kAMDX676WHU16pjEses0CuGf1Uj IrqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1UV/8ksii2zJQaIbLK2KlJ6b7bZzeXqz74wVVbIVU/0=; b=E8UOXXlMd2aE7OMvLPle33qQ4rujPIfw6vK/ftlrgjDytAvestr8f3DhkqMlNJtbYp zy9O2UCyZp9iQ3zSOqlQra+nD7/C1G0Q0CsCoDDxQ0bRAfMQ+il4e+MXK3Oo5TgJJ1ek gtC9oUVkMzwyaqUySPQnuigreAHKvAZghSlNBvwKl1ccT8UQV0dL4WtYBip+f5rghEEh h6XXGXE6vlDwUKr9QkZj/Qj7UXI2JnExeFHfi8tg22v9CaZVIJAqfYzvGFyHN1as/u1R 6NPfD3WhVQS9m50o/c3gOeHk+od8pnY7VLQofTCXVZUgVdlFRkAJK50+he95H3FNQ7Tv dwHQ== X-Gm-Message-State: ANoB5pmHy6+4dFmAKhFIrKkA48GYH0PnvPHOxELCvdJ+A+tQp9Rl93FZ Z87wHoa2kxp1FdrM0PeWPlU= X-Google-Smtp-Source: AA0mqf5F8CyfGtMI+HlKGUypukqg2N5uMzsEhzkl6oxcGwqlOv3E/29k3qcdXsU3tRw/Xz7+AhIsKA== X-Received: by 2002:a17:906:2650:b0:7b2:c004:55fe with SMTP id i16-20020a170906265000b007b2c00455femr1741970ejc.742.1668779297825; Fri, 18 Nov 2022 05:48:17 -0800 (PST) Received: from localhost (business-90-187-74-145.pool2.vodafone-ip.de. [90.187.74.145]) by smtp.gmail.com with ESMTPSA id g5-20020a056402114500b00467cc919072sm1813204edw.17.2022.11.18.05.48.16 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 18 Nov 2022 05:48:16 -0800 (PST) Date: Fri, 18 Nov 2022 13:35:59 +0100 From: Oliver Graute To: Fabio Estevam Cc: Stefano Babic , Marcel Ziswiler , Ye Li , peng.fan@nxp.com, uboot-imx@nxp.com, u-boot@lists.denx.de, Simon Glass , alpernebiyasak@gmail.com Subject: Re: [PATCH v2 0/8] imx8: switch missing boards to binman Message-ID: <20221118123559.GB2534@optiplex> Mail-Followup-To: Fabio Estevam , Stefano Babic , Marcel Ziswiler , Ye Li , peng.fan@nxp.com, uboot-imx@nxp.com, u-boot@lists.denx.de, Simon Glass , alpernebiyasak@gmail.com References: <20221104150345.23853-1-oliver.graute@kococonnector.com> <20221109161927.GB17674@optiplex> <20221111125303.GA2534@optiplex> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 11/11/22, Fabio Estevam wrote: > Hi Oliver, > > On Fri, Nov 11, 2022 at 9:54 AM Oliver Graute wrote: > > > imx8mm_evk_defconfig > > apalis-imx8_defconfig > > > > But where is the difference here? > > With the change below, the imx8qm_mek_defconfig builds without errors > in the absence of the blobs: > > diff --git a/arch/arm/dts/imx8qm-u-boot.dtsi b/arch/arm/dts/imx8qm-u-boot.dtsi > index 3507489a813c..442e64badc39 100644 > --- a/arch/arm/dts/imx8qm-u-boot.dtsi > +++ b/arch/arm/dts/imx8qm-u-boot.dtsi > @@ -50,7 +50,7 @@ > arch = "arm64"; > compression = "none"; > description = "U-Boot (64-bit)"; > - load = ; > + load = ; > type = "standalone"; > > uboot-blob { > diff --git a/arch/arm/dts/imx8qxp-u-boot.dtsi b/arch/arm/dts/imx8qxp-u-boot.dtsi > index 01183f8ade63..e8df5bb8bfea 100644 > --- a/arch/arm/dts/imx8qxp-u-boot.dtsi > +++ b/arch/arm/dts/imx8qxp-u-boot.dtsi > @@ -50,7 +50,7 @@ > arch = "arm64"; > compression = "none"; > description = "U-Boot (64-bit)"; > - load = ; > + load = ; > type = "standalone"; > > uboot-blob { > diff --git a/configs/imx8qm_mek_defconfig b/configs/imx8qm_mek_defconfig > index 4fc828681b6c..4c220188fbb6 100644 > --- a/configs/imx8qm_mek_defconfig > +++ b/configs/imx8qm_mek_defconfig > @@ -3,21 +3,12 @@ CONFIG_ARCH_IMX8=y > CONFIG_TEXT_BASE=0x80020000 > CONFIG_SYS_MALLOC_LEN=0x2400000 > CONFIG_SYS_MALLOC_F_LEN=0x8000 > -CONFIG_SPL_GPIO=y > -CONFIG_SPL_LIBCOMMON_SUPPORT=y > -CONFIG_SPL_LIBGENERIC_SUPPORT=y > CONFIG_NR_DRAM_BANKS=3 > CONFIG_ENV_SIZE=0x1000 > CONFIG_ENV_OFFSET=0x400000 > CONFIG_DM_GPIO=y > CONFIG_DEFAULT_DEVICE_TREE="fsl-imx8qm-mek" > -CONFIG_SPL_TEXT_BASE=0x100000 > CONFIG_TARGET_IMX8QM_MEK=y > -CONFIG_SPL_MMC=y > -CONFIG_SPL_SERIAL=y > -CONFIG_SPL_DRIVERS_MISC=y > -CONFIG_SPL=y > -CONFIG_SPL_LOAD_IMX_CONTAINER=y > CONFIG_IMX_CONTAINER_CFG="board/freescale/imx8qm_mek/uboot-container.cfg" > CONFIG_SYS_LOAD_ADDR=0x80280000 > CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y > @@ -32,22 +23,8 @@ CONFIG_USE_BOOTCOMMAND=y > CONFIG_BOOTCOMMAND="mmc dev ${mmcdev}; if mmc rescan; then if run > loadbootscript; then run bootscript; else if test ${sec_boot} = yes; > then if run loadcntr; then run mmcboot; else run netboot; fi; else if > run loadimage; then run mmcboot; else run netboot; fi; fi; fi; else > booti ${loadaddr} - ${fdt_addr}; fi" > CONFIG_LOG=y > CONFIG_BOARD_EARLY_INIT_F=y > -CONFIG_SPL_MAX_SIZE=0x1f000 > -CONFIG_SPL_HAS_BSS_LINKER_SECTION=y > -CONFIG_SPL_BSS_START_ADDR=0x128000 > -CONFIG_SPL_BSS_MAX_SIZE=0x1000 > -CONFIG_SPL_BOARD_INIT=y > -CONFIG_SPL_SYS_MALLOC_SIMPLE=y > -# CONFIG_SPL_SHARES_INIT_SP_ADDR is not set > -CONFIG_SPL_STACK=0x13e000 > -CONFIG_SYS_SPL_MALLOC=y > -CONFIG_HAS_CUSTOM_SPL_MALLOC_START=y > -CONFIG_CUSTOM_SYS_SPL_MALLOC_ADDR=0x120000 > -CONFIG_SYS_SPL_MALLOC_SIZE=0x3000 > CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR=y > CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR=0x800 > -CONFIG_SPL_POWER_DOMAIN=y > -CONFIG_SPL_WATCHDOG=y > CONFIG_HUSH_PARSER=y > CONFIG_SYS_CBSIZE=256 > CONFIG_SYS_PBSIZE=276 > @@ -66,14 +43,11 @@ CONFIG_CMD_MII=y > CONFIG_CMD_PING=y > CONFIG_CMD_CACHE=y > CONFIG_CMD_FAT=y > -CONFIG_SPL_OF_CONTROL=y > CONFIG_ENV_OVERWRITE=y > CONFIG_ENV_IS_IN_MMC=y > CONFIG_SYS_RELOC_GD_ENV_ADDR=y > CONFIG_SYS_MMC_ENV_DEV=1 > CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y > -CONFIG_SPL_DM=y > -CONFIG_SPL_CLK=y > CONFIG_CLK_IMX8=y > CONFIG_CPU=y > CONFIG_MXC_GPIO=y > @@ -93,16 +67,12 @@ CONFIG_FEC_MXC_MDIO_BASE=0x5B040000 > CONFIG_FEC_MXC=y > CONFIG_MII=y > CONFIG_PINCTRL=y > -CONFIG_SPL_PINCTRL=y > CONFIG_PINCTRL_IMX8=y > CONFIG_POWER_DOMAIN=y > CONFIG_IMX8_POWER_DOMAIN=y > CONFIG_DM_REGULATOR=y > -CONFIG_SPL_DM_REGULATOR=y > CONFIG_DM_REGULATOR_FIXED=y > CONFIG_DM_REGULATOR_GPIO=y > -CONFIG_SPL_DM_REGULATOR_GPIO=y > CONFIG_DM_SERIAL=y > CONFIG_FSL_LPUART=y > -CONFIG_SPL_TINY_MEMSET=y > # CONFIG_EFI_LOADER is not set > > I removed SPL support, which does not seems to be needed as the scufw > handles DDR init. I know that DDR init is done in scfw for imx8qm. Because I patched these values gotten from a NXP Excel RPA sheet into our scfw a year ago as we got our Micron LPDDR4. But I wasn't aware that then the SPL stuff is superflous then. Is this really the case? Is there no other reason for SPL? Can you confirm? > > I don't have access to an imx8qm/qxp board here. > > Could you try removing SPL support from your board and see if it boots > with binman support? Ok, first I removed SPL Config for imx8qm_dmsse20 board posted here [1] Because this is my current develop setup. The imx8qm_rom7720 and cgt8mx will follow (perhaps next week). So this Board is booting without SPL. But I run into somme mmc issues. U-Boot 2023.01-rc1-00056-gb805f40911-dirty (Nov 18 2022 - 13:05:16 +0100) Model: Advantech iMX8QM DMSSE20 Board: DMS-SE20A1 8GB Build: SCFW 549b1e18, SECO-FW c9de51c0, ATF 5782363 Boot: USB DRAM: 8 GiB Core: 100 devices, 19 uclasses, devicetree: separate MMC: FSL_SDHC: 0, FSL_SDHC: 1, FSL_SDHC: 2 Loading Environment from MMC... OK In: serial@5a060000 Out: serial@5a060000 Err: serial@5a060000 Net: Warning: ethernet@5b040000 (eth0) using random MAC address - 5a:25:75:2d:65:75 eth0: ethernet@5b040000 Warning: ethernet@5b050000 (eth1) using random MAC address - ca:41:6e:6d:75:10 , eth1: ethernet@5b050000 Hit any key to stop autoboot: 0 Card did not respond to voltage select! : -110 Card did not respond to voltage select! : -110 Card did not respond to voltage select! : -110 ** Bad device specification mmc 2 ** Couldn't find partition mmc 2:1 Can't set block device Card did not respond to voltage select! : -110 Card did not respond to voltage select! : -110 ** Bad device specification mmc 2 ** Couldn't find partition mmc 2:1 Can't set block device Wrong Image Format for bootm command ERROR: can't get kernel image! switch to partitions #0, OK mmc0(part 0) is current device [1] https://patchwork.ozlabs.org/project/uboot/patch/20221007131158.14094-1-oliver.graute@kococonnector.com/ Best regards, Oliver