Re: [PATCH v2 0/8] imx8: switch missing boards to binman

[Oliver Graute <oliver.graute@gmail.com>]

On 11/11/22, Fabio Estevam wrote:
> On Fri, Nov 11, 2022 at 2:40 PM Fabio Estevam <festevam@gmail.com> wrote:
> 
> > I removed SPL support, which does not seems to be needed as the scufw
> > handles DDR init.
> >
> > I don't have access to an imx8qm/qxp board here.
> >
> > Could you try removing SPL support from your board and see if it boots
> > with binman support?
> 
> Ok, let's SPL for now as this is a different topic for discussion.
> 
> 
> With the change below against u-boot-imx master-next branch, the
> imx8qm/qxp boards build fine without blobs:
> 
> diff --git a/arch/arm/dts/imx8qm-u-boot.dtsi b/arch/arm/dts/imx8qm-u-boot.dtsi
> index 3507489a813c..a3e0af48109b 100644
> --- a/arch/arm/dts/imx8qm-u-boot.dtsi
> +++ b/arch/arm/dts/imx8qm-u-boot.dtsi
> @@ -10,7 +10,7 @@
>  };
> 
>  &binman {
> -#ifdef CONFIG_SPL
> +#ifdef CONFIG_SPL_BUILD
>         u-boot-spl-ddr {
>                 align = <4>;
>                 align-size = <4>;
> @@ -50,7 +50,7 @@
>                                         arch = "arm64";
>                                         compression = "none";
>                                         description = "U-Boot (64-bit)";
> -                                       load = <CONFIG_SYS_TEXT_BASE>;
> +                                       load = <CONFIG_TEXT_BASE>;
>                                         type = "standalone";
> 
>                                         uboot-blob {
> diff --git a/arch/arm/dts/imx8qxp-u-boot.dtsi b/arch/arm/dts/imx8qxp-u-boot.dtsi
> index 01183f8ade63..7622c40906f1 100644
> --- a/arch/arm/dts/imx8qxp-u-boot.dtsi
> +++ b/arch/arm/dts/imx8qxp-u-boot.dtsi
> @@ -10,7 +10,7 @@
>  };
> 
>  &binman {
> -#ifdef CONFIG_SPL
> +#ifdef CONFIG_SPL_BUILD
>         u-boot-spl-ddr {
>                 align = <4>;
>                 align-size = <4>;
> @@ -50,7 +50,7 @@
>                                         arch = "arm64";
>                                         compression = "none";
>                                         description = "U-Boot (64-bit)";
> -                                       load = <CONFIG_SYS_TEXT_BASE>;
> +                                       load = <CONFIG_TEXT_BASE>;
>                                         type = "standalone";
> 
>                                         uboot-blob {


> 
> Could you please test it on your boards?

Ok, I can confirm it builds without the binary blobs with this changes.
I'll change it in patches accordingly

Best regards,

Oliver