Re: [PATCH v2 8/8] imx: imx8: apalis: switch to binman

Marcel Ziswiler
2022-11-09T17:47:40Z

Hi Oliver

Thanks for working on this.

On Fri, 2022-11-04 at 16:03 +0100, Oliver Graute wrote:
> Switch to use binman to pack images
>
> Signed-off-by: Oliver Graute <oliver.graute@kococonnector.com>
> ---
> Changes for v2
>  - use common imx8qm-u-boot.dtsi
>  - guard SPL nodes with CONFIG_SPL

I don't think it is that simple. Even after guarding them SPL nodes the flash.bin one still references them,
not? And yes, so far we never used SPL for them 8/8X as that honestly does not really make much sense given the
SCFW does the actual RAM initialisation. Anyway, I am not very clear on how/what exactly that all means now.

Another topic is that flash.bin is now just the SPL whereas previously u-boot-dtb.imx was the entire thing. But
again, that could have been related to us not using SPL.

>  arch/arm/dts/fsl-imx8qm-apalis-u-boot.dtsi | 2 ++
>  arch/arm/dts/imx8qm-u-boot.dtsi            | 2 ++
>  arch/arm/mach-imx/imx8/Kconfig             | 1 +
>  configs/apalis-imx8_defconfig              | 1 +
>  4 files changed, 6 insertions(+)
>
> diff --git a/arch/arm/dts/fsl-imx8qm-apalis-u-boot.dtsi b/arch/arm/dts/fsl-imx8qm-apalis-u-boot.dtsi
> index 956d724979..8fd0e33d2b 100644
> --- a/arch/arm/dts/fsl-imx8qm-apalis-u-boot.dtsi
> +++ b/arch/arm/dts/fsl-imx8qm-apalis-u-boot.dtsi
> @@ -3,6 +3,8 @@
>   * Copyright 2019 Toradex AG
>   */
>
> +#include "imx8qm-u-boot.dtsi"
> +
>  &mu {
>         u-boot,dm-pre-proper;
>  };
> diff --git a/arch/arm/dts/imx8qm-u-boot.dtsi b/arch/arm/dts/imx8qm-u-boot.dtsi
> index f3fc90c9bb..3507489a81 100644
> --- a/arch/arm/dts/imx8qm-u-boot.dtsi
> +++ b/arch/arm/dts/imx8qm-u-boot.dtsi
> @@ -10,6 +10,7 @@
>  };
>
>  &binman {
> +#ifdef CONFIG_SPL
>         u-boot-spl-ddr {
>                 align = <4>;
>                 align-size = <4>;
> @@ -33,6 +34,7 @@
>                         };
>                 };
>         };
> +#endif
>
>         itb {
>                 filename = "u-boot.itb";
> diff --git a/arch/arm/mach-imx/imx8/Kconfig b/arch/arm/mach-imx/imx8/Kconfig
> index 37d12d1895..91bd888308 100644
> --- a/arch/arm/mach-imx/imx8/Kconfig
> +++ b/arch/arm/mach-imx/imx8/Kconfig
> @@ -46,6 +46,7 @@ choice
>
>  config TARGET_APALIS_IMX8
>         bool "Support Apalis iMX8 module"
> +       select BINMAN
>         select BOARD_LATE_INIT
>         select IMX8QM
>
> diff --git a/configs/apalis-imx8_defconfig b/configs/apalis-imx8_defconfig
> index 32e105a557..0c331b62cb 100644
> --- a/configs/apalis-imx8_defconfig
> +++ b/configs/apalis-imx8_defconfig
> @@ -17,6 +17,7 @@ CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
>  CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x80200000
>  CONFIG_REMAKE_ELF=y
>  CONFIG_FIT=y
> +CONFIG_FIT_EXTERNAL_OFFSET=0x3000

Also not quite sure what exactly that is now.

>  CONFIG_FIT_VERBOSE=y
>  CONFIG_OF_SYSTEM_SETUP=y
>  CONFIG_LOG=y

Cheers

Marcel