Re: [PATCH v2 0/8] imx8: switch missing boards to binman

Oliver Graute
2022-11-22T14:24:26Z

On 11/11/22, Fabio Estevam wrote:
> On Fri, Nov 11, 2022 at 2:40 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> > I removed SPL support, which does not seems to be needed as the scufw
> > handles DDR init.
> >
> > I don't have access to an imx8qm/qxp board here.
> >
> > Could you try removing SPL support from your board and see if it boots
> > with binman support?
>
> Ok, let's SPL for now as this is a different topic for discussion.
>
>
> With the change below against u-boot-imx master-next branch, the
> imx8qm/qxp boards build fine without blobs:
>
> diff --git a/arch/arm/dts/imx8qm-u-boot.dtsi b/arch/arm/dts/imx8qm-u-boot.dtsi
> index 3507489a813c..a3e0af48109b 100644
> --- a/arch/arm/dts/imx8qm-u-boot.dtsi
> +++ b/arch/arm/dts/imx8qm-u-boot.dtsi
> @@ -10,7 +10,7 @@
> };
>
> &binman {
> -#ifdef CONFIG_SPL
> +#ifdef CONFIG_SPL_BUILD

On building the imx8qm_rom7720 board the CONFIG_SPL_BUILD define is
somehow always false. So I endup in a invalid image:

Image 'main-section' is missing external blobs and is non-functional: spl
Image 'main-section' has faked external blobs and is non-functional: spl.bin

Some images are invalid

With CONFIG_SPL instead of CONFIG_SPL_BUILD its working again. So the
Question is why is CONFIG_SPL true and CONFIG_SPL_BUILD false here?

Some hints?

Best regards,

Oliver