From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1D2BC433FE for ; Mon, 21 Nov 2022 16:01:51 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8BC0D85369; Mon, 21 Nov 2022 17:01:49 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="UoxxUz++"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0E05B8536F; Mon, 21 Nov 2022 17:01:47 +0100 (CET) Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AADB58532C for ; Mon, 21 Nov 2022 17:01:39 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72f.google.com with SMTP id v8so8272042qkg.12 for ; Mon, 21 Nov 2022 08:01:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DkubVZbg68vk/scUepkCuAFNit5IChadAmXEvxBezxQ=; b=UoxxUz++icENgRAomKSeyqrf3VwKGyliaLewPtoilJlk1JNFGlAoTVkU5ml1yfjYKX Ikqpj06hjiNZrQKipCt6klH9ip4zn3y5gcr9xGbgaPhkBf35CuMdaCvqzhrDg4vlha+v W+Y7t9OLZ4QJ4A69bm6DKhHT9uoefEQtyHRwk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DkubVZbg68vk/scUepkCuAFNit5IChadAmXEvxBezxQ=; b=Lcb3bA8/13mZaSdbIn0Uq1RbFxqlRqSXSx/ihRGbgadpVYgR1iNo8aKvY1Lki8uEIT VU9K4EN+2Hggha1l3k1pzQ7a0Q6txsIRw+BOxNb5+fb225ekByi0UybUk9Ma7qrKMl5O Qzk4FhFNDiLwJo9sd1vpBwNxDMmBZZFJr9g7Ftw47h7Uc8LtCDokYvw0MQGMZkaz4Vt8 ifG7HcBTTD/GOLAhrFxBDDhRRI90dF1aJNshTtOJTMl/BwojI63JzpmJIrqIPMSQHRZW 3K4T0/1KO3PBkmpYoVGtO3m2tKI4vW4kdP+FO/S2W8hDRk6lq1Fk1CU3DdJJ977DhYEM tFfQ== X-Gm-Message-State: ANoB5pmVTL9ezdtCVbEyftfxTfRW5PndLKPiSlIGdW/NWVdyQfM1pqcE rrghYlqujT+CwP/krZBJnPviAg== X-Google-Smtp-Source: AA0mqf6W8aVbHr22oCWPhpZPNzE8pz5iQ2hxRiwV37JR6a8BuJSCh2ydahQo0RH6v7ei0B09ndm2Eg== X-Received: by 2002:a05:620a:571:b0:6fb:85ad:7019 with SMTP id p17-20020a05620a057100b006fb85ad7019mr16639433qkp.661.1669046497113; Mon, 21 Nov 2022 08:01:37 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-91a3-6c7b-3405-8039.res6.spectrum.com. [2603:6081:7b00:6400:91a3:6c7b:3405:8039]) by smtp.gmail.com with ESMTPSA id y19-20020a05620a44d300b006bbf85cad0fsm8796358qkp.20.2022.11.21.08.01.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Nov 2022 08:01:36 -0800 (PST) Date: Mon, 21 Nov 2022 11:01:34 -0500 From: Tom Rini To: Hari Nagalla Cc: lukma@denx.de, seanga2@gmail.com, jh80.chung@samsung.com, nm@ti.com, afd@ti.com, a-nandan@ti.com, u-boot@lists.denx.de Subject: Re: [PATCH 03/12] arm: K3: Add basic support for J784S4 SoC definition Message-ID: <20221121160134.GK7282@bill-the-cat> References: <20221119185933.16194-1-hnagalla@ti.com> <20221119185933.16194-4-hnagalla@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="qjSZefE6w0iW6XmQ" Content-Disposition: inline In-Reply-To: <20221119185933.16194-4-hnagalla@ti.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --qjSZefE6w0iW6XmQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Nov 19, 2022 at 12:59:24PM -0600, Hari Nagalla wrote: > Add basic support for J784S4 SoC definition >=20 > Signed-off-by: Hari Nagalla > Signed-off-by: Apurva Nandan > Signed-off-by: Bryan Bratloff > Signed-off-by: Nishant Menon [snip] > diff --git a/include/configs/j784s4_evm.h b/include/configs/j784s4_evm.h > new file mode 100644 > index 0000000000..c05c16bea1 > --- /dev/null > +++ b/include/configs/j784s4_evm.h > @@ -0,0 +1,146 @@ > +/* SPDX-License-Identifier: GPL-2.0+ */ > +/* > + * Configuration header file for K3 J784S4 EVM > + * > + * Copyright (C) 2022 Texas Instruments Incorporated - https://www.ti.co= m/ > + * Hari Nagalla > + */ > + > +#ifndef __CONFIG_J784S4_EVM_H > +#define __CONFIG_J784S4_EVM_H > + > +#include > +#include > +#include > +#include > +#include > +#include Note that while we do enable DISTRO_DEFAULTS later (and this file should be in that patch), we don't use it. Which isn't great, but isn't a huge problem. > +/* U-Boot general configuration */ > +#define EXTRA_ENV_J784S4_BOARD_SETTINGS \ > + "default_device_tree=3D" CONFIG_DEFAULT_DEVICE_TREE ".dtb\0" \ > + "findfdt=3D" \ > + "setenv name_fdt ${default_device_tree};" \ > + "setenv fdtfile ${name_fdt}\0" \ > + "name_kern=3DImage\0" \ > + "console=3DttyS2,115200n8\0" \ > + "args_all=3Dsetenv optargs earlycon=3Dns16550a,mmio32,0x02880000 " \ > + "${mtdparts}\0" \ > + "run_kern=3Dbooti ${loadaddr} ${rd_spec} ${fdtaddr}\0" > + > +#define PARTS_DEFAULT \ > + /* Linux partitions */ \ > + "uuid_disk=3D${uuid_gpt_disk};" \ > + "name=3Drootfs,start=3D0,size=3D-,uuid=3D${uuid_gpt_rootfs}\0" > + > +#ifdef CONFIG_SYS_K3_SPL_ATF > +#if defined(CONFIG_TARGET_J784S4_R5_EVM) > +#define EXTRA_ENV_R5_SPL_RPROC_FW_ARGS_MMC \ > + "addr_mcur5f0_0load=3D0x89000000\0" \ > + "name_mcur5f0_0fw=3D/lib/firmware/j7-mcu-r5f0_0-fw\0" > +#elif defined(CONFIG_TARGET_J7200_R5_EVM) > +#define EXTRA_ENV_R5_SPL_RPROC_FW_ARGS_MMC \ > + "addr_mcur5f0_0load=3D0x89000000\0" \ > + "name_mcur5f0_0fw=3D/lib/firmware/j7200-mcu-r5f0_0-fw\0" > +#endif /* CONFIG_TARGET_J784S4_R5_EVM */ > +#else > +#define EXTRA_ENV_R5_SPL_RPROC_FW_ARGS_MMC "" > +#endif /* CONFIG_SYS_K3_SPL_ATF */ > + > +/* U-Boot MMC-specific configuration */ > +#define EXTRA_ENV_J784S4_BOARD_SETTINGS_MMC \ > + "boot=3Dmmc\0" \ > + "mmcdev=3D1\0" \ > + "bootpart=3D1:2\0" \ > + "bootdir=3D/boot\0" \ > + EXTRA_ENV_R5_SPL_RPROC_FW_ARGS_MMC \ > + "rd_spec=3D-\0" \ > + "init_mmc=3Drun args_all args_mmc\0" \ > + "get_fdt_mmc=3Dload mmc ${bootpart} ${fdtaddr} ${bootdir}/${name_fdt}\0= " \ > + "get_overlay_mmc=3D" \ > + "fdt address ${fdtaddr};" \ > + "fdt resize 0x100000;" \ > + "for overlay in $name_overlays;" \ > + "do;" \ > + "load mmc ${bootpart} ${dtboaddr} ${bootdir}/${overlay} && " \ > + "fdt apply ${dtboaddr};" \ > + "done;\0" \ > + "partitions=3D" PARTS_DEFAULT \ > + "get_kern_mmc=3Dload mmc ${bootpart} ${loadaddr} " \ > + "${bootdir}/${name_kern}\0" \ > + "get_fit_mmc=3Dload mmc ${bootpart} ${addr_fit} " \ > + "${bootdir}/${name_fit}\0" \ > + "partitions=3D" PARTS_DEFAULT > + > +/* Set the default list of remote processors to boot */ > +#if defined(CONFIG_TARGET_J784S4_A72_EVM) || defined(CONFIG_TARGET_J7200= _A72_EVM) > +#ifdef DEFAULT_RPROCS > +#undef DEFAULT_RPROCS > +#endif > +#endif > + > +#ifdef CONFIG_TARGET_J784S4_A72_EVM > +#define DEFAULT_RPROCS "" \ > + "2 /lib/firmware/j784s4-main-r5f0_0-fw " \ > + "3 /lib/firmware/j784s4-main-r5f0_1-fw " \ > + "4 /lib/firmware/j784s4-main-r5f1_0-fw " \ > + "5 /lib/firmware/j784s4-main-r5f1_1-fw " \ > + "6 /lib/firmware/j784s4-c71_0-fw " \ > + "7 /lib/firmware/j784s4-c71_1-fw " > +#endif /* CONFIG_TARGET_J784S4_A72_EVM */ > + > +#ifdef CONFIG_TARGET_J7200_A72_EVM > +#define EXTRA_ENV_CONFIG_MAIN_CPSW0_QSGMII_PHY \ > + "do_main_cpsw0_qsgmii_phyinit=3D1\0" \ > + "init_main_cpsw0_qsgmii_phy=3Dgpio set gpio@22_17;" \ > + "gpio clear gpio@22_16\0" \ > + "main_cpsw0_qsgmii_phyinit=3D" \ > + "if test ${do_main_cpsw0_qsgmii_phyinit} -eq 1 && test ${dorprocboot} -= eq 1 && " \ > + "test ${boot} =3D mmc; then " \ > + "run init_main_cpsw0_qsgmii_phy;" \ > + "fi;\0" > +#define DEFAULT_RPROCS "" \ > + "2 /lib/firmware/j7200-main-r5f0_0-fw " \ > + "3 /lib/firmware/j7200-main-r5f0_1-fw " > +#endif /* CONFIG_TARGET_J7200_A72_EVM */ > + > +#ifndef EXTRA_ENV_CONFIG_MAIN_CPSW0_QSGMII_PHY > +#define EXTRA_ENV_CONFIG_MAIN_CPSW0_QSGMII_PHY > +#endif > + > +/* set default dfu_bufsiz to 128KB (sector size of OSPI) */ > +#define EXTRA_ENV_DFUARGS \ > + DFU_ALT_INFO_MMC \ > + DFU_ALT_INFO_EMMC \ > + DFU_ALT_INFO_RAM \ > + DFU_ALT_INFO_OSPI > + > +/* Incorporate settings into the U-Boot environment */ > +#define CONFIG_EXTRA_ENV_SETTINGS \ > + DEFAULT_LINUX_BOOT_ENV \ > + DEFAULT_MMC_TI_ARGS \ > + DEFAULT_FIT_TI_ARGS \ > + EXTRA_ENV_J784S4_BOARD_SETTINGS \ > + EXTRA_ENV_J784S4_BOARD_SETTINGS_MMC \ > + EXTRA_ENV_RPROC_SETTINGS \ > + EXTRA_ENV_DFUARGS \ > + DEFAULT_UFS_TI_ARGS \ > + EXTRA_ENV_CONFIG_MAIN_CPSW0_QSGMII_PHY As much of this as possible needs to be moved over to using the text based environment file support instead. --=20 Tom --qjSZefE6w0iW6XmQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmN7oNoACgkQFHw5/5Y0 tyxsFwwArpt0eXyEhyHG/2WnEMajzt8GG3hEarY4xhSPe+a9tNe4ZAkH+5j4kKFM wcImOPFUCTh76xz5m67YmVuRW8vc0MLSBrwiEdfdG70lq8YPeLG0EhAsh74qrct4 boF+xMfLcEWv9H3Z5iWntTTzGkOx83sVaRu4qizrUwoX11G+C9Sgum5DJ2s1MEtB GGIIbmJD55F8iEVGyd1cNoCRzNRsdf0Ifk1ei9c0XAJ8HRJdy1FI+iUto/alejFm c3DXVO09ByiEXGCr0jaFz7RndxDPW4xb51TCbL0RaCZGlGwi9EI5dHuOlpoA578f ZdG6lpZSu8A37B0BDxy09AHtdzhLmCt/wf+b2Rp+MsmGhlPhn8LRs19TIflXrwGv jsUoDNdzFtz8KUtT3Hpcgmo9nUwK/JBiSqJ7Ln/I7HTn48zx7JbGmep5+iUbmUj+ IiuHURRj9a50MqPhj80GFgxa1HMUpI6HmjVwTC+1iUganMZ7wNHfoexv3SYtYm3F dA7gQQXe =myZa -----END PGP SIGNATURE----- --qjSZefE6w0iW6XmQ--