From: Tom Rini <trini@konsulko.com>
To: "Pali Rohár" <pali@kernel.org>
Cc: Troy Kisky <troy.kisky@boundarydevices.com>,
Joe Hershberger <joe.hershberger@ni.com>,
Wolfgang Denk <wd@denx.de>, Simon Glass <sjg@chromium.org>,
u-boot@lists.denx.de
Subject: Re: [PATCH 1/2] Fix usage of CONFIG_PREBOOT
Date: Mon, 21 Nov 2022 12:33:49 -0500 [thread overview]
Message-ID: <20221121173349.GM7282@bill-the-cat> (raw)
In-Reply-To: <20220710114256.27322-1-pali@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1017 bytes --]
On Sun, Jul 10, 2022 at 01:42:55PM +0200, Pali Rohár wrote:
> Due to usage of PREBOOT in Kconfig, macro CONFIG_PREBOOT is always defined
> when CONFIG_USE_PREBOOT is enabled. In case CONFIG_PREBOOT is not
> explicitly enabled it is set to empty C string and therefore
> '#ifdef CONFIG_PREBOOT' guard does not work. Fix this issue by introducing
> a new Kconfig symbol PREBOOT_DEFINED which cause to define new C macro
> CONFIG_PREBOOT_DEFINED only when CONFIG_PREBOOT is really defined.
>
> Change usage of '#ifdef CONFIG_PREBOOT' by '#ifdef CONFIG_USE_PREBOOT' for
> code which checks if preboot code would be called and by
> '#ifdef CONFIG_PREBOOT_DEFINED' for defining preboot code.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
For the record, we need to long term figure out a better solution to
user configurable default environment stuff. Doing this via Kconfig is
fragile / problematic. However, as this patch does solve a real problem,
applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2022-11-21 17:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-10 11:42 [PATCH 1/2] Fix usage of CONFIG_PREBOOT Pali Rohár
2022-07-10 11:42 ` [PATCH 2/2] Nokia RX-51: Remove CONFIG_PREBOOT from defconfig Pali Rohár
2022-07-11 23:23 ` Tom Rini
2022-07-12 8:11 ` Pali Rohár
2022-07-12 21:39 ` Tom Rini
2022-07-12 21:52 ` Pali Rohár
2022-07-12 22:58 ` Tom Rini
2022-07-12 23:11 ` Pali Rohár
2022-07-12 23:15 ` Tom Rini
2022-07-13 8:36 ` Pali Rohár
2022-07-25 21:21 ` Tom Rini
2022-07-27 18:34 ` Pali Rohár
2022-07-27 18:48 ` Tom Rini
2022-07-27 18:52 ` Pali Rohár
2022-07-27 18:58 ` Tom Rini
2022-07-27 19:01 ` Pali Rohár
2022-07-27 19:08 ` Tom Rini
2022-10-09 13:03 ` Pali Rohár
2022-11-01 22:58 ` Pali Rohár
2022-11-01 23:29 ` Tom Rini
2022-11-20 16:37 ` Pali Rohár
2022-07-12 10:58 ` [PATCH 1/2] Fix usage of CONFIG_PREBOOT Simon Glass
2022-07-12 11:18 ` Pali Rohár
2022-11-21 17:33 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221121173349.GM7282@bill-the-cat \
--to=trini@konsulko.com \
--cc=joe.hershberger@ni.com \
--cc=pali@kernel.org \
--cc=sjg@chromium.org \
--cc=troy.kisky@boundarydevices.com \
--cc=u-boot@lists.denx.de \
--cc=wd@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox