* [PATCH] Revert "cli_readline: Only insert printable chars"
@ 2022-11-01 23:40 Pali Rohár
2022-11-02 3:07 ` Simon Glass
2022-11-21 17:34 ` Tom Rini
0 siblings, 2 replies; 4+ messages in thread
From: Pali Rohár @ 2022-11-01 23:40 UTC (permalink / raw)
To: Simon Glass, Steve Bennett; +Cc: u-boot
This reverts commit d2e64d29c44dee6d455f7705dd1cf1af8674ad9a.
This commit broke support for pound sign (£) and euro sign (€) keys on
Nokia N900 keypad.
Signed-off-by: Pali Rohár <pali@kernel.org>
---
common/cli_readline.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/common/cli_readline.c b/common/cli_readline.c
index f6e2bcdeceb2..d6444f5fc1d3 100644
--- a/common/cli_readline.c
+++ b/common/cli_readline.c
@@ -517,10 +517,8 @@ static int cread_line(const char *const prompt, char *buf, unsigned int *len,
}
#endif
default:
- if (ichar >= ' ' && ichar <= '~') {
- cread_add_char(ichar, insert, &num, &eol_num,
- buf, *len);
- }
+ cread_add_char(ichar, insert, &num, &eol_num, buf,
+ *len);
break;
}
}
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Revert "cli_readline: Only insert printable chars"
2022-11-01 23:40 [PATCH] Revert "cli_readline: Only insert printable chars" Pali Rohár
@ 2022-11-02 3:07 ` Simon Glass
2022-11-20 17:12 ` Pali Rohár
2022-11-21 17:34 ` Tom Rini
1 sibling, 1 reply; 4+ messages in thread
From: Simon Glass @ 2022-11-02 3:07 UTC (permalink / raw)
To: Pali Rohár; +Cc: Steve Bennett, u-boot
On Tue, 1 Nov 2022 at 17:42, Pali Rohár <pali@kernel.org> wrote:
>
> This reverts commit d2e64d29c44dee6d455f7705dd1cf1af8674ad9a.
>
> This commit broke support for pound sign (£) and euro sign (€) keys on
> Nokia N900 keypad.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> ---
> common/cli_readline.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Revert "cli_readline: Only insert printable chars"
2022-11-02 3:07 ` Simon Glass
@ 2022-11-20 17:12 ` Pali Rohár
0 siblings, 0 replies; 4+ messages in thread
From: Pali Rohár @ 2022-11-20 17:12 UTC (permalink / raw)
To: Simon Glass; +Cc: Steve Bennett, u-boot
On Tuesday 01 November 2022 21:07:24 Simon Glass wrote:
> On Tue, 1 Nov 2022 at 17:42, Pali Rohár <pali@kernel.org> wrote:
> >
> > This reverts commit d2e64d29c44dee6d455f7705dd1cf1af8674ad9a.
> >
> > This commit broke support for pound sign (£) and euro sign (€) keys on
> > Nokia N900 keypad.
> >
> > Signed-off-by: Pali Rohár <pali@kernel.org>
> > ---
> > common/cli_readline.c | 6 ++----
> > 1 file changed, 2 insertions(+), 4 deletions(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Hello! Any objection? If not, could you take this patch?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Revert "cli_readline: Only insert printable chars"
2022-11-01 23:40 [PATCH] Revert "cli_readline: Only insert printable chars" Pali Rohár
2022-11-02 3:07 ` Simon Glass
@ 2022-11-21 17:34 ` Tom Rini
1 sibling, 0 replies; 4+ messages in thread
From: Tom Rini @ 2022-11-21 17:34 UTC (permalink / raw)
To: Pali Rohár; +Cc: Simon Glass, Steve Bennett, u-boot
[-- Attachment #1: Type: text/plain, Size: 380 bytes --]
On Wed, Nov 02, 2022 at 12:40:46AM +0100, Pali Rohár wrote:
> This reverts commit d2e64d29c44dee6d455f7705dd1cf1af8674ad9a.
>
> This commit broke support for pound sign (£) and euro sign (€) keys on
> Nokia N900 keypad.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-21 17:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-01 23:40 [PATCH] Revert "cli_readline: Only insert printable chars" Pali Rohár
2022-11-02 3:07 ` Simon Glass
2022-11-20 17:12 ` Pali Rohár
2022-11-21 17:34 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox