From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C99C4C433FE for ; Mon, 21 Nov 2022 22:57:13 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 40A2B8544F; Mon, 21 Nov 2022 23:57:10 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="O6WfAQBx"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CFDE683015; Mon, 21 Nov 2022 23:57:07 +0100 (CET) Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DF66B85442 for ; Mon, 21 Nov 2022 23:57:04 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x732.google.com with SMTP id k4so9119355qkj.8 for ; Mon, 21 Nov 2022 14:57:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ZaAUyaLeTrm/GG4gYx8Ww1NN4IDeMyIrkCKdnVgox9g=; b=O6WfAQBxnPhxXOYcHN2gNXKoGWzd5+1eoX9+TZKrZRSKMsGeok77uKAx++XJeSpeVk rMDwQJmYSZjnMugP4e6m6U3hhz8eJrPo1F62Wc2hyasfvCcScHdr5SbaP6qukoy+lMHs 1nVFuGCPSGp3T14mI2Dx/mJL7HqacMFhg7Pzg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZaAUyaLeTrm/GG4gYx8Ww1NN4IDeMyIrkCKdnVgox9g=; b=E0+uz20u91eIMrDyAs3Yk55rODYJmSDBaDteqVPIE/7GBuvGcRBiyiPLy8rAuYQURF vJxCcEXrHGCpswz7mRmTLUuNFFMiUcjKJEIi0lmHWO3YZ3FlkZpAJpWdYRQp4+21dVNO bWO4ZPOUOeza4RvCat2K6N8KngCJh1E8zJugj3eJw4rj/1mINmy32LuJnIMmFFA1ow+k 8Ka1rp04uO/r+tk45qRpr6tTTSqSNKaTK7WBcsOpLzlua9mM3+POSfKBK4jNYqW3UYsY bSAVHaCzBfSgwPzi/Enias4PaCYuBz/R2f4zyh6A1CnDppZNUkWLvwaLkW8LUMdknqSF WhAg== X-Gm-Message-State: ANoB5pmWekbo0EhqqJvbkfP3Og4tWx960sTc873TKJtr/oORiOsvCpOx TuYpMsMq3i+SzDL0EMsB8LGfk0C3/TdQLg== X-Google-Smtp-Source: AA0mqf4MXKusacZNzMJHMnIIvSbL1IPtXkm+aGEqTCvWFWOu+GgjEBHMF+n22z8AwIfB3/GyWV+rvw== X-Received: by 2002:a37:ad0c:0:b0:6fb:9f9b:eb02 with SMTP id f12-20020a37ad0c000000b006fb9f9beb02mr2192271qkm.650.1669071423655; Mon, 21 Nov 2022 14:57:03 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-91a3-6c7b-3405-8039.res6.spectrum.com. [2603:6081:7b00:6400:91a3:6c7b:3405:8039]) by smtp.gmail.com with ESMTPSA id y12-20020a37f60c000000b006e8f8ca8287sm8728280qkj.120.2022.11.21.14.57.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Nov 2022 14:57:03 -0800 (PST) Date: Mon, 21 Nov 2022 17:57:01 -0500 From: Tom Rini To: Simon Glass Cc: u-boot@lists.denx.de Subject: Re: [PATCH 37/38] post: Migrate to Kconfig Message-ID: <20221121225701.GA7282@bill-the-cat> References: <20221119234545.404563-1-trini@konsulko.com> <20221119234545.404563-37-trini@konsulko.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="On39KRpqOYGa2XmA" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --On39KRpqOYGa2XmA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 21, 2022 at 03:51:10PM -0700, Simon Glass wrote: > On Sat, 19 Nov 2022 at 16:53, Tom Rini wrote: > > > > We move the existing CONFIG_POST_* functionality over to CFG_POST and > > then introduce CONFIG_POST to Kconfig. > > > > Signed-off-by: Tom Rini > > --- > > arch/powerpc/cpu/mpc85xx/cpu.c | 2 +- > > configs/P2041RDB_NAND_defconfig | 1 + > > configs/P2041RDB_SDCARD_defconfig | 1 + > > configs/P2041RDB_SPIFLASH_defconfig | 1 + > > configs/P2041RDB_defconfig | 1 + > > configs/kmcent2_defconfig | 1 + > > configs/kmcoge5ne_defconfig | 1 + > > configs/pg_wcom_expu1_defconfig | 1 + > > configs/pg_wcom_expu1_update_defconfig | 1 + > > configs/pg_wcom_seli8_defconfig | 1 + > > configs/pg_wcom_seli8_update_defconfig | 1 + > > doc/README.POST | 6 +- > > doc/README.fsl-ddr | 2 +- > > drivers/serial/serial-uclass.c | 2 +- > > drivers/serial/serial.c | 2 +- > > include/configs/P2041RDB.h | 2 +- > > include/configs/km/pg-wcom-ls102xa.h | 4 +- > > include/configs/kmcent2.h | 2 +- > > include/configs/kmcoge5ne.h | 4 +- > > include/post.h | 4 +- > > include/serial.h | 4 +- > > post/cpu/mpc83xx/ecc.c | 2 +- > > post/drivers/flash.c | 2 +- > > post/drivers/i2c.c | 4 +- > > post/drivers/memory.c | 4 +- > > post/drivers/rtc.c | 4 +- > > post/lib_powerpc/andi.c | 2 +- > > post/lib_powerpc/asm.S | 2 +- > > post/lib_powerpc/b.c | 2 +- > > post/lib_powerpc/cmp.c | 2 +- > > post/lib_powerpc/cmpi.c | 2 +- > > post/lib_powerpc/complex.c | 2 +- > > post/lib_powerpc/cpu.c | 4 +- > > post/lib_powerpc/cr.c | 2 +- > > post/lib_powerpc/fpu/20001122-1.c | 4 +- > > post/lib_powerpc/fpu/20010114-2.c | 4 +- > > post/lib_powerpc/fpu/20010226-1.c | 4 +- > > post/lib_powerpc/fpu/980619-1.c | 4 +- > > post/lib_powerpc/fpu/acc1.c | 4 +- > > post/lib_powerpc/fpu/compare-fp-1.c | 4 +- > > post/lib_powerpc/fpu/fpu.c | 4 +- > > post/lib_powerpc/fpu/mul-subnormal-single-1.c | 4 +- > > post/lib_powerpc/load.c | 2 +- > > post/lib_powerpc/multi.c | 2 +- > > post/lib_powerpc/rlwimi.c | 2 +- > > post/lib_powerpc/rlwinm.c | 2 +- > > post/lib_powerpc/rlwnm.c | 2 +- > > post/lib_powerpc/srawi.c | 2 +- > > post/lib_powerpc/store.c | 2 +- > > post/lib_powerpc/string.c | 2 +- > > post/lib_powerpc/three.c | 2 +- > > post/lib_powerpc/threei.c | 2 +- > > post/lib_powerpc/threex.c | 2 +- > > post/lib_powerpc/two.c | 2 +- > > post/lib_powerpc/twox.c | 2 +- > > post/post.c | 4 +- > > post/tests.c | 68 +++++++++---------- > > test/Kconfig | 5 ++ > > 58 files changed, 114 insertions(+), 99 deletions(-) > > >=20 > Reviewed-by: Simon Glass >=20 > but please see below >=20 > > diff --git a/test/Kconfig b/test/Kconfig > > index a6b463e4d06c..9f4641ae6bc5 100644 > > --- a/test/Kconfig > > +++ b/test/Kconfig > > @@ -1,3 +1,8 @@ > > +config POST > > + bool "Power On Self Test support" > > + help > > + See doc/README.POST for more details >=20 > Shouldn't this be in post/Kconfig ? It's non-trivial enough content that it really should be migrated to doc/post/ and then expanded upon a bit further. > We use test/ for unit / functional tests. Yes, but post pre-dates all of that, keep in mind. It's also still in active use (enabled on some semi-recent layerscape platforms for example). This is an area that could use some attention and renovation, yes, but the whole point of this and the huge follow-up are to get the migrate to Kconfig part done already.=20 --=20 Tom --On39KRpqOYGa2XmA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmN8Aj0ACgkQFHw5/5Y0 tywb+gv9GcZCeYOiBjwnzOsrcQkgSoSOyO1u8u+UOmQX+Yjgz4NdHNa2YqBc6HLO 5XNJOHz2EhZZo0v+ggE4Y2Im4HbjxxuPKSzOJgPGKWPIp55CLDzuK8cnI0nZ94zU 9xhxDe1oUiEzIDjJBZv+b/QB7aTSS0e3mFWd7J7y1ZqO5Vm5KUFf5+qiEddx6FFK bDu8J1Ym5MUF+SY+nVMjyurLaYP4xDo90RwHB4aGfwY5EcgufWshsh7/8rhdTLN3 JTu0vOlX9FH6+mqReRZYDnQJU8HFZzhBGHkJsWcUJTsDbmbEfmugurdDw7ifMlvC FkQ4WHDRdddZPxLeu+lyFUq6bvntgY1c8kZeLjqXdHIyUc8IPczBQNo4062oAi9z 6yQ6XJmeBIdK75S0zs+GdP573ny+43Oc8xYwMsbmfvuPzKUHH1iDiEP37yy4HYqx u1J30lSiH5fUfiHOUsFH3wTHgRPGAJE8RDZ0tYNamJW4Yzi8GHC1EiEQRh6LRisq IZIadL1r =jMT9 -----END PGP SIGNATURE----- --On39KRpqOYGa2XmA--