Re: [PATCH v2 0/8] imx8: switch missing boards to binman

Oliver Graute
2022-11-09T16:15:20Z

On 08/11/22, Fabio Estevam wrote:
> Hi Oliver and Stefano,
>
> On Tue, Nov 8, 2022 at 1:43 PM Stefano Babic <sbabic@denx.de> wrote:
>
> > I have tried to merge the series, but I get build errors, see:
> >
> > https://source.denx.de/u-boot/custodians/u-boot-imx/-/jobs/519510
> >
> > Could you take a look ?
>
> One problem I noticed is the missing CONFIG_TEXT_BASE conversion:
>
> diff --git a/arch/arm/dts/imx8qm-u-boot.dtsi b/arch/arm/dts/imx8qm-u-boot.dtsi
> index 3507489a813c..442e64badc39 100644
> --- a/arch/arm/dts/imx8qm-u-boot.dtsi
> +++ b/arch/arm/dts/imx8qm-u-boot.dtsi
> @@ -50,7 +50,7 @@
> arch = "arm64";
> compression = "none";
> description = "U-Boot (64-bit)";
> - load = <CONFIG_SYS_TEXT_BASE>;
> + load = <CONFIG_TEXT_BASE>;
> type = "standalone";
>
> uboot-blob {
> diff --git a/arch/arm/dts/imx8qxp-u-boot.dtsi b/arch/arm/dts/imx8qxp-u-boot.dtsi
> index 01183f8ade63..e8df5bb8bfea 100644
> --- a/arch/arm/dts/imx8qxp-u-boot.dtsi
> +++ b/arch/arm/dts/imx8qxp-u-boot.dtsi
> @@ -50,7 +50,7 @@
> arch = "arm64";
> compression = "none";
> description = "U-Boot (64-bit)";
> - load = <CONFIG_SYS_TEXT_BASE>;
> + load = <CONFIG_TEXT_BASE>;
> type = "standalone";
>
> uboot-blob {
>
> With this fix applied, I got:
>
> WARNING './ahab-container.img' not found, resulting binary is not-functional
> make[1]: Nothing to be done for 'SPL'.
> BINMAN all
> binman: Error 1 running 'mkimage -d ./mkimage.spl.mkimage -n
> spl/u-boot-spl.cfgout -T imx8image -e 0x100000
> ./mkimage-out.spl.mkimage': Fail open first container file
> ahab-container.img
>
> make: *** [Makefile:1116: all] Error 1
>
>
> but if I manually copy the firmware, then the build succeeds.
>
> binman should not thrown an error in case of missing firmware. Oliver,
> any ideas?
>
> Also, some boards use ahab-container.img and others use
> mx8qxc0-ahab-container.img.

>
> Is it OK to use mx8qxc0-ahab-container.img for all of them?

I'am not sure if that is possible. The seco firmware has explicit
different images for these cpu variants.

imx-seco-3.8.5/firmware/seco

mx8dxla0-ahab-container.img
mx8dxla1-ahab-container.img
mx8qmb0-ahab-container.img
mx8qxb0-ahab-container.img
mx8qxc0-ahab-container.img

Best Regards,

Oliver