* [PATCH] Nokia RX-51: Use ENTRY/ENDPROC for save_boot_params
@ 2022-11-23 23:45 Pali Rohár
2022-12-09 22:54 ` Tom Rini
0 siblings, 1 reply; 2+ messages in thread
From: Pali Rohár @ 2022-11-23 23:45 UTC (permalink / raw)
To: Tom Rini; +Cc: u-boot, maemo-leste
ENTRY/ENDPROC macros from linux/linkage.h will make code more readable and
also will properly mark assembly symbol in ELF binary as function symbol.
Signed-off-by: Pali Rohár <pali@kernel.org>
---
board/nokia/rx51/lowlevel_init.S | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/board/nokia/rx51/lowlevel_init.S b/board/nokia/rx51/lowlevel_init.S
index 930052ea60f2..44f32f114e75 100644
--- a/board/nokia/rx51/lowlevel_init.S
+++ b/board/nokia/rx51/lowlevel_init.S
@@ -5,6 +5,7 @@
*/
#include <config.h>
+#include <linux/linkage.h>
kernoffs: /* offset of kernel image from this address */
.word . - CONFIG_TEXT_BASE - KERNEL_OFFSET
@@ -29,8 +30,7 @@ z_magic: /* LINUX_ARM_ZIMAGE_MAGIC */
* Description: Copy attached kernel to address KERNEL_ADDRESS
*/
-.global save_boot_params
-save_boot_params:
+ENTRY(save_boot_params)
/*
* Copy valid attached kernel to absolute address KERNEL_ADDRESS
@@ -93,3 +93,5 @@ skip_copy:
/* Returns */
b save_boot_params_ret
+
+ENDPROC(save_boot_params)
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Nokia RX-51: Use ENTRY/ENDPROC for save_boot_params
2022-11-23 23:45 [PATCH] Nokia RX-51: Use ENTRY/ENDPROC for save_boot_params Pali Rohár
@ 2022-12-09 22:54 ` Tom Rini
0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2022-12-09 22:54 UTC (permalink / raw)
To: Pali Rohár; +Cc: u-boot, maemo-leste
[-- Attachment #1: Type: text/plain, Size: 316 bytes --]
On Thu, Nov 24, 2022 at 12:45:00AM +0100, Pali Rohár wrote:
> ENTRY/ENDPROC macros from linux/linkage.h will make code more readable and
> also will properly mark assembly symbol in ELF binary as function symbol.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
Applied to u-boot/next, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-09 22:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-23 23:45 [PATCH] Nokia RX-51: Use ENTRY/ENDPROC for save_boot_params Pali Rohár
2022-12-09 22:54 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox