public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: luca.boccassi@gmail.com
To: u-boot@lists.denx.de
Subject: [PATCH] EFI: update the documentation to correctly order loading SB keys
Date: Fri, 25 Nov 2022 13:30:11 +0000	[thread overview]
Message-ID: <20221125133011.1270745-1-luca.boccassi@gmail.com> (raw)

From: Luca Boccassi <bluca@debian.org>

Loading the PK locks down the EFI variables, so it needs to be done last.
Fix the order in the documentation and add a note.

Signed-off-by: Luca Boccassi <bluca@debian.org>
---
 doc/develop/uefi/uefi.rst | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/doc/develop/uefi/uefi.rst b/doc/develop/uefi/uefi.rst
index e0835beba4..68a0bb6832 100644
--- a/doc/develop/uefi/uefi.rst
+++ b/doc/develop/uefi/uefi.rst
@@ -169,12 +169,16 @@ Sign an image with one of the keys in "db" on your host
 
 Now in U-Boot install the keys on your board::
 
-    fatload mmc 0:1 <tmpaddr> PK.auth
-    setenv -e -nv -bs -rt -at -i <tmpaddr>:$filesize PK
-    fatload mmc 0:1 <tmpaddr> KEK.auth
-    setenv -e -nv -bs -rt -at -i <tmpaddr>:$filesize KEK
     fatload mmc 0:1 <tmpaddr> db.auth
     setenv -e -nv -bs -rt -at -i <tmpaddr>:$filesize db
+    fatload mmc 0:1 <tmpaddr> KEK.auth
+    setenv -e -nv -bs -rt -at -i <tmpaddr>:$filesize KEK
+    fatload mmc 0:1 <tmpaddr> PK.auth
+    setenv -e -nv -bs -rt -at -i <tmpaddr>:$filesize PK
+
+Note that loading a key into PK automatically enables Secure Boot, and further
+unsigned updates of secure EFI variables will no longer be allowed, so PK should
+be loaded last.
 
 Set up boot parameters on your board::
 
-- 
2.34.1


             reply	other threads:[~2022-11-25 13:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-25 13:30 luca.boccassi [this message]
2022-11-28  0:45 ` [PATCH] EFI: update the documentation to correctly order loading SB keys AKASHI Takahiro
2022-11-28  1:27   ` Luca Boccassi
2022-11-28  3:04     ` AKASHI Takahiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221125133011.1270745-1-luca.boccassi@gmail.com \
    --to=luca.boccassi@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox