From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14481C4321E for ; Sun, 27 Nov 2022 20:41:32 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2B1F584F28; Sun, 27 Nov 2022 21:41:30 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 0205E84D45; Sun, 27 Nov 2022 21:41:29 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id 8876884F28 for ; Sun, 27 Nov 2022 21:41:26 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2385DD6E; Sun, 27 Nov 2022 12:41:32 -0800 (PST) Received: from slackpad.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D51B33F73D; Sun, 27 Nov 2022 12:41:24 -0800 (PST) Date: Sun, 27 Nov 2022 20:39:44 +0000 From: Andre Przywara To: Tom Rini Cc: u-boot@lists.denx.de, Icenowy Zheng Subject: Re: [PATCH 06/41] sunxi: Move MMC_SUNXI_SLOT to Kconfig Message-ID: <20221127203944.15be1110@slackpad.lan> In-Reply-To: <20221127152536.1556469-6-trini@konsulko.com> References: <20221119234545.404563-38-trini@konsulko.com> <20221127152536.1556469-1-trini@konsulko.com> <20221127152536.1556469-6-trini@konsulko.com> Organization: Arm Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Sun, 27 Nov 2022 10:25:01 -0500 Tom Rini wrote: Hi Tom, > This value is always defined to 0, so move it to Kconfig as being set to > always 0. Yeah, but that's not needed in Kconfig at all, it's just a name for the first MMC slot, its definition being misplaced in the config directory. I will send a patch that removes the CONFIG_ prefix and moves it into the C file using it, so you can drop this patch here. Thanks, Andre > Cc: Andre Przywara > C: Icenowy Zheng > Signed-off-by: Tom Rini > --- > arch/arm/mach-sunxi/Kconfig | 4 ++++ > include/configs/sunxi-common.h | 3 --- > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig > index dbe6005daab1..c311a6d03523 100644 > --- a/arch/arm/mach-sunxi/Kconfig > +++ b/arch/arm/mach-sunxi/Kconfig > @@ -685,6 +685,10 @@ config MMC1_PINS_PH > ---help--- > Select this option for boards where mmc1 uses the Port H pinmux. > > +config MMC_SUNXI_SLOT > + int > + default 0 > + > config MMC_SUNXI_SLOT_EXTRA > int "mmc extra slot number" > default -1 > diff --git a/include/configs/sunxi-common.h b/include/configs/sunxi-common.h > index 1677aafad03b..496139f34635 100644 > --- a/include/configs/sunxi-common.h > +++ b/include/configs/sunxi-common.h > @@ -69,9 +69,6 @@ > #define PHYS_SDRAM_0 CFG_SYS_SDRAM_BASE > #define PHYS_SDRAM_0_SIZE 0x80000000 /* 2 GiB */ > > -/* mmc config */ > -#define CONFIG_MMC_SUNXI_SLOT 0 > - > /* > * Miscellaneous configurable options > */