Re: [PATCH 001/149] exynos: Rework legacy PWM usage

Simon Glass
2022-12-04T21:20:54Z

On Mon, 5 Dec 2022 at 04:06, Tom Rini <trini@konsulko.com> wrote:
>
> The way that the timer support is currently done for exynos/nexell
> platforms relies on the legacy PWM infrastructure, and that needs to be
> updated. However, we really cannot safely undef CONFIG_DM_PWM to build
> the timer.c file without warnings. For now, rename the relevant legacy
> functions to be prefixed with s5p_ and add prototypes to the arch pwm.h
> files.
>
> Cc: Minkyu Kang <mk7.kang@samsung.com>
> Cc: Jaehoon Chung <jh80.chung@samsung.com>
> Cc: Dzmitry Sankouski <dsankouski@gmail.com>
> Cc: Stefan Bosch <stefan_b@posteo.net>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> arch/arm/cpu/armv7/s5p-common/pwm.c | 11 +++++------
> arch/arm/cpu/armv7/s5p-common/timer.c | 10 +++-------
> arch/arm/mach-exynos/include/mach/pwm.h | 5 +++++
> arch/arm/mach-nexell/include/mach/pwm.h | 5 +++++
> arch/arm/mach-s5pc1xx/include/mach/pwm.h | 5 +++++
> board/friendlyarm/nanopi2/board.c | 4 ++--
> board/friendlyarm/nanopi2/onewire.c | 4 ++--
> 7 files changed, 27 insertions(+), 17 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

Can someone update this to use driver model?

- Simon