public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Max Krummenacher <max.oss.09@gmail.com>
To: u-boot@lists.denx.de
Cc: "Adam Ford" <aford173@gmail.com>, "Pali Rohár" <pali@kernel.org>,
	"U-Boot STM32" <uboot-stm32@st-md-mailman.stormreply.com>,
	"Patrick DELAUNAY" <patrick.delaunay@foss.st.com>,
	"Tom Rini" <trini@konsulko.com>,
	"Patrice CHOTARD" <patrice.chotard@foss.st.com>,
	"Max Krummenacher" <max.krummenacher@toradex.com>,
	"AKASHI Takahiro" <takahiro.akashi@linaro.org>,
	"Du Huanpeng" <dhu@hodcarrier.org>,
	"Heiko Thiery" <heiko.thiery@gmail.com>,
	"Heinrich Schuchardt" <xypron.glpk@gmx.de>,
	"Marek Behún" <kabel@kernel.org>,
	"Quentin Schulz" <quentin.schulz@theobroma-systems.com>,
	"Samuel Holland" <samuel@sholland.org>,
	"Simon Glass" <sjg@chromium.org>, "Stefan Roese" <sr@denx.de>
Subject: [PATCH v5 0/1] Makefile: rework u-boot-initial-env target
Date: Mon, 28 Nov 2022 09:41:21 +0100	[thread overview]
Message-ID: <20221128084122.3456680-1-max.oss.09@gmail.com> (raw)

From: Max Krummenacher <max.krummenacher@toradex.com>


With CONFIG_LTO enabled the current way of extracting the
configured environment no longer works, i.e. the object file
content changes due to LTO.

Build a host tool which prints the configured environment instead
of using objcopy and friends to achive the same.

The code and Makefile changes were mostly stolen from tools/env/
i.e. the target userspace tools to access the environment.


Changes in v5:
- don't build the printinitialenv tool unconditionally but build it
  only as part of the u-boot-initial-env target.
  This no longer fails the 'make tools-only_defconfig tools-only'
  use-case which is reported by Tom Rini.
  Adding the $(env_h) dependencies to the tools target might give
  circular dependencies issues with some future tool.
- add Acked-by: Pali Rohár <pali@kernel.org>

Changes in v4:
- add '(objtree)/' when calling the tool. Suggested by Pali Rohár.
- renamed patch, as more than just the Makefile has changes

Changes in v3:
- moved the tool from scripts/ to tools/. Suggested by Tom Rini
- changed the dependencies to '$(env_h)' and 'tools'.
  Suggested by Tom Rini and Pali Rohár.
- removed the sed rule which replaces \x00 with \x0A as this is already
  done by the tool. Suggested by Pali Rohár.

Changes in v2:
- reworked to build a host tool which prints the configured
  environment as proposed by Pali Rohár
  https://lore.kernel.org/u-boot/20221018174827.1393211-1-max.oss.09@gmail.com/
- renamed patch, v1 used "Makefile: fix u-boot-initial-env target if lto is enabled"

Max Krummenacher (1):
  u-boot-initial-env: rework make target

 Makefile                | 10 ++++++----
 tools/.gitignore        |  1 +
 tools/Makefile          |  4 ++++
 tools/printinitialenv.c | 44 +++++++++++++++++++++++++++++++++++++++++
 4 files changed, 55 insertions(+), 4 deletions(-)
 create mode 100644 tools/printinitialenv.c

-- 
2.35.3


             reply	other threads:[~2022-11-28  8:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-28  8:41 Max Krummenacher [this message]
2022-11-28  8:41 ` [PATCH v5 1/1] u-boot-initial-env: rework make target Max Krummenacher
2022-12-04 21:16   ` Simon Glass
2022-12-08 20:24   ` Tom Rini
2022-12-12 13:39     ` Max Krummenacher
2022-12-12 14:00       ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221128084122.3456680-1-max.oss.09@gmail.com \
    --to=max.oss.09@gmail.com \
    --cc=aford173@gmail.com \
    --cc=dhu@hodcarrier.org \
    --cc=heiko.thiery@gmail.com \
    --cc=kabel@kernel.org \
    --cc=max.krummenacher@toradex.com \
    --cc=pali@kernel.org \
    --cc=patrice.chotard@foss.st.com \
    --cc=patrick.delaunay@foss.st.com \
    --cc=quentin.schulz@theobroma-systems.com \
    --cc=samuel@sholland.org \
    --cc=sjg@chromium.org \
    --cc=sr@denx.de \
    --cc=takahiro.akashi@linaro.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=uboot-stm32@st-md-mailman.stormreply.com \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox