From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4129C433FE for ; Mon, 28 Nov 2022 15:35:14 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7F38F8521B; Mon, 28 Nov 2022 16:35:12 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="aKEOgV/Y"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A7BFB85152; Mon, 28 Nov 2022 16:35:10 +0100 (CET) Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 02C5185290 for ; Mon, 28 Nov 2022 16:35:04 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-ed1-x534.google.com with SMTP id r26so13844349edc.10 for ; Mon, 28 Nov 2022 07:35:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=q7/eyRRtkmtcGb4KRaxT2ri7ickKiy41+EEvXstB3ow=; b=aKEOgV/Yk1iTUlzvMcvbh0bNBaCmUWf1S0JXt+8JndzpRL5iIukttxMem0hOlsq0N1 QUuY+6q/ohzdXz3wpqiTW5uh9Y/Nd9s4dM/E66YlZvEXUzsTEpecwcxiWBK2JVzpoe2u J2aixAuz51deyMUN6Ypz5sJUibVoeaH7/Ru0s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=q7/eyRRtkmtcGb4KRaxT2ri7ickKiy41+EEvXstB3ow=; b=w8h67M7yzf4mlxo9RjK/I5WhpuZKUJvJiCM9X4O3Dw3LxH8lTWc3ftHgwpa2RvK/mg I78Gkt4AUeDx5CWKgJZamHhb+xb4UplfUTbmeqnUmStFBAwg7WhFp0OjiViv8RlcJaeq pAEPcP4N97T39qjjT6OxwVPyPnBLXoBQZuAEWnyrUAZYwuaPeooRJVTTCdrB36BRfK6P 5A2XYfcL8hRI2zcElR8SGUkmwOn2ZaO8aPurdvv2XOWKuPNZNI9YbzzwQpvroN8xZV/F DlXMg/ua6ryTckkPUpJqOwF4lRhqENUnmnUCcb3nd8KDRgvq2cedDD8aLAWdT+CLh/yc MzTQ== X-Gm-Message-State: ANoB5pmvRf+mnfHv7Z8F+aaCTMQzKFefw+YM02AD0Osl0nMHSjwwJplP q2dxzf9J1GikWixmbf8aO0HV4Q== X-Google-Smtp-Source: AA0mqf5pvoiJYknNRQakNUyJAEE0xTiTALQlsPzo3XBUXJwMfLx6Ff/oRYt6BHV6TL17exZqUnA8Pg== X-Received: by 2002:a05:6402:606:b0:46b:2f7f:6fe4 with SMTP id n6-20020a056402060600b0046b2f7f6fe4mr5233506edv.189.1669649702218; Mon, 28 Nov 2022 07:35:02 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-69da-bdfc-6a2b-e036.res6.spectrum.com. [2603:6081:7b00:6400:69da:bdfc:6a2b:e036]) by smtp.gmail.com with ESMTPSA id hb14-20020a170906b88e00b007c0688a68cbsm1039775ejb.176.2022.11.28.07.35.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Nov 2022 07:35:01 -0800 (PST) Date: Mon, 28 Nov 2022 10:34:58 -0500 From: Tom Rini To: Viacheslav Mitrofanov Cc: rfried.dev@gmail.com, joe.hershberger@ni.com, wd@denx.de, u-boot@lists.denx.de, judge.packham@gmail.com, linux@yadro.com, sjg@chromium.org Subject: Re: [PATCH v4 00/17] IPv6 support Message-ID: <20221128153458.GT3787616@bill-the-cat> References: <20220908115905.70928-1-v.v.mitrofanov@yadro.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cjNiBkmi8s9yAE0W" Content-Disposition: inline In-Reply-To: <20220908115905.70928-1-v.v.mitrofanov@yadro.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --cjNiBkmi8s9yAE0W Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 08, 2022 at 02:58:48PM +0300, Viacheslav Mitrofanov wrote: > This patch set adds basic IPv6 support to U-boot. > It is based on Chris's Packham patches > (https://lists.denx.de/pipermail/u-boot/2017-January/279366.html) > Chris's patches were taken as base. There were efforts to launch it on > HiFive SiFive Unmatched board but the board didn't work well. The code was > refactored, fixed some bugs as CRC for little-endian, some parts were imp= lemented in > our own way, something was taken from Linux. Finally we did manual tests = and the > board worked well. >=20 > Testing was done on HiFive SiFive Unmatched board (RISC-V) >=20 > Signed-off-by: Viacheslav Mitrofanov > --- > Changes in v2: > - Split big patches into smaller > - If an address in tftpboot is IPv6 than use IPv6 to boot > - Add tests >=20 > Changes in v3: > - Added functions and structures description in whole patch-series > - Removed memory allocation in on_ip6addr() > - Some functions got return code from errno.h > - Add to string_to_ip6() length parameter to avoid obligatory null termi= nation > - Add a lot of small decorative cnages >=20 > Changes in v4: > - Fixed funcs and structures style description > - Added omitted tags=20 Testing this locally in sandbox I see: FAILED test/py/tests/test_ut.py::test_ut[ut_dm_dm_test_csum_ipv6_magic] - A= ssertionError: as... FAILED test/py/tests/test_ut.py::test_ut[ut_dm_dm_test_ip6_addr_in_subnet] = - AssertionError:... FAILED test/py/tests/test_ut.py::test_ut[ut_dm_dm_test_ip6_make_lladdr] - a= ssert False FAILED test/py/tests/test_ut.py::test_ut[ut_dm_dm_test_ip6_make_snma] - ass= ert False FAILED test/py/tests/test_ut.py::test_ut[ut_dm_dm_test_string_to_ip6] - Ass= ertionError: asse... and this happens in CI as well: https://source.denx.de/u-boot/u-boot/-/pipelines/14245 https://dev.azure.com/u-boot/u-boot/_build/results?buildId=3D5432&view=3Dre= sults If you can't replicate the failures locally you should be able to trigger CI: https://u-boot.readthedocs.io/en/latest/develop/ci_testing.html Thanks for pushing this along! --=20 Tom --cjNiBkmi8s9yAE0W Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmOE1SIACgkQFHw5/5Y0 tyykIAv/TXCXfpZ8msWmo3crTWo5XwrrQsZ4mL6rMQiji6ZlGniLiTg9QQLuKFbk 5stO1sIzECCfKNdcZ+s9yykwXygVW91v6oY+JM5SxG0ftn7FA+BIbsilhgJJwGfH jtXAlC+xW3pHky+f2ljxdg+DA5B1jfQ1e8JQsKrHbGw511NS0m4/wuNWxg1OxAgs xbin7u6voMtRq7CS7rPZQBktsSpT5kooER3xW+gJhfAJCQd1iCuPnp7XsdrFMas6 v3MIPJp2NUkakC3TK4BK1bdDfktkSwVtUZYDQpOiRZFnlG7QTp2GKXepMa4Vq+FN JwkZ4GpEjY/7JWh/iPEoS0A6JUuozGAHV5PDcA9plKj72F8+f2zuG46Bnru6NJ9B baeyU3u/haahk5tPFsAlr914p2QT6ESYvdX38Lb9XOoppJ94nh7xZ3LO5DHESnVb yIbmaXlo96Z28fzCZT51/li+wbrIQQjf7usjkIBHI8hzR0R/uWeGj2ZdSYhWAkWx J9ewnISx =AiEq -----END PGP SIGNATURE----- --cjNiBkmi8s9yAE0W--