From: Tom Rini <trini@konsulko.com>
To: Marek Vasut <marex@denx.de>
Cc: u-boot@lists.denx.de, Joe Hershberger <joe.hershberger@ni.com>,
Patrice Chotard <patrice.chotard@foss.st.com>,
Patrick Delaunay <patrick.delaunay@foss.st.com>,
Ramon Fried <rfried.dev@gmail.com>,
Stephen Warren <swarren@nvidia.com>
Subject: Re: [PATCH 2/2] net: dwc_eth_qos: Add support for bulk RX descriptor cleaning
Date: Mon, 28 Nov 2022 14:50:58 -0500 [thread overview]
Message-ID: <20221128195058.GA3787616@bill-the-cat> (raw)
In-Reply-To: <20221009155146.18697-2-marex@denx.de>
[-- Attachment #1: Type: text/plain, Size: 1064 bytes --]
On Sun, Oct 09, 2022 at 05:51:46PM +0200, Marek Vasut wrote:
> Add new desc_per_cacheline property which lets a platform run RX descriptor
> cleanup after every power-of-2 - 1 received packets instead of every packet.
> This is useful on platforms where (axi_bus_width EQOS_AXI_WIDTH_n * DMA DSL
> inter-descriptor word skip count + DMA descriptor size) is less than cache
> line size, which necessitates packing multiple DMA descriptors into single
> cache line.
>
> In case of TX descriptors, this is not a problem, since the driver always
> does synchronous TX, i.e. the TX descriptor is always written, flushed and
> polled for completion in eqos_send().
>
> In case of RX descriptors, it is necessary to update their status in bulk,
> i.e. after the entire cache line worth of RX descriptors has been used up
> to receive data.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
> Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2022-11-28 19:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-09 15:51 [PATCH 1/2] net: dwc_eth_qos: Split TX and RX DMA rings Marek Vasut
2022-10-09 15:51 ` [PATCH 2/2] net: dwc_eth_qos: Add support for bulk RX descriptor cleaning Marek Vasut
2022-10-10 7:07 ` Patrice CHOTARD
2022-10-16 18:16 ` Ramon Fried
2022-11-28 19:50 ` Tom Rini [this message]
2022-10-10 6:37 ` [PATCH 1/2] net: dwc_eth_qos: Split TX and RX DMA rings Patrice CHOTARD
2022-10-16 18:15 ` Ramon Fried
2022-11-28 19:50 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221128195058.GA3787616@bill-the-cat \
--to=trini@konsulko.com \
--cc=joe.hershberger@ni.com \
--cc=marex@denx.de \
--cc=patrice.chotard@foss.st.com \
--cc=patrick.delaunay@foss.st.com \
--cc=rfried.dev@gmail.com \
--cc=swarren@nvidia.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox