* [PATCH 0/1] common:autoboot:modify function parameters
@ 2022-12-02 4:53 Shenlin Liang
2022-12-02 4:53 ` [PATCH 1/1] " Shenlin Liang
0 siblings, 1 reply; 4+ messages in thread
From: Shenlin Liang @ 2022-12-02 4:53 UTC (permalink / raw)
To: u-boot; +Cc: zhuwenjun, zhangdongdong, zhengyu, jinyanjiang, Shenlin Liang
In the autoboot.c file under uboot/common/, the blob parameter of the
function process_fdt_options has not been invoked in the function body
and should be changed to void type
Shenlin Liang (1):
common:autoboot:modify function parameters
common/autoboot.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
2.31.1.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/1] common:autoboot:modify function parameters
2022-12-02 4:53 [PATCH 0/1] common:autoboot:modify function parameters Shenlin Liang
@ 2022-12-02 4:53 ` Shenlin Liang
2022-12-04 21:17 ` Simon Glass
2023-01-12 15:17 ` Tom Rini
0 siblings, 2 replies; 4+ messages in thread
From: Shenlin Liang @ 2022-12-02 4:53 UTC (permalink / raw)
To: u-boot; +Cc: zhuwenjun, zhangdongdong, zhengyu, jinyanjiang, Shenlin Liang
the blob parameter of the function process_fdt_options has not been
invoked in the function body and should be changed to void type
Signed-off-by: Shenlin Liang <liangshenlin@eswincomputing.com>
---
common/autoboot.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/common/autoboot.c b/common/autoboot.c
index ea44fdf6ad..848c33b2f2 100644
--- a/common/autoboot.c
+++ b/common/autoboot.c
@@ -422,7 +422,7 @@ static int abortboot(int bootdelay)
return abort;
}
-static void process_fdt_options(const void *blob)
+static void process_fdt_options(void)
{
#ifdef CONFIG_TEXT_BASE
ulong addr;
@@ -474,7 +474,7 @@ const char *bootdelay_process(void)
s = env_get("bootcmd");
if (IS_ENABLED(CONFIG_OF_CONTROL))
- process_fdt_options(gd->fdt_blob);
+ process_fdt_options();
stored_bootdelay = bootdelay;
return s;
--
2.31.1.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] common:autoboot:modify function parameters
2022-12-02 4:53 ` [PATCH 1/1] " Shenlin Liang
@ 2022-12-04 21:17 ` Simon Glass
2023-01-12 15:17 ` Tom Rini
1 sibling, 0 replies; 4+ messages in thread
From: Simon Glass @ 2022-12-04 21:17 UTC (permalink / raw)
To: Shenlin Liang; +Cc: u-boot, zhuwenjun, zhangdongdong, zhengyu, jinyanjiang
On Sat, 3 Dec 2022 at 01:25, Shenlin Liang
<liangshenlin@eswincomputing.com> wrote:
>
> the blob parameter of the function process_fdt_options has not been
> invoked in the function body and should be changed to void type
>
> Signed-off-by: Shenlin Liang <liangshenlin@eswincomputing.com>
> ---
> common/autoboot.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] common:autoboot:modify function parameters
2022-12-02 4:53 ` [PATCH 1/1] " Shenlin Liang
2022-12-04 21:17 ` Simon Glass
@ 2023-01-12 15:17 ` Tom Rini
1 sibling, 0 replies; 4+ messages in thread
From: Tom Rini @ 2023-01-12 15:17 UTC (permalink / raw)
To: Shenlin Liang; +Cc: u-boot, zhuwenjun, zhangdongdong, zhengyu, jinyanjiang
[-- Attachment #1: Type: text/plain, Size: 370 bytes --]
On Fri, Dec 02, 2022 at 12:53:48PM +0800, Shenlin Liang wrote:
> the blob parameter of the function process_fdt_options has not been
> invoked in the function body and should be changed to void type
>
> Signed-off-by: Shenlin Liang <liangshenlin@eswincomputing.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-12 15:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-02 4:53 [PATCH 0/1] common:autoboot:modify function parameters Shenlin Liang
2022-12-02 4:53 ` [PATCH 1/1] " Shenlin Liang
2022-12-04 21:17 ` Simon Glass
2023-01-12 15:17 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox