From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5CADBC4332F for ; Fri, 2 Dec 2022 20:08:57 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 06E8584EC2; Fri, 2 Dec 2022 21:08:55 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="PrOO2fbN"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 200C384EF6; Fri, 2 Dec 2022 21:08:53 +0100 (CET) Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C1A0A84B26 for ; Fri, 2 Dec 2022 21:08:49 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-ej1-x632.google.com with SMTP id ud5so13978667ejc.4 for ; Fri, 02 Dec 2022 12:08:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=irHrphztTWbr0LkBSXfCmptO8XcJDBZeRYrXqpu+OM8=; b=PrOO2fbN1oLZiRHTkktDclWMzMnwPmWvY9EbpqBg4RNjRZXJ9OQkEr8/KExXxEXK5g 01/BNvHbIDJsTFrIBfv+WPUm40yZ/ztFYZLR3yeVwTz7dFMQCQjg/n9UNpoOWGy3O4AE hwzePqhg2UHzq7nhUthDyu4dldndKOFSwzcIE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=irHrphztTWbr0LkBSXfCmptO8XcJDBZeRYrXqpu+OM8=; b=htToA6TIjuwpGr/fZGBNynpkohNVI3NxLDjlwjBWgO2dvrsyiGhfpPNE8ApPq4C+x6 cDwKwx62TWefHrBPxtNYqaPYFe9iDcIl9y/shBqqvaCyq5+Z0yzI2TH4LKJ7D98bATAM crnOOG0REV+1RBYEnkmpYaoY6bJ7HOLYJCkJcDmazfMEwZy+yqdqYScyHCiXm0xJHjod YAIwqa3tg+f4zNewcdaQNL4DzktOwKJHskTQat2cSBS4XroKM/D+1WwIr4Jw5B3tfnwk H/PdXEDUlAx77TKbYckNY3jBJIu+nTQohYpFV1FKrEh4Ebb8il6KbI7eTJpnT/ZTlqWG npdg== X-Gm-Message-State: ANoB5pk+xP4GoN8YuQEIPFrlI8vG0bJ3/nmN/p+pU4FULZ+u3qd+/Zs4 V40ZtfUgChK6gIfUkMTlBn+mJQ== X-Google-Smtp-Source: AA0mqf6IOOu6pl9QU3+D6Uh1RbxXDSSLmA9X1tJxwz6uaAebHFrb7rAqGnBNA1UW5Ac/EfhWfyaEtA== X-Received: by 2002:a17:906:d0da:b0:7ad:9891:8756 with SMTP id bq26-20020a170906d0da00b007ad98918756mr62220536ejb.203.1670011729284; Fri, 02 Dec 2022 12:08:49 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-f99b-6f1a-2cc1-7368.res6.spectrum.com. [2603:6081:7b00:6400:f99b:6f1a:2cc1:7368]) by smtp.gmail.com with ESMTPSA id ha7-20020a170906a88700b007c0bb571da5sm1647640ejb.41.2022.12.02.12.08.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Dec 2022 12:08:48 -0800 (PST) Date: Fri, 2 Dec 2022 15:08:45 -0500 From: Tom Rini To: Detlev Casanova Cc: u-boot@lists.denx.de, Stefano Babic , Fabio Estevam , "NXP i . MX U-Boot Team" Subject: Re: [PATCH] dts: Re-add aliases for imx6qdl-sabrelite devices Message-ID: <20221202200845.GL3787616@bill-the-cat> References: <20221027152252.46552-1-detlev.casanova@collabora.com> <13125638.O9o76ZdvQC@falcon9> <20221111153556.GF7282@bill-the-cat> <5883089.lOV4Wx5bFT@falcon9> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ZATCr4BkWovzAAkA" Content-Disposition: inline In-Reply-To: <5883089.lOV4Wx5bFT@falcon9> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --ZATCr4BkWovzAAkA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 02, 2022 at 02:06:26PM -0500, Detlev Casanova wrote: > On Friday, November 11, 2022 10:35:56 A.M. EST Tom Rini wrote: > > On Fri, Nov 11, 2022 at 10:28:43AM -0500, Detlev Casanova wrote: > > > On Thursday, October 27, 2022 2:30:51 P.M. EST Tom Rini wrote: > > > > On Thu, Oct 27, 2022 at 11:22:52AM -0400, Detlev Casanova wrote: > > > > > In commit d0399a46e7cda63c07e3eb8558bef84cfb068028, the device tr= ee > > > > > was > > > > > synchronized from linux and the aliases were dropped. > > > > >=20 > > > > > They need to be kept so that the mmc cards are in the right order. > > > > > Without the aliases, u-boot reports: > > > > > MMC: FSL_SDHC: 2, FSL_SDHC: 3 > > > > >=20 > > > > > With the aliases, u-boot reports: > > > > > MMC: FSL_SDHC: 0, FSL_SDHC: 1 > > > > >=20 > > > > > Signed-off-by: Detlev Casanova > > > > > --- > > > > >=20 > > > > > arch/arm/dts/imx6qdl-sabrelite.dtsi | 7 +++++++ > > > > > 1 file changed, 7 insertions(+) > > > > >=20 > > > > > diff --git a/arch/arm/dts/imx6qdl-sabrelite.dtsi > > > > > b/arch/arm/dts/imx6qdl-sabrelite.dtsi index 22f8e2783c..6564e3b82c > > > > > 100644 > > > > > --- a/arch/arm/dts/imx6qdl-sabrelite.dtsi > > > > > +++ b/arch/arm/dts/imx6qdl-sabrelite.dtsi > > > > > @@ -10,6 +10,13 @@ > > > > >=20 > > > > > #include > > > > > =20 > > > > > / { > > > > >=20 > > > > > + aliases { > > > > > + mmc0 =3D &usdhc3; > > > > > + mmc1 =3D &usdhc4; > > > > > + pwm_lcd =3D &pwm1; > > > > > + pwm_lvds =3D &pwm4; > > > > > + }; > > > > > + > > > > >=20 > > > > > chosen { > > > > > =09 > > > > > stdout-path =3D &uart2; > > > > > =09 > > > > > }; > > > >=20 > > > > This really belongs in the upstream dts file so they aren't lost ag= ain > > > > and again. > > >=20 > > > Forwaded to upstream kernel: > > > https://lore.kernel.org/lkml/20221028141811.101122-1-detlev.casanova@= coll > > > abora.com/[1] > > >=20 > > > Would it make sense to still add this one in u-boot before the devices > > > trees are copied again ? > > Yes, it would make sense to pick it up now to fix the regression here. > > Thanks for pushing it upstream! >=20 > Upstream linux won't apply it as they want to keep the already establishe= d order in linux (the=20 > SD card has to stay at mmc2). See https://lore.kernel.org/all/a13c2e92-cf= a6-04fd-c32a-c4d444894660@pengutronix.de/[1] >=20 > I guess we will have to adapt u-boot environment when these dts are synce= d again. >=20 > Detlev. >=20 >=20 > -------- > [1] https://lore.kernel.org/all/a13c2e92-cfa6-04fd-c32a-c4d444894660@peng= utronix.de/ Not being overly familiar with the board in question in production (it was quite a long back when I last was involved in a design based on one of these), I don't know which order got more widespread real life usage, so, OK, we'll defer to what upstream kernel has now as indeed following the data sheet for order is reasonable. Whatever migrations need to be done to match this should be started on sooner rather than later I would suggest. --=20 Tom --ZATCr4BkWovzAAkA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmOKW0kACgkQFHw5/5Y0 tyz5Agv/bzZ5h38S2TYJWWppcK4WhLix4IpezvZr3kgTk34eul9ngfLCaQ0FQuc9 w16zQO0pUrwZ/OmdFPtaR7uVQ1uDTIXlMBIQtZNSd9g8GxUYzTQQzNkjQ6fQAnR1 zVVU8BK6QijtfbAyjXjNMKzThqQ5b3VyTySP3N7XYCT0IErF59RIHIgUAJh/DGSv XOzig1e/FJXUFC2ibtm7gZxCF6A3PpFd1DSqV64wc52kb+BjtdTdsRxb5nfOCdT8 DhytoXDRwXSMG6vL4G3aiVgG2fwvNpxWEnMahJxnnStqFDgkzm9p2P4en67WzIUL pP4WGOoTFTpA8ITLUF629QYu4urUziZ53hYWIKegPMfXl55YWeoxvXtsNzGXFLIF LyeWQqKYIWuKVBGQBU2bGclcNZbagr2DnwU2VBr0uxKKBtVRxi0ovQ+d+oPZcHUA zd4yIb38ha5odQxyzh2Pd92oXpBAZ/XEAg748RVjXJYqBTlIwaqq+dpBMrzcNHqD VmHcMDW1 =Q+eo -----END PGP SIGNATURE----- --ZATCr4BkWovzAAkA--