public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: jassisinghbrar@gmail.com
To: u-boot@lists.denx.de
Cc: ilias.apalodimas@linaro.org, sughosh.ganu@linaro.org,
	etienne.carriere@linaro.org, trini@konsulko.com,
	sjg@chromium.org, xypron.glpk@gmx.de,
	patrick.delaunay@foss.st.com, patrice.chotard@foss.st.com,
	Jassi Brar <jaswinder.singh@linaro.org>
Subject: [PATCHv2 3/4] fwu: gpt: implement read_mdata and write_mdata callbacks
Date: Fri,  2 Dec 2022 21:17:12 -0600	[thread overview]
Message-ID: <20221203031712.579809-1-jassisinghbrar@gmail.com> (raw)
In-Reply-To: <20221203031557.579632-1-jassisinghbrar@gmail.com>

From: Jassi Brar <jaswinder.singh@linaro.org>

Moving towards using common code for meta-data management,
implement the read/write mdata hooks.

Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
---
 drivers/fwu-mdata/gpt_blk.c | 40 +++++++++++++++++++++++++++++++++++--
 1 file changed, 38 insertions(+), 2 deletions(-)

diff --git a/drivers/fwu-mdata/gpt_blk.c b/drivers/fwu-mdata/gpt_blk.c
index 28f5d23e1e..35239c0a4f 100644
--- a/drivers/fwu-mdata/gpt_blk.c
+++ b/drivers/fwu-mdata/gpt_blk.c
@@ -222,7 +222,7 @@ static int fwu_gpt_read_mdata_partition(struct udevice *dev,
 	struct fwu_mdata_gpt_blk_priv *priv = dev_get_priv(dev);
 
 	return gpt_read_write_mdata(dev_get_uclass_plat(priv->blk_dev),
-				    mdata, MDATA_READ, part_num);
+                                mdata, MDATA_READ, part_num);
 }
 
 static int fwu_gpt_write_mdata_partition(struct udevice *dev,
@@ -231,7 +231,7 @@ static int fwu_gpt_write_mdata_partition(struct udevice *dev,
 	struct fwu_mdata_gpt_blk_priv *priv = dev_get_priv(dev);
 
 	return gpt_read_write_mdata(dev_get_uclass_plat(priv->blk_dev),
-				    mdata, MDATA_WRITE, part_num);
+                                mdata, MDATA_WRITE, part_num);
 }
 
 static int fwu_get_mdata_device(struct udevice *dev, struct udevice **mdata_dev)
@@ -272,7 +272,43 @@ static int fwu_mdata_gpt_blk_probe(struct udevice *dev)
 	return 0;
 }
 
+static int fwu_gpt_read_mdata(struct udevice *dev, struct fwu_mdata *mdata,
+						 bool primary)
+{
+	struct fwu_mdata_gpt_blk_priv *priv = dev_get_priv(dev);
+	struct blk_desc *desc = dev_get_uclass_plat(priv->blk_dev);
+	int ret;
+
+	ret = gpt_get_mdata_partitions(desc);
+	if (ret < 0) {
+		log_debug("Error getting the FWU metadata partitions\n");
+		return -ENOENT;
+	}
+
+	return gpt_read_write_mdata(desc, mdata, MDATA_READ,
+                                primary ? g_mdata_part[0] : g_mdata_part[1]);
+}
+
+static int fwu_gpt_write_mdata(struct udevice *dev, struct fwu_mdata *mdata,
+						 bool primary)
+{
+	struct fwu_mdata_gpt_blk_priv *priv = dev_get_priv(dev);
+	struct blk_desc *desc = dev_get_uclass_plat(priv->blk_dev);
+	int ret;
+
+	ret = gpt_get_mdata_partitions(desc);
+	if (ret < 0) {
+		log_debug("Error getting the FWU metadata partitions\n");
+		return -ENOENT;
+	}
+
+	return gpt_read_write_mdata(desc, mdata, MDATA_WRITE,
+                                primary ? g_mdata_part[0] : g_mdata_part[1]);
+}
+
 static const struct fwu_mdata_ops fwu_gpt_blk_ops = {
+	.read_mdata = fwu_gpt_read_mdata,
+	.write_mdata = fwu_gpt_write_mdata,
 	.get_mdata = fwu_gpt_get_mdata,
 	.update_mdata = fwu_gpt_update_mdata,
 	.get_mdata_part_num = fwu_gpt_get_mdata_partitions,
-- 
2.34.1


  parent reply	other threads:[~2022-12-03  3:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-03  3:15 [PATCHv2 0/4] FWU: Handle meta-data in common code jassisinghbrar
2022-12-03  3:16 ` [PATCHv2 1/4] fwu: gpt: use cached meta-data partition numbers jassisinghbrar
2022-12-22 12:45   ` Ilias Apalodimas
2023-01-02 17:15     ` Jassi Brar
2023-01-04 11:45       ` Etienne Carriere
2022-12-03  3:17 ` [PATCHv2 2/4] fwu: move meta-data management in core jassisinghbrar
2022-12-13 14:59   ` Etienne Carriere
2023-01-02 16:05     ` Jassi Brar
2022-12-03  3:17 ` jassisinghbrar [this message]
2022-12-22 12:59   ` [PATCHv2 3/4] fwu: gpt: implement read_mdata and write_mdata callbacks Ilias Apalodimas
2023-01-02  9:48     ` Etienne Carriere
2023-01-02 16:04       ` Jassi Brar
2022-12-03  3:17 ` [PATCHv2 4/4] fwu: meta-data: switch to management by common code jassisinghbrar
2023-01-02  9:48   ` Etienne Carriere
2022-12-03  3:28 ` [PATCHv2 5/4] fwu: rename fwu_get_verified_mdata to fwu_get_mdata jassisinghbrar
2022-12-22 13:00   ` Ilias Apalodimas
2023-01-02  9:48   ` Etienne Carriere

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221203031712.579809-1-jassisinghbrar@gmail.com \
    --to=jassisinghbrar@gmail.com \
    --cc=etienne.carriere@linaro.org \
    --cc=ilias.apalodimas@linaro.org \
    --cc=jaswinder.singh@linaro.org \
    --cc=patrice.chotard@foss.st.com \
    --cc=patrick.delaunay@foss.st.com \
    --cc=sjg@chromium.org \
    --cc=sughosh.ganu@linaro.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox