From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 311AAC4332F for ; Mon, 5 Dec 2022 15:37:14 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 97216854A5; Mon, 5 Dec 2022 16:37:11 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="YDVX6Wj4"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 62414854A5; Mon, 5 Dec 2022 16:37:09 +0100 (CET) Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7F9BB854A5 for ; Mon, 5 Dec 2022 16:37:06 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-ed1-x52e.google.com with SMTP id c17so7754994edj.13 for ; Mon, 05 Dec 2022 07:37:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ZsSsWqvyrTbYELzHP3QyI5OJkQeHAJpW3D4WDla+Cjc=; b=YDVX6Wj4pA+5FjQI52QRvD4y+uGYngLIK6HgOZtDnz4ReqlgShcH3lYOUMqf7PYEMd +ZdaWU/hh41op2eKChHd9LoO/dDgRMRkAO6zVACE0v0hTslqaQ0klC2+hf/Qjp6wEfER 4ZTaG7SgW5K+hqEdSVndqkTIzCv8iq2c3vpZ8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZsSsWqvyrTbYELzHP3QyI5OJkQeHAJpW3D4WDla+Cjc=; b=rs1mFaLoKgpF2a9dqKMp/3Ge7KtoaJmFBqxNiKcepclJJu/pi3kORJpBnGb4thLrqY qypq9IrdduFa/WwCKe2Vv1CL/Cu81BLUS7+p6K4qCmDSfMJcTDJeg/vO7zQ6mTjVrbys jPMYPpaJr0j0ZcDGxm6rODpZsGRUwOJqIjyvTSEWt5ix/p3eyaZzK+a1zBLM6dwqoohg rEJLwPQQRLQGAzhLvjzOoRSv7o6OcSQK70sKQiUIM7YUZu1HOpin3+udk1zIrSnLDm4d Vr2En1Zq5shz/QMfZSWY2Va6dRNg1ODi4oiLX5PE5Q4a0iQ/eZhFRG9AfxZVTP8s3ZVh Yveg== X-Gm-Message-State: ANoB5pktQv1rSLuLo7zwGVkQaXgoiGbfjs4lrqz8Si32gu2KjVhoQCl4 qWDcbo5cZJiFqb0MWeQcjw7lZQ== X-Google-Smtp-Source: AA0mqf5sXc3XiP8+FOArnjO2jq+4NYGpTu+FrX2qShhNUfhMk2+t4j6/r1og3aMtl9o2hMituwhr8Q== X-Received: by 2002:aa7:d85a:0:b0:46b:81a8:1ff6 with SMTP id f26-20020aa7d85a000000b0046b81a81ff6mr25758193eds.174.1670254625996; Mon, 05 Dec 2022 07:37:05 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-3974-0ce5-e869-8ac0.res6.spectrum.com. [2603:6081:7b00:6400:3974:ce5:e869:8ac0]) by smtp.gmail.com with ESMTPSA id s3-20020a170906284300b007ba9c181202sm6391642ejc.56.2022.12.05.07.37.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Dec 2022 07:37:05 -0800 (PST) Date: Mon, 5 Dec 2022 10:37:01 -0500 From: Tom Rini To: Fabio Estevam Cc: Detlev Casanova , Troy Kisky , u-boot@lists.denx.de, Stefano Babic , "NXP i . MX U-Boot Team" Subject: Re: [PATCH] dts: Re-add aliases for imx6qdl-sabrelite devices Message-ID: <20221205153701.GR3787616@bill-the-cat> References: <20221027152252.46552-1-detlev.casanova@collabora.com> <13125638.O9o76ZdvQC@falcon9> <20221111153556.GF7282@bill-the-cat> <5883089.lOV4Wx5bFT@falcon9> <20221202233638.GM3787616@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ikCwydJVc3YoFZrT" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --ikCwydJVc3YoFZrT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Dec 03, 2022 at 09:23:10AM -0300, Fabio Estevam wrote: > On Fri, Dec 2, 2022 at 8:36 PM Tom Rini wrote: >=20 > > No, upstream has different aliases and doesn't want these. That's the > > point of the above thread, right? >=20 > Upstream is correct in not accepting new alias for this board, as this > could break > existing setups. >=20 > In U-Boot, we had alias for this board originally. After the sync with > Linux they are gone. >=20 > To fix U-Boot, the less invasive change is to add the alias into > arch/arm/dts/imx6qdl-sabrelite-u-boot.dtsi. >=20 > This way we can: >=20 > 1. Keep the dtsi in sync with Linux >=20 > 2. Do not break users in U-Boot >=20 > This is the same approach I did for wandboard in the following commit: >=20 > commit f827f84d3f5607d0b33e927f6127a888e7bd664f > Author: Fabio Estevam > Date: Fri Nov 4 08:12:54 2022 -0300 >=20 > wandboard: Pass mmc aliases >=20 > Originally, the mmc aliases node was present in imx6qdl-wandboard.dts= i. >=20 > After the sync with Linux in commit d0399a46e7cd ("imx6dl/imx6qdl: > synchronise device trees with linux"), the aliases node is gone as > the upstream version does not have it. >=20 > This causes a regression in which the SD card cannot be found anymore: >=20 > Since commit the aliases node has been removed > U-Boot 2022.10-00999-gcca41ed3d63f-dirty (Nov 03 2022 - 22:07:38 -030= 0) >=20 > CPU: Freescale i.MX6QP rev1.0 at 792 MHz > Reset cause: POR > DRAM: 2 GiB > Core: 62 devices, 17 uclasses, devicetree: separate > PMIC: PFUZE100 ID=3D0x10 > MMC: FSL_SDHC: 0, FSL_SDHC: 1, FSL_SDHC: 2 > Loading Environment from MMC... MMC: no card present > *** Warning - No block device, using default environment >=20 > Fix it by passing the alias node in the u-boot.dtsi file to > restore the original behaviour where the SD card (esdhc3) was > mapped to mmc0. >=20 > Fixes: d0399a46e7cd ("imx6dl/imx6qdl: synchronise device trees with l= inux") > Signed-off-by: Fabio Estevam I'm not really happy with this approach. It's not that upstream doesn't have aliases now, it's that it has different aliases, right? That's why they won't accept these? But this also highlights that we really need to get these kind of aliases and similar (a) re-synced with upstream ASAP and (b) do that at the start. I don't know which group of "users are broken by this change" is bigger, the group that needs the aliases we have or the group that needs the other aliases, but the group that gets changes upstream first "wins" here is how the OSS world works. --=20 Tom --ikCwydJVc3YoFZrT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmOOEBcACgkQFHw5/5Y0 tyxkbwwAj7+lXAgomyUMwyrMk2zIb20ZFToKaYS5Vv742Hkh0MVigOGpHCUTPK88 zfNB5y1APUxO3AIdYCtg89IEC00RXfPNEHEAKsBsRKdXLZwmvdfYqfVtqZd3o6My MiKadNxttygeuFKsKT/8eKVncW63jCx/8T+tzL4oBMhuHSMUNlZV5dX1qvD45QWi YRvvE6p1Mtvvv1bJB7vMo2bomBOKNXKbuUBkR+eRNPCh2k3tMutWvA+w0BC3fSG4 C8/izElYQn2Z/pfbRApKQ3qp0QOyFlpJNMAYmsc7DYSJr8A3iyeUOqnfwcX3u8Rk Ts+afMS5ZGotuFx7d+4kCfJTFlfOkbjadKmhkiduPxil0W0PlqhR6aOYWaz0ylw0 naDe82rgpxAgN+jfy1QWbYYnr69G2nthX4j+DFHdfmt6UnJS4ftUaTCGkf9vAE1J Vw8ZIXJAepLTAQatibrcwPH0krtIY8jc3rz9faqgXDl4VH/oJVhDnyTRkIVb/LTr JlgT9/C9 =kAM9 -----END PGP SIGNATURE----- --ikCwydJVc3YoFZrT--