From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB6AEC4708D for ; Wed, 7 Dec 2022 20:32:56 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6CB3681A10; Wed, 7 Dec 2022 21:32:49 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="J4IUk1tm"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 52CAD81A10; Wed, 7 Dec 2022 21:32:47 +0100 (CET) Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 479D683600 for ; Wed, 7 Dec 2022 21:32:43 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-wr1-x435.google.com with SMTP id bx10so29905490wrb.0 for ; Wed, 07 Dec 2022 12:32:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=UJANp5ID+po6FqAyrOXEKDM3sRLbizAncVskgY6ZG+g=; b=J4IUk1tm8DVm2QMbL49OFHQEnyEeav33WR9No6UGlAHeLlUpiMu2f8OLUUrRmiShTX q0r4ltWrTT+WAra5+rjeurp1OkprJ032d8Migpnjww6Z374CCR9gdjRAvp0rIkgnE4sz 8mRS1ewZVxITMUkV7orMlG0J+DcnE4rRHIOws= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UJANp5ID+po6FqAyrOXEKDM3sRLbizAncVskgY6ZG+g=; b=hzswVv4/NAjwpxsi+4jIKJWqr/MGo7IiLiN+SlXI4Mei7JVjToVFE3L4QWKMa6fOLJ LQ356C23ZHhgh/FNth0KNhjqW38aHMs4gJ97eY6g1WA5Uqx1n1L48/hM9LvOYOoo7jQ7 577WVyfe47L/ZJNr9zYOR/738+Iukjam3gr1ROIeTS2sgerr8Us0ohtY4xvTQiOrbI4U vpcp66xIK89+Rcaaca5cq+veEvIEEsQgwflXyyCO5zDeyow9QSj4+IT0gK12WvoZMgK9 zAC1/xTH8F94R11DNeXOyaoKhHM6Yu2FAuDT9qvujqsi2e2jG2eyO6y9ACMah/jVICQV GYvA== X-Gm-Message-State: ANoB5pmXuyVOl0AnSasJrLpDbeReZQEhI65vYd2sJTEzwP6TZ+mPMjMr 5TRfDU6N8QrOJhXjAvED943bVQ== X-Google-Smtp-Source: AA0mqf67jiGzatku8mfrzwCsuTyNg/sJRdmnkCRcofcUtdO5tYr8kBxQgibp2UJJgZoUhdu1qY2l4A== X-Received: by 2002:a5d:66ca:0:b0:242:719e:d3d8 with SMTP id k10-20020a5d66ca000000b00242719ed3d8mr7059130wrw.671.1670445157806; Wed, 07 Dec 2022 12:32:37 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-158f-15c0-8c6a-f9d3.res6.spectrum.com. [2603:6081:7b00:6400:158f:15c0:8c6a:f9d3]) by smtp.gmail.com with ESMTPSA id e4-20020adff344000000b00236488f62d6sm20839453wrp.79.2022.12.07.12.32.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Dec 2022 12:32:37 -0800 (PST) Date: Wed, 7 Dec 2022 15:32:33 -0500 From: Tom Rini To: Detlev Casanova Cc: Fabio Estevam , Troy Kisky , u-boot@lists.denx.de, Stefano Babic , "NXP i . MX U-Boot Team" Subject: Re: [PATCH] dts: Re-add aliases for imx6qdl-sabrelite devices Message-ID: <20221207203233.GY3787616@bill-the-cat> References: <20221027152252.46552-1-detlev.casanova@collabora.com> <20221207200356.GX3787616@bill-the-cat> <5971609.lOV4Wx5bFT@falcon9> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="sIQjbYMXZD01BuqX" Content-Disposition: inline In-Reply-To: <5971609.lOV4Wx5bFT@falcon9> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --sIQjbYMXZD01BuqX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 07, 2022 at 03:08:46PM -0500, Detlev Casanova wrote: > On Wednesday, December 7, 2022 3:03:56 P.M. EST Tom Rini wrote: > > On Mon, Dec 05, 2022 at 02:33:48PM -0300, Fabio Estevam wrote: > > > On Mon, Dec 5, 2022 at 12:37 PM Tom Rini wrote: > > > > I'm not really happy with this approach. It's not that upstream do= esn't > > > > have aliases now, it's that it has different aliases, right? That's= why > > > > they won't accept these? > > >=20 > > > imx6q.dtsi does have the default mmc aliases: > > >=20 > > > mmc0 =3D &usdhc1; > > > mmc1 =3D &usdhc2; > > > mmc2 =3D &usdhc3; > > > mmc3 =3D &usdhc4; > > >=20 > > > Upstream does not want to change mmc alias because users may rely on > > > this mmc aliases. > > >=20 > > > Changing it now may cause the board not to boot anymore as the rootfs > > > cannot be found. > > >=20 > > > It is OK to change mmc alias for a newly introduced board, but please > > > keep in mind that > > > wandboard and sabrelite have been launched many many years ago. > > >=20 > > > So for upstream Linux the message was clear: don't change the mmc > > > alias for these boards. > > >=20 > > > Now let's talk about U-Boot. > > >=20 > > > Prior to d0399a46e7cd ("imx6dl/imx6qdl: synchronise device trees with > > >=20 > > > linux") the mmc alias for sabrelite was present: > > > mmc0 =3D &usdhc3; > > > mmc1 =3D &usdhc4; > > >=20 > > > After this commit, the mmc alias is gone and causes the boot > > > regression as reported by Detlev. > > >=20 > > > We don't want to cause regressions in U-Boot as well, so that's why I > > > propose just adding the alias into u-boot.dtsi. > > >=20 > > > There are many boards that does the same. > > >=20 > > > > But this also highlights that we really need to get these kind of > > > > aliases and similar (a) re-synced with upstream ASAP and (b) do tha= t at > > >=20 > > > imx6 dts files are already synced with Linux. > > >=20 > > > > the start. I don't know which group of "users are broken by this ch= ange" > > > > is bigger, the group that needs the aliases we have or the group th= at > > > > needs the other aliases, but the group that gets changes upstream f= irst > > > > "wins" here is how the OSS world works. > > >=20 > > > I prefer to not break things for anyone, hence my proposal. > > >=20 > > > If you are still not happy with it, please feel free to submit a patch > > > with your proposal. > >=20 > > I don't know what we can do about the existing boards, but we need to > > NOT do this moving forward. We need to use whatever the aliases are > > upstream already, or upstream the aliases we want to use. >=20 > Yes, I agree that aliases should be kept in sync with the kernel. But thi= s=20 > case is particular because this board has been using different aliases in= u- > boot and in linux for some time (maybe since forever). >=20 > So this should be kept to avoid breaking existing u-boot setups when they= are=20 > upgraded. I wonder just how many users would end up needing to be fixed here, but... since this is imx6 and not something brand new like 8 or 9, I'll just let it go, here. --=20 Tom --sIQjbYMXZD01BuqX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmOQ+FsACgkQFHw5/5Y0 tyymrAv/cXoxeStRQBo88eX2uSmqoalrJR3duh7SLN0ymMc2nG9LtEWWOzsRZEp6 7NoSODSwnBnCeV7vS86x7YEoaqUyHgFQZbqKByFuRBqZYgdIVf1hHPoVDdXeL92j trD1R7KLI+d1bQrkQQg+FMzjoIEqogcNLccNFSSRmG+715UvSKkBQo9awfz9u0qo YUmHzA29mH6Zof2zg/r46grCXW03HsITAJPRaiy9r4hTwGi8ZD9f9L+sVMvGQQm2 RWXaVlKkWOqs1KuqlP+ZVN9/UcdfPlHgz5vvXHWql/IUcO9Uz/sWcIiqnHx/Weqs 8ZbZE1DeI3uqSmO38Zq4bSoBo+IVg/mVdN1WjKVbl9jY5TH3PSQKxy2LK1+wJsS8 9U/DFljGOza2M8Rkpx6GZ9qxLQclKIWZcMOvgPuT29tssnLl2vE31FvFiNPo2otz D9sCQGpUYmNBHQwPHOcxyXuA/+D+hM9HQht2e/IdLiCAmxRPyVuSy0iNEo7koQdm CYho5UAj =6mkZ -----END PGP SIGNATURE----- --sIQjbYMXZD01BuqX--