From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44539C001B2 for ; Sun, 11 Dec 2022 16:33:03 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id AC639853B5; Sun, 11 Dec 2022 17:32:48 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="OTZwdIPK"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B5369853A7; Sun, 11 Dec 2022 17:32:44 +0100 (CET) Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8048685397 for ; Sun, 11 Dec 2022 17:32:42 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jernej.skrabec@gmail.com Received: by mail-ej1-x62e.google.com with SMTP id vv4so22491609ejc.2 for ; Sun, 11 Dec 2022 08:32:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Nrj4jGUstMXu0lKeGkfSkbwVhRzCuuhv1pGoqIGiErk=; b=OTZwdIPK2IVto5mAvwY+QRDdTblt9pUSYka1Q48tmGa95b7cQfClJWmHGv2xGTmJbq Xwu+cFY4/6IwfU0KN6EvEMMi/g3+rc77OMibPoD7L7GS+4BkYvJ1GeqPXtm8tSUfnyp6 yiV8BVzeRhczi7m6WBtloaQHcRIdeBLevRKl6FQsWZL3EiXW4ivdiu5txTIFdnXDEx+Y 6RwaGCUCU6R7We4eIg2HjRYaHQ0BYxs1sZa2wseSgoyFIUnCa3b4PDqunSJ1CnIMh/hg KAV8UV3PwSdkRle12PHlZeOMEerslSnakqt3p9PKQmWjUFsEUYlVFFy2Qh71pe3wzh93 LTtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Nrj4jGUstMXu0lKeGkfSkbwVhRzCuuhv1pGoqIGiErk=; b=4KH43gUbntCc0R2ZRZuy6YhZfgjX0fDOmd3HbKI36PYtnU4aZmpGkCUdhpTlxjxBFg pgQasDy0nBOXQfRjUVpuCtbaiR4fVienBvYFRvBix2HoxMVNATC0b6SIIzxPoXN02NMX rlYAg8sqRB7OBZrG47bpPsm45l7MPjXwA8M3eO5ihBySjW8gjyX7gqBIVPUgLqHW31nl w8PoOSr36lYIPylDaM9ENovt5e5InFGzFmqBCjsskR8TulgMGbUcL1WMTPUH6jsKbjAS /NgD0xalkts8ay1SvbP7boyM+5ad4JqObEjE0xlFaoFVGJipJKVrkFDLwT02YXhRaJmk 2vfA== X-Gm-Message-State: ANoB5pndDGaF+0O8PD/WBCBdCqvxIXd3MrT8ubU6dweMsFxmhsZukXIf NuBY79ErVGZ4hzIrSeNbwfI= X-Google-Smtp-Source: AA0mqf6ejUmZr29ZkePmnG+DeznlEaXHQODOPL/2mu0Oo036eOxAFGI2TpDAHdrn1s1peLgAfkqnGA== X-Received: by 2002:a17:906:2898:b0:7ad:a350:7fd9 with SMTP id o24-20020a170906289800b007ada3507fd9mr11507718ejd.52.1670776362070; Sun, 11 Dec 2022 08:32:42 -0800 (PST) Received: from localhost.localdomain (82-149-19-102.dynamic.telemach.net. [82.149.19.102]) by smtp.gmail.com with ESMTPSA id qu27-20020a170907111b00b007c0d41736c0sm2243564ejb.39.2022.12.11.08.32.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Dec 2022 08:32:41 -0800 (PST) From: Jernej Skrabec To: andre.przywara@arm.com, jagan@amarulasolutions.com Cc: u-boot@lists.denx.de, Jernej Skrabec Subject: [PATCH 1/8] sunxi: Fix write to H616 DRAM CR register Date: Sun, 11 Dec 2022 17:32:06 +0100 Message-Id: <20221211163213.98540-2-jernej.skrabec@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221211163213.98540-1-jernej.skrabec@gmail.com> References: <20221211163213.98540-1-jernej.skrabec@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Vendor DRAM code actually writes to whole CR register and not just sets bit 31 in mctl_ctrl_init(). Just to be safe, do that here too. Signed-off-by: Jernej Skrabec --- arch/arm/mach-sunxi/dram_sun50i_h616.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-sunxi/dram_sun50i_h616.c b/arch/arm/mach-sunxi/dram_sun50i_h616.c index 454c845a0010..039e76224367 100644 --- a/arch/arm/mach-sunxi/dram_sun50i_h616.c +++ b/arch/arm/mach-sunxi/dram_sun50i_h616.c @@ -873,7 +873,7 @@ static bool mctl_ctrl_init(struct dram_para *para) writel(0x06000400, &mctl_ctl->unk_0x3240); writel(0x06000400, &mctl_ctl->unk_0x4240); - setbits_le32(&mctl_com->cr, BIT(31)); + writel(BIT(31), &mctl_com->cr); mctl_set_addrmap(para); -- 2.38.1