Re: [PATCH 0/8] sunxi: Update H616 DRAM driver

Andre Przywara
2023-01-04T00:49:04Z

On Sun, 11 Dec 2022 17:32:05 +0100
Jernej Skrabec <jernej.skrabec@gmail.com> wrote:

Hi Jernej,

> Current H616 DRAM driver is completely customized to Orange Pi Zero2
> board, which is currently the only H616 board supported by U-Boot.
> Needless to say, this is not ideal for adding new boards. With changes
> in this series, all DDR3 boards are supported and all that is needed is
> just vendor DRAM values extracted from Android image. New DRAM types
> should also be easier to support, since a lot of constants used before
> are not really DRAM type dependent.
>
> Changes were verified by decompiling driver and generated values were
> compared to previous, hard coded ones. This was done without dram_para
> structures, so compiler was able to heavily optimize code and produce
> constants.

so many thanks again for putting this together!
I came to like (the idea of) this series very much lately, as this
removes timing/delay values from the code, and easily allows putting the
vendor provided values in the defconfig.
I used that approach as well for the D1 driver, and am wondering if we
should extend this to other SoCs, potentially unifying the Kconfig part?

And you hinted at a v2, can you provide an estimate for this? If you
send it still this week, I would like to put it into U-Boot's next
branch, otherwise it goes straight into master, should the merge window
open next week as planned.

Btw., to verify the feasibility of drivers/ram/sunxi, I moved the H616
driver into there, together with the Kconfig parts, I wonder what you
think about this? An example of how this looks is in the D1 driver
patches.

Cheers,
Andre

>
> Please take a look.
>
> Best regards,
> Jernej
>
> Jernej Skrabec (8):
> sunxi: Fix write to H616 DRAM CR register
> sunxi: cosmetic: Fix H616 DRAM driver code style
> sunxi: parameterize H616 DRAM ODT values
> sunxi: Convert H616 DRAM options to single setting
> sunxi: Always configure ODT on H616 DRAM
> sunxi: Make bit delay function in H616 DRAM code void
> sunxi: Parameterize bit delay code in H616 DRAM driver
> sunxi: Parameterize H616 DRAM code some more
>
> .../include/asm/arch-sunxi/dram_sun50i_h616.h | 18 +
> arch/arm/mach-sunxi/Kconfig | 67 +--
> arch/arm/mach-sunxi/dram_sun50i_h616.c | 445 +++++++++++-------
> configs/orangepi_zero2_defconfig | 8 +-
> 4 files changed, 348 insertions(+), 190 deletions(-)
>