Re: [PATCH 6/8] sunxi: Make bit delay function in H616 DRAM code void

Andre Przywara
2023-01-04T00:40:09Z

On Sun, 11 Dec 2022 17:32:11 +0100
Jernej Skrabec <jernej.skrabec@gmail.com> wrote:

> Mentioned function result is always true and result isn't checked
> anyway. Let's make it void.
>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Cheers,
Andre

> ---
> arch/arm/mach-sunxi/dram_sun50i_h616.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-sunxi/dram_sun50i_h616.c b/arch/arm/mach-sunxi/dram_sun50i_h616.c
> index bf5b4ddfb5c2..3b2ba168498c 100644
> --- a/arch/arm/mach-sunxi/dram_sun50i_h616.c
> +++ b/arch/arm/mach-sunxi/dram_sun50i_h616.c
> @@ -572,7 +572,7 @@ static bool mctl_phy_write_training(struct dram_para *para)
> return result;
> }
>
> -static bool mctl_phy_bit_delay_compensation(struct dram_para *para)
> +static void mctl_phy_bit_delay_compensation(struct dram_para *para)
> {
> u32 *ptr;
> int i;
> @@ -683,8 +683,6 @@ static bool mctl_phy_bit_delay_compensation(struct dram_para *para)
>
> setbits_le32(SUNXI_DRAM_PHY0_BASE + 0x54, 0x80);
> }
> -
> - return true;
> }
>
> static bool mctl_phy_init(struct dram_para *para)