Re: [PATCH v3 2/2] board: mediatek: add mt8195 demo board

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1373 bytes --]

On Mon, Dec 12, 2022 at 01:53:05PM -0500, Tom Rini wrote:
> On Mon, Dec 12, 2022 at 11:53:04AM -0500, Tom Rini wrote:
> > On Thu, Nov 10, 2022 at 03:34:53PM +0800, Macpaul Lin wrote:
> > 
> > > From: Fabien Parent <fparent@baylibre.com>
> > > 
> > > Add mt8195-demo board support.
> > > This demo purpose board uses MediaTek's MT8195 SoC.
> > > 
> > > Signed-off-by: Fabien Parent <fparent@baylibre.com>
> > > Signed-off-by: Amjad Ouled-Ameur <aouledameur@baylibre.com>
> > > Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> > [snip]
> > > +#include <linux/sizes.h>
> > > +
> > > +#define CONFIG_SYS_NS16550_SERIAL
> > > +#define CONFIG_SYS_NS16550_REG_SIZE	-4
> > > +#define CONFIG_SYS_NS16550_MEM32
> > > +#define CONFIG_SYS_NS16550_COM1		0x11002000
> > > +#define CONFIG_SYS_NS16550_CLK		26000000
> > 
> > This is unused, I believe.  But when trying to build with current next I
> > get:
> > Error: Load Address must be set.
> > Error: Bad parameters for image type
> > 
> > Please rebase on top of current next and repost, thanks!
> 
> Sorry for the noise, this failed due to another patch that needs to be
> reworked instead.

Welp, I should have finished my re-testing.  The patch that broke
phycore-rk3288 and I assumed broke this platform too, did not break this
platform, there's still some other problem here.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]