From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 039FEC4332F for ; Tue, 13 Dec 2022 20:32:36 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 603CA839DC; Tue, 13 Dec 2022 21:32:34 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=kemnade.info Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kemnade.info header.i=@kemnade.info header.b="fvkbX6hc"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3592183897; Tue, 13 Dec 2022 21:32:33 +0100 (CET) Received: from mail.andi.de1.cc (mail.andi.de1.cc [IPv6:2a01:238:4321:8900:456f:ecd6:43e:202c]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 25B2884222 for ; Tue, 13 Dec 2022 21:32:31 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=kemnade.info Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andreas@kemnade.info DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20220719; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=qhS3a4cAxAiv/uG11jhimBOSLjflfqcxuVMSQvXKXLM=; b=fvkbX6hcHjDKo8lON8ux5UZvXw mzHgXDnPDmpC+wcI12RsaLavSw3hu4wt3gzDiXokBb9yJWHwA310FTuSkqwYuYv11/zcfl/NCUrii IE6Pkh8UyDvD8gNTsd6Z+CIpVk8kHbRKDek/nKNcd1wtqargCmAoJrhSqKeDyIrTUEo1TxNDVa/J+ 2jH03OBMaGL1TRuH96RIn2FTgat57g1HcVIVD/POqnIQDVLCr/5uuwQ6DSp7l+knNC4+aV9I5nj7i LDSitx6szilANDhX3A03dMzJ5ddt56/kLQNr3VkwKsW9Kp/A/yk47Ro2eYabbiGnJiMS9/fx2OpA+ Muy1Fs4A==; Received: from p200300ccff167b001a3da2fffebfd33a.dip0.t-ipconnect.de ([2003:cc:ff16:7b00:1a3d:a2ff:febf:d33a] helo=aktux) by mail.andi.de1.cc with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1p5Bwz-0007Ep-Tc; Tue, 13 Dec 2022 21:32:30 +0100 Date: Tue, 13 Dec 2022 21:32:28 +0100 From: Andreas Kemnade To: Tom Rini Cc: marex@denx.de, u-boot@lists.denx.de, t-kristo@ti.com, kristo@kernel.org, tony@atomide.com Subject: Re: [PATCH 2/2] musb-new: omap2430: fix musb probing in gadget mode Message-ID: <20221213213228.6fdf05e7@aktux> In-Reply-To: <20221212190057.GA85481@bill-the-cat> References: <20221126223010.3319020-1-andreas@kemnade.info> <20221126223010.3319020-3-andreas@kemnade.info> <20221212190057.GA85481@bill-the-cat> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi, just noticed I am doing two things in one patch. better do it with just some patches On Mon, 12 Dec 2022 14:00:57 -0500 Tom Rini wrote: > On Sat, Nov 26, 2022 at 11:30:10PM +0100, Andreas Kemnade wrote: > > > Host mode structures were accessed but not initialized first thing -> struct usb_bus_priv *priv = dev_get_uclass_priv(dev); which will be zero if not in host mode (and later priv->something is accessed unconditional. > > and gadget dm did not compile at all. > > preparing things for DM_USB_GADGET should probably better a separate patch. I will send an update hopefully soon. > > Signed-off-by: Andreas Kemnade > > --- > > drivers/usb/musb-new/omap2430.c | 42 ++++++++++++++++++++------------- > > 1 file changed, 25 insertions(+), 17 deletions(-) > > This breaks omap3_beagle and omap3_evm. > Regards, Andreas