From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7760AC4332F for ; Wed, 14 Dec 2022 09:12:46 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DE85E850AA; Wed, 14 Dec 2022 10:12:43 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="wt80OaSa"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9786284231; Wed, 14 Dec 2022 10:12:42 +0100 (CET) Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E353C8510E for ; Wed, 14 Dec 2022 10:12:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pg1-x52e.google.com with SMTP id s196so1565276pgs.3 for ; Wed, 14 Dec 2022 01:12:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:mail-followup-to:message-id:subject:cc:to :from:date:from:to:cc:subject:date:message-id:reply-to; bh=Uwgm41keGV96nxpMyCdiX7iASmg4cQS4KAQyXlohFE4=; b=wt80OaSaiT3YO8KIbbukyuqimJpvD4MWLkaSdHL5LNTsi3yYSODjzPOxI711uSbgnx hQQM8eRGnh0i2rc0+QeAzoB9xKbjXOhbfz+IiG/hJk1t5x6xevnokWmBTR72d8J/CEWK 0M69KmVfqMtCa/eeU6uSEfFkzGc8vjkm3Nr5D5bt5HtFUUWXF8rPjzvITyl6OhzUW1Tz N/IacuX666AqgPhRNPWtMscV6lJI/tvA08+zmA/sNtLyDJ3QTEmpjz2CHobDCbCYLFCe FHMRnpXRqKalTz4u74R2jssqQsMYNCGYZ4304DVAfQKfWpwNCXBvFqt4QU9UFjYq4dTe O3JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:mail-followup-to:message-id:subject:cc:to :from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Uwgm41keGV96nxpMyCdiX7iASmg4cQS4KAQyXlohFE4=; b=eF44zUpmEeQAgWjJZMiron9niSWAwNBQ4AfLQmz4G5ScBwakpPpBSZ5p0OprprVh9u ywNKlbhYVwLJ7HMjSo6OYvmN8Yi63Xlb+trPqDnMJgNpWK0ESYQ6pDJscYXcN4VUWVl3 5/Q0tYnpDShWJ9i2lz8lCK4CTNn45qFdbfSDQHNiZsOkYeuB8Y0M/VDlRWwXQ84pTGmC Kau7N6LQMJQNK3+6wjuZRNQeW2dLs0zm4puaNyqvErY3VhAjBca2LNoovaEIW/jKQiN+ kqGdr6J2oSAWuAjHsJRkyVvZV/ku68+P8tAx94Ib+1bKZG21UV1KgECz0/56g08WL0X6 as3A== X-Gm-Message-State: ANoB5plAQJlrPrudZdb/kgXwBXhn2AiseBwKaBooMr6d7B1y9HjRJdV8 ErFwt8mGAs58KiWYgguBYvRSdQ== X-Google-Smtp-Source: AA0mqf47JQs9pziCAlW/BSBs52eluXJTM+qsPdxP3ibspeYLKv6CIJKlo+j35POeWUmXDBge2TjAmQ== X-Received: by 2002:a62:16d0:0:b0:576:a899:78e2 with SMTP id 199-20020a6216d0000000b00576a89978e2mr5393340pfw.1.1671009157079; Wed, 14 Dec 2022 01:12:37 -0800 (PST) Received: from laputa ([2400:4050:c3e1:100:cbcd:3a29:1b72:c83e]) by smtp.gmail.com with ESMTPSA id w11-20020aa7954b000000b00528a097aeffsm8948372pfq.118.2022.12.14.01.12.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Dec 2022 01:12:36 -0800 (PST) Date: Wed, 14 Dec 2022 18:12:32 +0900 From: AKASHI Takahiro To: Vincent Stehl?? Cc: u-boot@lists.denx.de, Heinrich Schuchardt , Ilias Apalodimas Subject: Re: [PATCH 1/2] efi_loader: fix get_package_list_handle() status Message-ID: <20221214091232.GA21494@laputa> Mail-Followup-To: AKASHI Takahiro , Vincent Stehl?? , u-boot@lists.denx.de, Heinrich Schuchardt , Ilias Apalodimas References: <20221213213910.513801-1-vincent.stehle@arm.com> <20221213213910.513801-2-vincent.stehle@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221213213910.513801-2-vincent.stehle@arm.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Tue, Dec 13, 2022 at 10:39:09PM +0100, Vincent Stehl?? wrote: > When the HII protocol function get_package_list_handle() is called with an > invalid package list handle, it returns EFI_NOT_FOUND but this is not in > its list of possible status codes as per the EFI specification. > Return EFI_INVALID_PARAMETER instead to fix conformance. Thank you for the heads-up. You're right as far as the EFI specification is concerned. FYI, EDK-II also returns EFI_NOT_FOUND if the package list handle is *valid* and yet we cannot find any matching handle in the HII database. See MdeModulePkg/Universal/HiiDatabaseDxe/Database.c -Takahiro Akashi > Signed-off-by: Vincent Stehlé > Cc: Heinrich Schuchardt > Cc: Ilias Apalodimas > --- > lib/efi_loader/efi_hii.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/efi_loader/efi_hii.c b/lib/efi_loader/efi_hii.c > index 75ff58aafa5..27db3be6a17 100644 > --- a/lib/efi_loader/efi_hii.c > +++ b/lib/efi_loader/efi_hii.c > @@ -780,7 +780,7 @@ get_package_list_handle(const struct efi_hii_database_protocol *this, > } > } > > - return EFI_EXIT(EFI_NOT_FOUND); > + return EFI_EXIT(EFI_INVALID_PARAMETER); > } > > const struct efi_hii_database_protocol efi_hii_database = { > -- > 2.35.1 >