From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E99F6C4708D for ; Mon, 19 Dec 2022 13:36:41 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0E76084567; Mon, 19 Dec 2022 14:36:39 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="tDoIARHq"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A73DC850CB; Mon, 19 Dec 2022 14:36:36 +0100 (CET) Received: from mail-vs1-xe2a.google.com (mail-vs1-xe2a.google.com [IPv6:2607:f8b0:4864:20::e2a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1608E84480 for ; Mon, 19 Dec 2022 14:36:34 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-vs1-xe2a.google.com with SMTP id 128so8631627vsz.12 for ; Mon, 19 Dec 2022 05:36:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sgQ+eYZXKdeFUC0jwpabPv8PS0Wm6QG1MlenWrBfrOo=; b=tDoIARHqU9Vj126U0Hn4Da3CaEe1qAQzYxybw37XW8Dgzki24uwGuqMytbWsI3SpBR BE+sX3lUcyduMqYl4SpYE2WFwN8GStdvGmRzxLhn9dB8yb+s2IRjBV2MnUrNJkLMdE9F EtcG4qYrTT8MQeGxnIHSri6DbW5cIVXOiHfLI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sgQ+eYZXKdeFUC0jwpabPv8PS0Wm6QG1MlenWrBfrOo=; b=OHlildheo59Cew9/F6Mkg9rK/6iV9QDp7AEIHfLsutnaMNxxC58TQlN2VpWCRfUAHu AaIgJZAtIEnBeWZ+AuEVCgfT2ui3V252i2RKnT3qSSXiawSIynOeIYnzpwEcsXtJlqkX MlEsPbXsS9dT2IkCUAtk3b8bsIyLLa2IO56uOr9j6YaZV7RIfCPqiMf0fdTLdf53CuRH v7yik/6aKdd5xdswDVunjWVFB0F5qFZ0qWeUL2tZS41zxPgOVQ/gtoRSnf16TrctI1of D1F9NGNWGvIPAYhoaSCDZWOmKjf+6uA9iLPclwnUSeFzUdySSUjhMy/WTaIZVnw1ygCr 7QTA== X-Gm-Message-State: ANoB5pkwayz8QMbW3rop2Py3pFK1zl0D4vI1GHBYU4VimHmdeubn350V wQk1ta2ZTrcJEenjTJjfJ2k58A== X-Google-Smtp-Source: AA0mqf5lVmZFouaDRoR7f1yDhpoOUUWzaYqLmBOvxfsIe1y7ZIQ1yRQQ+qPixkrsxsTG/0wA0sLVoQ== X-Received: by 2002:a05:6102:512:b0:3b2:e469:d13d with SMTP id l18-20020a056102051200b003b2e469d13dmr20788527vsa.17.1671456992588; Mon, 19 Dec 2022 05:36:32 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-4d96-3cb2-8dd6-9e31.res6.spectrum.com. [2603:6081:7b00:6400:4d96:3cb2:8dd6:9e31]) by smtp.gmail.com with ESMTPSA id l1-20020a37f901000000b007025753c4a5sm1184694qkj.6.2022.12.19.05.36.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Dec 2022 05:36:32 -0800 (PST) Date: Mon, 19 Dec 2022 08:36:30 -0500 From: Tom Rini To: Nikita Shubin Cc: Simon Glass , linux@yadro.com, Nikita Shubin , Pali =?iso-8859-1?Q?Roh=E1r?= , Heinrich Schuchardt , Marek =?iso-8859-1?Q?Beh=FAn?= , Quentin Schulz , u-boot@lists.denx.de Subject: Re: [PATCH] Makefile: add -W for BINMAN_ALLOW_MISSING Message-ID: <20221219133630.GL3787616@bill-the-cat> References: <20221216092745.31266-1-nikita.shubin@maquefel.me> <20221219112145.0708131d@redslave.neermore.group> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="LUlb1AdbpDvmRuvW" Content-Disposition: inline In-Reply-To: <20221219112145.0708131d@redslave.neermore.group> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --LUlb1AdbpDvmRuvW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 19, 2022 at 11:21:45AM +0300, Nikita Shubin wrote: > Hello Tom and Simon! >=20 > On Sat, 17 Dec 2022 14:38:30 -0700 > Simon Glass wrote: >=20 > > +Tom Rini > >=20 > > We do actually want to report the failure, since it means that the > > image will not function. This was a recent change requested by a few > > people. >=20 > It doesn't make sense to me - if i am passing "--allow-missing" than > binman shouldn't fail drastically, cause i literally told him "It's okay > if files are missing". What purpose does it have now, it we are failing > regardless we are providing this flag or not ? >=20 > This breaks old behaviour by the way, when passing "--allow-missing" > for missing blobs produced a warning instead of error. >=20 > >=20 > > Note that buildman looks for the message 'Some images are invalid' and > > either returning 103, or 0 if -W is given. > >=20 > > There is no attempt to produce a special exit code from the Makefile. > > It generally returns 2 (as per 'man make'), which is why buildman has > > this extra processing. >=20 > Well, there are only 3 codes for make and 2 indicates any failure: >=20 > "A status of two will be returned if any errors were encountered." (c) >=20 > This new behaviour looks the same with or without BINMAN_ALLOW_MISSING > flag from top point of view: >=20 > With BINMAN_ALLOW_MISSING=3D1: > Some images are invalid > make[1]: *** [Makefile:1114: .binman_stamp] Error 103 > make[1]: Leaving directory '/home/maquefel/workshop/overlord/u-boot' > make: *** [Makefile:271: u-boot/u >=20 > $ echo $? > 2-boot-nodtb.bin] Error 2 >=20 > Without BINMAN_ALLOW_MISSING: >=20 > binman: Filename 'fw_dynamic.bin' not found in input path > (.,.,./board/syntacore/scr7_elct,arch/riscv/dts) > (cwd=3D'/home/maquefel/workshop/overlord/u-boot') make[1]: *** > [Makefile:1114: .binman_stamp] Error 1 make[1]: Leaving directory > '/home/maquefel/workshop/overlord/u-boot' make: *** [Makefile:271: > u-boot/u-boot-nodtb.bin] Error 2 >=20 > $ echo $? > 2 >=20 > So that's the difference if build is failing either way ? So, with what is in master right now, BINMAN_ALLOW_MISSING=3D1 should work as intended, while it did not at its introduction. Please confirm if your use cases work now, or not. The problem we needed to solve was the one that by default previously, you could run "make fooboard_config all", not have BL31/etc available, get a warning printed and a zero exit code, leading to non-obvious failures if you build indirectly (buildroot, yocto/OE, etc). --=20 Tom --LUlb1AdbpDvmRuvW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmOgaNoACgkQFHw5/5Y0 tyxEyQwAjALZ1awqsENbUvB9tbaMRiOg2I78prpfjqHVRgVxJ39q7xSTysW0/dDF 0UShmJLf5sDmAEqSbyGwQF1LyE4L8z+6C9ya1baI9T7zY+RaeuLCnO6ElbTuADCk 89Xau/WyVFxKTjEIkdVK+snjYkD//epdqKLH383xJVjTbOVNEgOlJY3QgcJtOfu5 dbwZkj34COp84i8ZS5ypgA14ShOmEnlJE8/dEZWI0FdCbilbPZ/01nq9fXmHuQnW 4SjTnd4vYs9jCZFAGWjAkKVw6ICGxI4hZNvXwnNO1WFq5kuEtCjEgPZbOZMGd1i8 k1iRDZAHCthdqdxcixem88QdU5HCSxsPuRE1QC3n23f9H8oBGcVoUVRZzvbeHOTD 2DF2bJnX0/oaHLygl9ZlCoaHjKnutP9Cwq6j3YxjPhY6L6C0Wk92cuJQ72xP/NnP mldpI12/sHGIAjJwqnGXUS6YpCzLj4HxtEIS4kPRun2fhgQasSr3R+ih84ixv3aA fM3YwpMf =Lw+c -----END PGP SIGNATURE----- --LUlb1AdbpDvmRuvW--