From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E056C4332F for ; Tue, 20 Dec 2022 15:55:27 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E7B3C817FB; Tue, 20 Dec 2022 16:55:24 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id E2ABA82A0A; Tue, 20 Dec 2022 16:55:23 +0100 (CET) Received: from mail-oi1-f174.google.com (mail-oi1-f174.google.com [209.85.167.174]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9426B806EE for ; Tue, 20 Dec 2022 16:55:21 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=robherring2@gmail.com Received: by mail-oi1-f174.google.com with SMTP id c133so3976638oif.1 for ; Tue, 20 Dec 2022 07:55:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OffbzBuCGrBFz02nJz6HN0syX5I7DMW2xb4sFrt/ffk=; b=nX2wlZHFxsRbX+dberJaZfyi3AnMI1FzWuF5h8kukg7MvxgVjcJ0oOK37uEZGgMeMx AXJSfevElof5wsKqLgAlPlkaarSSNkbv61v1JbRxqbDvCuuEX+0s5PZan1newNO7dDML H5Xv9lKW+DIe/0+uNLveir1Bpxg4Ac0pz6961TUbod8bweTSkWtQW9FWvcZ01+OXacwe 48wtcHzsQD5swrcdL2kB505N63KEvBAWRtbQuKFY7SGY0e3nc7lmAGkZZV8yNAOGB7kn x7CCdhg3kRzbbSQJDPAmeO/E0pLkKDRAV9hpisni9LUWWVc2VBSVnoHi4bt1jBWhrns3 yTQQ== X-Gm-Message-State: ANoB5pki9BnEZsR8I2tZpSBj5VrLZFNc9G3RrNsppv1z9PtG0gVp1q5N zbZSPTC2i/2rCh/dtSb0bA== X-Google-Smtp-Source: AA0mqf7LAl225jmGcx0Qlrr00x2aWw0OX6YLT+5jeSWXSgrIRWK0VJkLLysI+mkJLq6K7K5PNecBTA== X-Received: by 2002:aca:b541:0:b0:359:a465:42b1 with SMTP id e62-20020acab541000000b00359a46542b1mr18508655oif.1.1671551720065; Tue, 20 Dec 2022 07:55:20 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id ca11-20020a056830610b00b0066dae8cf9a0sm5816887otb.50.2022.12.20.07.55.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Dec 2022 07:55:19 -0800 (PST) Received: (nullmailer pid 608203 invoked by uid 1000); Tue, 20 Dec 2022 15:55:18 -0000 Date: Tue, 20 Dec 2022 09:55:18 -0600 From: Rob Herring To: Paul Barker Cc: u-boot@lists.denx.de, Simon Glass , Tom Rini , Heinrich Schuchardt , Ilias Apalodimas , Jagan Teki Subject: Re: [PATCH v5 3/3] arm: dts: am335x-sancloud-bbe-lite: UEFI SPI export Message-ID: <20221220155518.GA583248-robh@kernel.org> References: <20221123175006.4080122-1-paul.barker@sancloud.com> <20221123175006.4080122-4-paul.barker@sancloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221123175006.4080122-4-paul.barker@sancloud.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Wed, Nov 23, 2022 at 05:50:06PM +0000, Paul Barker wrote: > Add properties to the Authenta SPI flash device node to enable access by > a UEFI application using a fixed GUID. > > Signed-off-by: Paul Barker > --- > arch/arm/dts/am335x-sancloud-bbe-lite-u-boot.dtsi | 13 ++++++++++--- > arch/arm/dts/am335x-sancloud-bbe-lite.dts | 2 +- > 2 files changed, 11 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/dts/am335x-sancloud-bbe-lite-u-boot.dtsi b/arch/arm/dts/am335x-sancloud-bbe-lite-u-boot.dtsi > index 01c105ebb383..6c4ff67f9a4b 100644 > --- a/arch/arm/dts/am335x-sancloud-bbe-lite-u-boot.dtsi > +++ b/arch/arm/dts/am335x-sancloud-bbe-lite-u-boot.dtsi > @@ -38,7 +38,14 @@ > > &spi0 { > u-boot,dm-pre-reloc; > - channel@0 { > - u-boot,dm-pre-reloc; > - }; > +}; > + > +&authenta_flash { > + u-boot,dm-pre-reloc; > + > + u-boot,uefi-spi-vendor = "micron"; > + u-boot,uefi-spi-part-number = "mt25ql128abb"; Looks like a compatible string. Yet, the flash node compatible string, micron,spi-authenta, is not documented (though in use for spidev). So use a compatible string for the flash that is specific to the flash model. I assume there is some reason the specific model is needed? > + /* GUID in UEFI format: 77126730-a4ca-4386-b341-881fe18e7f7d */ > + u-boot,uefi-spi-io-guid = [30 67 12 77 ca a4 86 43 > + b3 41 88 1f e1 8e 7f 7d]; We need to define first in the DT spec the format for GUIDs. I don't think there are any existing cases though some have been proposed. IMO, I would make this a string instead. The byte array is not that readable with its little endian order. A GUID as a string is readily identifiable as a GUID. Why is this u-boot specific? Another UEFI implementation doesn't need the GUID? Rob