Re: [PATCH u-boot] powerpc/mpc85xx: socrates: Re-enable building u-boot-socrates.bin

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 2471 bytes --]

On Fri, Dec 30, 2022 at 01:44:04PM +0100, Pali Rohár wrote:

> Tom, would you take this patch to master?

Yes, I'm just assuming Heiko will have a chance to test this before the
release on the 9th, thanks.

> 
> On Wednesday 28 December 2022 19:18:39 Pali Rohár wrote:
> > U-Boot build system builds final U-Boot binary for socrates board in custom
> > file u-boot-socrates.bin (instead of standard u-boot.bin). Output target
> > file u-boot-socrates.bin is generated by binman as defined in board binman
> > config file arch/powerpc/dts/socrates-u-boot.dtsi.
> > 
> > But binman was disabled in commit 5af42eafd7e1 ("Makefile: Reduce usage of
> > custom mpc85xx u-boot.bin target") for all mpc85xx boards which do not use
> > standard powerpc binman config file arch/powerpc/dts/u-boot.dtsi and boards
> > which do not require binman at all.
> > 
> > The only such mpc85xx board is socrates. So since that commit, U-Boot does
> > not final binary for socrates board anymore.
> > 
> > Fix this issue by re-enabling binman for socrates board. And build process
> > starts again producing u-boot-socrates.bin binary.
> > 
> > Note that build process for this socrates board always produce u-boot.bin
> > binary which is broken and not usable for socrates board. Long term
> > solution should be to disable building broken binary u-boot.bin and then
> > renaming u-boot-socrates.bin to u-boot.bin, or switching to use common
> > powerpc binman config file arch/powerpc/dts/socrates-u-boot.dtsi (if it is
> > possible).
> > 
> > Fixes: 5af42eafd7e1 ("Makefile: Reduce usage of custom mpc85xx u-boot.bin target")
> > Signed-off-by: Pali Rohár <pali@kernel.org>
> > ---
> > Heiko Schocher: Could you test if u-boot is still working on this board?
> > 
> > Tom Rini: Cannot be this issue handled by CI? For example that CI check
> > build process produce required output binaries?
> > ---
> >  arch/powerpc/cpu/mpc85xx/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/powerpc/cpu/mpc85xx/Kconfig b/arch/powerpc/cpu/mpc85xx/Kconfig
> > index 24d3f1f20c25..4c765efab7a5 100644
> > --- a/arch/powerpc/cpu/mpc85xx/Kconfig
> > +++ b/arch/powerpc/cpu/mpc85xx/Kconfig
> > @@ -72,6 +72,7 @@ choice
> >  config TARGET_SOCRATES
> >  	bool "Support socrates"
> >  	select ARCH_MPC8544
> > +	select BINMAN
> >  
> >  config TARGET_P3041DS
> >  	bool "Support P3041DS"
> > -- 
> > 2.20.1
> > 

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]