From: Alexander Graf <agraf@csgraf.de>
To: u-boot@lists.denx.de
Cc: Matthias Brugger <mbrugger@suse.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Anatolij Gustschin <agust@denx.de>,
Simon Glass <sjg@chromium.org>, Da Xue <da@libre.computer>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Jagan Teki <jagan@amarulasolutions.com>,
Andre Przywara <andre.przywara@arm.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Philipp Tomsich <philipp.tomsich@vrull.eu>,
Kever Yang <kever.yang@rock-chips.com>,
Patrick Delaunay <patrick.delaunay@foss.st.com>,
Patrice Chotard <patrice.chotard@foss.st.com>,
uboot-stm32@st-md-mailman.stormreply.com,
u-boot-amlogic@groups.io
Subject: [PATCH v4 5/9] efi_loader: GOP: Add damage notification on BLT
Date: Tue, 3 Jan 2023 22:50:00 +0100 [thread overview]
Message-ID: <20230103215004.22646-6-agraf@csgraf.de> (raw)
In-Reply-To: <20230103215004.22646-1-agraf@csgraf.de>
Now that we have a damage tracking API, let's populate damage done by
UEFI payloads when they BLT data onto the screen.
Signed-off-by: Alexander Graf <agraf@csgraf.de>
Reported-by: Da Xue <da@libre.computer>
---
v1 -> v2:
- Remove ifdefs from gop
v2 -> v3:
- Adapt to always assume DM is used
v3 -> v4:
- Skip damage on EfiBltVideoToBltBuffer
---
lib/efi_loader/efi_gop.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/lib/efi_loader/efi_gop.c b/lib/efi_loader/efi_gop.c
index d1dc2f22d0..425dcbf6b1 100644
--- a/lib/efi_loader/efi_gop.c
+++ b/lib/efi_loader/efi_gop.c
@@ -32,6 +32,7 @@ struct efi_gop_obj {
struct efi_gop ops;
struct efi_gop_mode_info info;
struct efi_gop_mode mode;
+ struct udevice *vdev;
/* Fields we only have access to during init */
u32 bpix;
void *fb;
@@ -120,6 +121,7 @@ static __always_inline efi_status_t gop_blt_int(struct efi_gop *this,
u32 *fb32 = gopobj->fb;
u16 *fb16 = gopobj->fb;
struct efi_gop_pixel *buffer = __builtin_assume_aligned(bufferp, 4);
+ bool blt_to_video = (operation != EFI_BLT_VIDEO_TO_BLT_BUFFER);
if (delta) {
/* Check for 4 byte alignment */
@@ -243,6 +245,9 @@ static __always_inline efi_status_t gop_blt_int(struct efi_gop *this,
dlineoff += dwidth;
}
+ if (blt_to_video)
+ video_damage(gopobj->vdev, dx, dy, width, height);
+
return EFI_SUCCESS;
}
@@ -547,6 +552,7 @@ efi_status_t efi_gop_register(void)
gopobj->info.pixels_per_scanline = col;
gopobj->bpix = bpix;
gopobj->fb = fb;
+ gopobj->vdev = vdev;
return EFI_SUCCESS;
}
--
2.37.1 (Apple Git-137.1)
next prev parent reply other threads:[~2023-01-03 21:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 21:49 [PATCH v4 0/9] Add video damage tracking Alexander Graf
2023-01-03 21:49 ` [PATCH v4 1/9] dm: video: Add damage tracking API Alexander Graf
2023-01-07 0:13 ` Simon Glass
2023-01-03 21:49 ` [PATCH v4 2/9] dm: video: Add damage notification on display clear Alexander Graf
2023-01-07 0:13 ` Simon Glass
2023-01-03 21:49 ` [PATCH v4 3/9] vidconsole: Add damage notifications to all vidconsole drivers Alexander Graf
2023-01-07 0:13 ` Simon Glass
2023-01-03 21:49 ` [PATCH v4 4/9] video: Add damage notification on bmp display Alexander Graf
2023-01-07 0:13 ` Simon Glass
2023-01-03 21:50 ` Alexander Graf [this message]
2023-01-04 12:50 ` [PATCH v4 5/9] efi_loader: GOP: Add damage notification on BLT Heinrich Schuchardt
2023-01-03 21:50 ` [PATCH v4 6/9] video: Only dcache flush damaged lines Alexander Graf
2023-01-03 21:50 ` [PATCH v4 7/9] video: Use VIDEO_DAMAGE for VIDEO_COPY Alexander Graf
2023-01-07 0:13 ` Simon Glass
2023-01-07 22:40 ` Heinrich Schuchardt
2023-01-08 15:48 ` Simon Glass
2023-01-03 21:50 ` [PATCH v4 8/9] video: Always compile cache flushing code Alexander Graf
2023-01-07 0:13 ` Simon Glass
2023-01-03 21:50 ` [PATCH v4 9/9] video: Enable VIDEO_DAMAGE for drivers that need it Alexander Graf
2023-01-04 12:32 ` Neil Armstrong
2023-01-07 0:13 ` Simon Glass
2023-01-07 0:13 ` [PATCH v4 0/9] Add video damage tracking Simon Glass
2023-04-14 7:35 ` Antonio Murdaca
2023-04-19 1:45 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230103215004.22646-6-agraf@csgraf.de \
--to=agraf@csgraf.de \
--cc=agust@denx.de \
--cc=andre.przywara@arm.com \
--cc=da@libre.computer \
--cc=ilias.apalodimas@linaro.org \
--cc=jagan@amarulasolutions.com \
--cc=kever.yang@rock-chips.com \
--cc=mbrugger@suse.com \
--cc=neil.armstrong@linaro.org \
--cc=patrice.chotard@foss.st.com \
--cc=patrick.delaunay@foss.st.com \
--cc=philipp.tomsich@vrull.eu \
--cc=sjg@chromium.org \
--cc=u-boot-amlogic@groups.io \
--cc=u-boot@lists.denx.de \
--cc=uboot-stm32@st-md-mailman.stormreply.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox