Re: [PATCH 1/4] sunxi: remove unused CONFIG_MMC_SUNXI_SLOT

Samuel Holland
2022-12-14T05:45:55Z

On 12/13/22 18:22, Andre Przywara wrote:
> There is a CONFIG_MMC_SUNXI_SLOT definition in our sunxi_common.h config
> header, which was used to note the first MMC controller to initialise.
> The definition in that header was always set to 0, with no easy way of
> overriding this, and certainly none of the existing boards made any use
> of that (non-)feature.
> Remove that definition and replace it with a constant 0 in the only
> user, in board.c. It turns out that this is safe, as this is only used
> in the SPL, and the BROM also unconditionally initialises MMC0.
> This also removes the last legacy config symbol with SUN*I in it from
> the whitelist.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> ---
> board/sunxi/board.c | 9 +++++++--
> include/configs/sunxi-common.h | 3 ---
> scripts/config_whitelist.txt | 1 -
> 3 files changed, 7 insertions(+), 6 deletions(-)

Reviewed-by: Samuel Holland <samuel@sholland.org>
Tested-by: Samuel Holland <samuel@sholland.org>