From: Pei Yue Ho <peiyue.ho@starfivetech.com>
To: <u-boot@lists.denx.de>
Cc: <peiyue.ho@starfivetech.com>, <englee.teh@starfivetech.com>,
<weiliang.lim@starfivetech.com>
Subject: [PATCH 2/2] i2c: i2c-cdns.c: Update driver to read fifo-depth from device tree
Date: Tue, 3 Jan 2023 23:20:05 -0800 [thread overview]
Message-ID: <20230104072005.7812-3-peiyue.ho@starfivetech.com> (raw)
In-Reply-To: <20230104072005.7812-1-peiyue.ho@starfivetech.com>
Enable driver to fetch the optional parameter (fifo-depth)
from device tree. If the parameter is not found in the device
tree, it will use the default value declared in the driver.
Signed-off-by: Pei Yue Ho <peiyue.ho@starfivetech.com>
Reviewed-by: Wei Liang Lim <weiliang.lim@starfivetech.com>
Reviewed-by: Eng Lee Teh <englee.teh@starfivetech.com>
---
drivers/i2c/i2c-cdns.c | 26 ++++++++++++++++----------
1 file changed, 16 insertions(+), 10 deletions(-)
diff --git a/drivers/i2c/i2c-cdns.c b/drivers/i2c/i2c-cdns.c
index 0da9f6f35a..65a0c76a2a 100644
--- a/drivers/i2c/i2c-cdns.c
+++ b/drivers/i2c/i2c-cdns.c
@@ -78,7 +78,7 @@ struct cdns_i2c_regs {
CDNS_I2C_INTERRUPT_RXUNF | \
CDNS_I2C_INTERRUPT_ARBLOST)
-#define CDNS_I2C_FIFO_DEPTH 16
+#define CDNS_I2C_FIFO_DEPTH_DEFAULT 16
#define CDNS_I2C_TRANSFER_SIZE_MAX 255 /* Controller transfer limit */
#define CDNS_I2C_TRANSFER_SIZE (CDNS_I2C_TRANSFER_SIZE_MAX - 3)
@@ -135,6 +135,7 @@ struct i2c_cdns_bus {
int hold_flag;
u32 quirks;
+ u32 fifo_depth;
};
struct cdns_i2c_platform_data {
@@ -277,7 +278,7 @@ static int cdns_i2c_write_data(struct i2c_cdns_bus *i2c_bus, u32 addr, u8 *data,
writel(addr, ®s->address);
start = 0;
}
- if (len && readl(®s->transfer_size) == CDNS_I2C_FIFO_DEPTH) {
+ if (len && readl(®s->transfer_size) == i2c_bus->fifo_depth) {
ret = cdns_i2c_wait(regs, CDNS_I2C_INTERRUPT_COMP |
CDNS_I2C_INTERRUPT_ARBLOST);
if (ret & CDNS_I2C_INTERRUPT_ARBLOST)
@@ -310,9 +311,10 @@ static int cdns_i2c_write_data(struct i2c_cdns_bus *i2c_bus, u32 addr, u8 *data,
return 0;
}
-static inline bool cdns_is_hold_quirk(int hold_quirk, int curr_recv_count)
+static inline bool cdns_is_hold_quirk(struct i2c_cdns_bus *i2c_bus, int hold_quirk,
+ int curr_recv_count)
{
- return hold_quirk && (curr_recv_count == CDNS_I2C_FIFO_DEPTH + 1);
+ return hold_quirk && (curr_recv_count == i2c_bus->fifo_depth + 1);
}
static int cdns_i2c_read_data(struct i2c_cdns_bus *i2c_bus, u32 addr, u8 *data,
@@ -327,7 +329,7 @@ static int cdns_i2c_read_data(struct i2c_cdns_bus *i2c_bus, u32 addr, u8 *data,
curr_recv_count = recv_count;
/* Check for the message size against the FIFO depth */
- if (recv_count > CDNS_I2C_FIFO_DEPTH)
+ if (recv_count > i2c_bus->fifo_depth)
setbits_le32(®s->control, CDNS_I2C_CONTROL_HOLD);
setbits_le32(®s->control, CDNS_I2C_CONTROL_CLR_FIFO |
@@ -349,7 +351,7 @@ static int cdns_i2c_read_data(struct i2c_cdns_bus *i2c_bus, u32 addr, u8 *data,
while (recv_count && !is_arbitration_lost(regs)) {
while (readl(®s->status) & CDNS_I2C_STATUS_RXDV) {
- if (recv_count < CDNS_I2C_FIFO_DEPTH &&
+ if (recv_count < i2c_bus->fifo_depth &&
!i2c_bus->hold_flag) {
clrbits_le32(®s->control,
CDNS_I2C_CONTROL_HOLD);
@@ -365,20 +367,20 @@ static int cdns_i2c_read_data(struct i2c_cdns_bus *i2c_bus, u32 addr, u8 *data,
if (cdns_is_hold_quirk(hold_quirk, curr_recv_count)) {
/* wait while fifo is full */
while (readl(®s->transfer_size) !=
- (curr_recv_count - CDNS_I2C_FIFO_DEPTH))
+ (curr_recv_count - i2c_bus->fifo_depth))
;
/*
* Check number of bytes to be received against maximum
* transfer size and update register accordingly.
*/
- if ((recv_count - CDNS_I2C_FIFO_DEPTH) >
+ if ((recv_count - i2c_bus->fifo_depth) >
CDNS_I2C_TRANSFER_SIZE) {
writel(CDNS_I2C_TRANSFER_SIZE,
®s->transfer_size);
curr_recv_count = CDNS_I2C_TRANSFER_SIZE +
- CDNS_I2C_FIFO_DEPTH;
+ i2c_bus->fifo_depth;
} else {
- writel(recv_count - CDNS_I2C_FIFO_DEPTH,
+ writel(recv_count - i2c_bus->fifo_depth,
®s->transfer_size);
curr_recv_count = recv_count;
}
@@ -496,6 +498,10 @@ static int cdns_i2c_of_to_plat(struct udevice *dev)
return ret;
}
+ /* Update FIFO depth based on device tree entry */
+ i2c_bus->fifo_depth = dev_read_u32_default(dev, "fifo-depth",
+ CDNS_I2C_FIFO_DEPTH_DEFAULT);
+
return 0;
}
--
2.25.1
next prev parent reply other threads:[~2023-01-04 13:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 7:20 [PATCH 0/2] i2c: i2c-cdns.c: Update driver to read fifo-depth from device tree Pei Yue Ho
2023-01-04 7:20 ` [PATCH 1/2] dt-bindings: i2c: i2c-cdns.txt: Add description for an optional parameter, fifo-depth Pei Yue Ho
2023-02-13 5:43 ` Heiko Schocher
2023-02-13 7:57 ` PeiYue Ho
2023-02-13 14:49 ` Heiko Schocher
2023-01-04 7:20 ` Pei Yue Ho [this message]
2023-02-13 5:47 ` [PATCH 2/2] i2c: i2c-cdns.c: Update driver to read fifo-depth from device tree Heiko Schocher
2023-02-13 6:38 ` Heiko Schocher
2023-02-13 14:49 ` Heiko Schocher
2023-02-02 5:59 ` [PATCH 0/2] " WeiLiang Lim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230104072005.7812-3-peiyue.ho@starfivetech.com \
--to=peiyue.ho@starfivetech.com \
--cc=englee.teh@starfivetech.com \
--cc=u-boot@lists.denx.de \
--cc=weiliang.lim@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox