From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 142B1C53210 for ; Sun, 8 Jan 2023 14:58:44 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 26BFF855F9; Sun, 8 Jan 2023 15:58:42 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="f5DToG2Z"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 494B7855FA; Sun, 8 Jan 2023 15:58:40 +0100 (CET) Received: from mail-qv1-xf2c.google.com (mail-qv1-xf2c.google.com [IPv6:2607:f8b0:4864:20::f2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2C08485548 for ; Sun, 8 Jan 2023 15:58:37 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2c.google.com with SMTP id q10so4489041qvt.10 for ; Sun, 08 Jan 2023 06:58:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=98GqjksXXnYnDX5ZIcMblk52Vh9sycm8cN2gOndr9FA=; b=f5DToG2Zvzqe70nXt+WwSxm6drTdLIl7lPEdKWeGbJ04m7rCbYJHnf6d61BCrDauSG AOxRY/lXv0vPRg91fkFayWYoMkm9QhNp3GFexQAoRTJy1qhzlqp70SL+LFkntrrUwxqZ neW5e6XUZKLrJjsqC5j5YDSZw5PKce0DJyDhQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=98GqjksXXnYnDX5ZIcMblk52Vh9sycm8cN2gOndr9FA=; b=X5l70pUCx0bXFHe0wgjqgiyUxdCdqcXGoM+G65cpuQ0wLHNke7Q/6n04tyPCZDd62U aMXo7kZ8LrCozwx9JLctorasF/qOS/2es8yYyOIYo6LU/kGnUVmQcDz/ScPIMf/Oy0Ep rOF15QZAE++SmBbGiJXmsPG6YtsWMUGJ15s2j4m3Wy/wyAFfCxg1UhdH7kxkU6RKKoB0 Nz/JxxaQLkhwO9Ue+uQ7n4kyZyoY9hrp5UurbJsW3DDmSOkQQ9cmwqVVFIGgjsikbE0s cYyIeoUIfnT1f+OG6XzBy7FeoyHIUtB3nR2KUMJa1zYKhAHqtimXRqYLpzYfUn16YLz2 59hw== X-Gm-Message-State: AFqh2koc9yN0Z3HiuSRS8RxKyS7PAhKbSV11JusU7eAWmm+T7n6iooEC 9zFdguQ/lhwFAxhxdLzaCmQnEQ== X-Google-Smtp-Source: AMrXdXvrWPoUG87AUjt47+31hZJFm4jEnRU0lv02aK29Iw9VnG/fwP4q5XezmVs1ER56f0RW00WX6w== X-Received: by 2002:a05:6214:c6c:b0:50e:48cc:a95a with SMTP id t12-20020a0562140c6c00b0050e48cca95amr115276184qvj.43.1673189915929; Sun, 08 Jan 2023 06:58:35 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-a51c-8a60-c39b-2d7f.res6.spectrum.com. [2603:6081:7b00:6400:a51c:8a60:c39b:2d7f]) by smtp.gmail.com with ESMTPSA id j9-20020a05620a288900b006f9f714cb6asm3740721qkp.50.2023.01.08.06.58.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Jan 2023 06:58:35 -0800 (PST) Date: Sun, 8 Jan 2023 09:58:33 -0500 From: Tom Rini To: Fabio Estevam Cc: sbabic@denx.de, u-boot@lists.denx.de, marcel.ziswiler@toradex.com, Fabio Estevam Subject: Re: [PATCH v2 1/2] wandboard: Pass mmc aliases Message-ID: <20230108145833.GA3787616@bill-the-cat> References: <20221104111255.661416-1-festevam@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6y75z63WbEqv0zS+" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --6y75z63WbEqv0zS+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 08, 2023 at 08:36:21AM -0300, Fabio Estevam wrote: > Hi Tom, >=20 > On Tue, Jan 3, 2023 at 8:00 AM Fabio Estevam wrote: > > > > Hi Tom and Stefano, > > > > On Fri, Nov 4, 2022 at 8:13 AM Fabio Estevam wrote: > > > > > > From: Fabio Estevam > > > > > > Originally, the mmc aliases node was present in imx6qdl-wandboard.dts= i. > > > > > > After the sync with Linux in commit d0399a46e7cd ("imx6dl/imx6qdl: > > > synchronise device trees with linux"), the aliases node is gone as > > > the upstream version does not have it. > > > > > > This causes a regression in which the SD card cannot be found anymore: > > > > > > Since commit the aliases node has been removed > > > U-Boot 2022.10-00999-gcca41ed3d63f-dirty (Nov 03 2022 - 22:07:38 -030= 0) > > > > > > CPU: Freescale i.MX6QP rev1.0 at 792 MHz > > > Reset cause: POR > > > DRAM: 2 GiB > > > Core: 62 devices, 17 uclasses, devicetree: separate > > > PMIC: PFUZE100 ID=3D0x10 > > > MMC: FSL_SDHC: 0, FSL_SDHC: 1, FSL_SDHC: 2 > > > Loading Environment from MMC... MMC: no card present > > > *** Warning - No block device, using default environment > > > > > > Fix it by passing the alias node in the u-boot.dtsi file to > > > restore the original behaviour where the SD card (esdhc3) was > > > mapped to mmc0. > > > > > > Fixes: d0399a46e7cd ("imx6dl/imx6qdl: synchronise device trees with l= inux") > > > Signed-off-by: Fabio Estevam > > > --- > > > Changes since v1: > > > - Add patch numbering. > > > > Please consider applying this one to 2023.01 to fix the boot regression. >=20 > Could you please apply this one directly to 2023.01 to fix the boot regre= ssion? It's already been merged: commit f827f84d3f5607d0b33e927f6127a888e7bd664f Author: Fabio Estevam AuthorDate: Fri Nov 4 08:12:54 2022 -0300 Commit: Stefano Babic CommitDate: Wed Nov 9 17:12:31 2022 +0100 wandboard: Pass mmc aliases =20 Originally, the mmc aliases node was present in imx6qdl-wandboard.dtsi. =20 After the sync with Linux in commit d0399a46e7cd ("imx6dl/imx6qdl: synchronise device trees with linux"), the aliases node is gone as the upstream version does not have it. =20 This causes a regression in which the SD card cannot be found anymore: =20 Since commit the aliases node has been removed U-Boot 2022.10-00999-gcca41ed3d63f-dirty (Nov 03 2022 - 22:07:38 -0300) =20 CPU: Freescale i.MX6QP rev1.0 at 792 MHz Reset cause: POR DRAM: 2 GiB Core: 62 devices, 17 uclasses, devicetree: separate PMIC: PFUZE100 ID=3D0x10 MMC: FSL_SDHC: 0, FSL_SDHC: 1, FSL_SDHC: 2 Loading Environment from MMC... MMC: no card present *** Warning - No block device, using default environment =20 Fix it by passing the alias node in the u-boot.dtsi file to restore the original behaviour where the SD card (esdhc3) was mapped to mmc0. =20 Fixes: d0399a46e7cd ("imx6dl/imx6qdl: synchronise device trees with lin= ux") Signed-off-by: Fabio Estevam --=20 Tom --6y75z63WbEqv0zS+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmO62hEACgkQFHw5/5Y0 tyylzgwAuPCO64G9x1tbLGyoVUasNyzp8ujy+HS4O+oH/EEAAAMCjOj0ivVgd78y zF3zOpBh8PMIuwYkA3y36bW0Ead+AMi75zGf3DkzoQhIVF2BTlF6zXLsgr2vnihv rWFpaj0NfqQORhI1NESBY9aerDMRVloqMib1rKnJdC9E4I+Eht9ahoQpK2fusHxk iR5z5t5J/5TwNtEYnYMnTl696VZc3hl5bsPmR4Caxee0CBDyBEce++pgXqKjeh9X nrJLyLFY+C6nvd0vf/fjXnFka3z4h3yOtACRRvfoOAwyF+P0S4F4E7YfVXue7FIr 0HKxmcUm/enJXON+9JQuj65a3/dBDSa1ErLRjX04t8PY04klrAMhEhg003dA2jdq Zb45UTifYANnVkTjN6tBINv64VAXlAyEU+JI/+jHSRjHNN0YnyKpwP2InA2aEGSH 6nYI48aOwMBMgWRjq9rByzp/FRREP4zUHCWW4x5vkxGi6Qfl3k6uWpzW/4WInlDv ylxf8JWM =D5qc -----END PGP SIGNATURE----- --6y75z63WbEqv0zS+--