From: Tom Rini <trini@konsulko.com>
To: "Pali Rohár" <pali@kernel.org>
Cc: Marek Vasut <marex@denx.de>,
Patrick Delaunay <patrick.delaunay@foss.st.com>,
u-boot@lists.denx.de
Subject: Re: [PATCH] common/memsize.c: Check for overflow in get_effective_memsize() only for mpc85xx
Date: Sun, 8 Jan 2023 11:53:49 -0500 [thread overview]
Message-ID: <20230108165349.GD3787616@bill-the-cat> (raw)
In-Reply-To: <20230107215526.15009-1-pali@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 801 bytes --]
On Sat, Jan 07, 2023 at 10:55:26PM +0100, Pali Rohár wrote:
> This reverts commit 777aaaa706bc ("common/memsize.c: Fix
> get_effective_memsize() to check for overflow") for non-mpc85xx platforms.
>
> The changes to this generic function, which is intended to help with
> 32bit platforms with large amounts of memory has unintended side effects
> (which in turn lead to boot failures) on other platforms which were
> previously functional.
>
> For now do overflow check only for powerpc mpc85xx platform. It is needed
> to prevent crashing of P1/P2 boards with 4GB DDR module in 32-bit mode.
>
> Fixes: 777aaaa706bc ("common/memsize.c: Fix get_effective_memsize() to check for overflow")
> Signed-off-by: Pali Rohár <pali@kernel.org>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2023-01-08 16:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-07 21:55 [PATCH] common/memsize.c: Check for overflow in get_effective_memsize() only for mpc85xx Pali Rohár
2023-01-08 16:53 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230108165349.GD3787616@bill-the-cat \
--to=trini@konsulko.com \
--cc=marex@denx.de \
--cc=pali@kernel.org \
--cc=patrick.delaunay@foss.st.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox