From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3CA0DC53210 for ; Sun, 8 Jan 2023 16:54:01 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7C50584F66; Sun, 8 Jan 2023 17:53:58 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="WIfnDAyO"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3318485548; Sun, 8 Jan 2023 17:53:56 +0100 (CET) Received: from mail-qv1-xf36.google.com (mail-qv1-xf36.google.com [IPv6:2607:f8b0:4864:20::f36]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B04C984F66 for ; Sun, 8 Jan 2023 17:53:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf36.google.com with SMTP id y8so4624207qvn.11 for ; Sun, 08 Jan 2023 08:53:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=uBe4Rv6I0bHtqxiXU8rFuDux7XbUZnMjMmB/7iGQsfA=; b=WIfnDAyOXmvF0/q7VbZFor3HM7FqL32ekeOz/SXlAXk1eZ8iJ30CAZZt3uxmcybJ2S YXkBbFkfET3ldkEj9OgR4PhDv5vPp/v8mhWpIMM4BAf8K6E4lxC5ASGk+Vrqu51OWBXM XDE5FxafiYk6Ihfmw2YeUB8R4Y/xRjdNCKY04= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uBe4Rv6I0bHtqxiXU8rFuDux7XbUZnMjMmB/7iGQsfA=; b=GWvyal8uHoipzAUr0EwOkxkZS5aNofEePHRD6aYsGGh3IB+jeyTaTJs2wpEECaXBNa EmJbv2Ug7qbY3+f5Ms3m59abqZmj2xjsc4uaqDOSw+X/jTnnPss1U+8+ne9lDrXUTIud KSBqVVMToomTL480GfPCIc8IOy1WvPHFYQf6RR8GNaEl7jdEv4mKzcrPEOJKYt0HVTRA BG0V0D9LhgQaOGJs/k5Tmii+vKNMLzvBY6HL1wm5O8KRHAm3rzIWtPICDOrbo9WqlrWo na+gt2JyBPRJ/8sWL4cJcuDcqJLMhs/7mUSGuRo+pN5uDmHcNeUqYCRJzUN83S3J4kPe epUQ== X-Gm-Message-State: AFqh2kqdYWaqdb2yhYPXZ0AlQiassSKPgbOfbb/M7DbDyF2cbfCxk9Xc RF7I/xVo/xHdFXRFXkRkpBsOtQ== X-Google-Smtp-Source: AMrXdXtiy/DgCtaE/r7sGoVV55HNy/J0t5VUWpCd3qj5A7OeJK7EjPsHMoKveYJeO2Q2de967R3SSQ== X-Received: by 2002:a05:6214:1c5:b0:531:9a05:415 with SMTP id c5-20020a05621401c500b005319a050415mr50306243qvt.6.1673196832435; Sun, 08 Jan 2023 08:53:52 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-a51c-8a60-c39b-2d7f.res6.spectrum.com. [2603:6081:7b00:6400:a51c:8a60:c39b:2d7f]) by smtp.gmail.com with ESMTPSA id r18-20020a05620a299200b006cebda00630sm3965782qkp.60.2023.01.08.08.53.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Jan 2023 08:53:51 -0800 (PST) Date: Sun, 8 Jan 2023 11:53:49 -0500 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Marek Vasut , Patrick Delaunay , u-boot@lists.denx.de Subject: Re: [PATCH] common/memsize.c: Check for overflow in get_effective_memsize() only for mpc85xx Message-ID: <20230108165349.GD3787616@bill-the-cat> References: <20230107215526.15009-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Npz7DRZqFFtCo1tI" Content-Disposition: inline In-Reply-To: <20230107215526.15009-1-pali@kernel.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --Npz7DRZqFFtCo1tI Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jan 07, 2023 at 10:55:26PM +0100, Pali Roh=E1r wrote: > This reverts commit 777aaaa706bc ("common/memsize.c: Fix > get_effective_memsize() to check for overflow") for non-mpc85xx platforms. >=20 > The changes to this generic function, which is intended to help with > 32bit platforms with large amounts of memory has unintended side effects > (which in turn lead to boot failures) on other platforms which were > previously functional. >=20 > For now do overflow check only for powerpc mpc85xx platform. It is needed > to prevent crashing of P1/P2 boards with 4GB DDR module in 32-bit mode. >=20 > Fixes: 777aaaa706bc ("common/memsize.c: Fix get_effective_memsize() to ch= eck for overflow") > Signed-off-by: Pali Roh=E1r Applied to u-boot/master, thanks! --=20 Tom --Npz7DRZqFFtCo1tI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmO69RoACgkQFHw5/5Y0 tyxBiwwAsVzNX2kC16vBMGxoC/EFy37Adj35Bc6y/gEldVBxhyTJ57VbDIPmoMW2 wqN+RXhiSEQyJwwt4zk4zUvYsO45NmjV/9ZGSB+iJHl8tXInD+zSJ8rIQdDlTe04 cL41Mktp02zfxasLk0Z/0UDFUzsvZTK/4xeHw4KXUxKweFbp0T4NnpcXgQN62rIT bQ5+2Rks8iuUzuVIljW4JWEVxL1cDpYHNkON9FVMaHPUvpdpaJW8qIDCZZSShqHP os4xm9lIijx3Y8iPy90kyTGY9Hb/IIiacOb8dYA6XC7OkhLTM42ywwnlt7Rt13wm s7i3FFtrSKBga8zzMov5y0ZxWq44m8hfXNbFEvf4q5E4KF4+0FWOOwSz0qei/FVw u5443mQ902wniCHnasNocWQ89ShdEcwi+b9/ALwREc7AijdqlSORX87uDnnGuBON j7MgnQmljH8aWxOKMVsDXRd0eQwzqGFpRFTAcoqCjhDi71uorDaPSWTycSrGLefE AMZThUFD =/tym -----END PGP SIGNATURE----- --Npz7DRZqFFtCo1tI--