From: "Jorge Ramirez-Ortiz, Foundries" <jorge@foundries.io>
To: Andrew Davis <afd@ti.com>
Cc: Jorge Ramirez-Ortiz <jorge@foundries.io>,
vigneshr@ti.com, lokeshvutla@ti.com, trini@konsulko.com,
u-boot@lists.denx.de
Subject: Re: [PATCH] firmware: ti_sci: fix typo in boot authentication message name
Date: Tue, 10 Jan 2023 18:26:07 +0100 [thread overview]
Message-ID: <20230110172607.GA4005767@trex> (raw)
In-Reply-To: <03533436-c401-81ca-e281-31c69106b585@ti.com>
On 10/01/23, Andrew Davis wrote:
> On 1/10/23 6:30 AM, Jorge Ramirez-Ortiz wrote:
> > Fix AUTH_BOOT message identifier (s/IMIAGE/IMAGE)
> >
> > Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io>
> > ---
>
> Looks like this typo got copy/pasted over to ATF also[0]..
> I'll add your reported-by and go fix it over there
> (unless you are wanting to do that).
no no, please do. I was just reading code for secure boot and this typo was
annoying me for some reason (go figure..)
thanks!
>
> Acked-by: Andrew Davis <afd@ti.com>
>
> [0] https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/tree/plat/ti/k3/common/drivers/ti_sci/ti_sci_protocol.h#n50
>
> > drivers/firmware/ti_sci.c | 2 +-
> > drivers/firmware/ti_sci.h | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
> > index 727e090e8a..bd7379ae55 100644
> > --- a/drivers/firmware/ti_sci.c
> > +++ b/drivers/firmware/ti_sci.c
> > @@ -1935,7 +1935,7 @@ static int ti_sci_cmd_proc_auth_boot_image(const struct ti_sci_handle *handle,
> > info = handle_to_ti_sci_info(handle);
> > - xfer = ti_sci_setup_one_xfer(info, TISCI_MSG_PROC_AUTH_BOOT_IMIAGE,
> > + xfer = ti_sci_setup_one_xfer(info, TISCI_MSG_PROC_AUTH_BOOT_IMAGE,
> > TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
> > (u32 *)&req, sizeof(req), sizeof(*resp));
> > if (IS_ERR(xfer)) {
> > diff --git a/drivers/firmware/ti_sci.h b/drivers/firmware/ti_sci.h
> > index e4a087c2ba..101210eb21 100644
> > --- a/drivers/firmware/ti_sci.h
> > +++ b/drivers/firmware/ti_sci.h
> > @@ -49,7 +49,7 @@
> > #define TISCI_MSG_PROC_HANDOVER 0xc005
> > #define TISCI_MSG_SET_PROC_BOOT_CONFIG 0xc100
> > #define TISCI_MSG_SET_PROC_BOOT_CTRL 0xc101
> > -#define TISCI_MSG_PROC_AUTH_BOOT_IMIAGE 0xc120
> > +#define TISCI_MSG_PROC_AUTH_BOOT_IMAGE 0xc120
> > #define TISCI_MSG_GET_PROC_BOOT_STATUS 0xc400
> > #define TISCI_MSG_WAIT_PROC_BOOT_STATUS 0xc401
next prev parent reply other threads:[~2023-01-10 17:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 12:30 [PATCH] firmware: ti_sci: fix typo in boot authentication message name Jorge Ramirez-Ortiz
2023-01-10 13:35 ` Oleksandr Suvorov
2023-01-10 16:55 ` Andrew Davis
2023-01-10 17:26 ` Jorge Ramirez-Ortiz, Foundries [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-01-10 17:29 Jorge Ramirez-Ortiz
2023-01-19 14:45 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230110172607.GA4005767@trex \
--to=jorge@foundries.io \
--cc=afd@ti.com \
--cc=lokeshvutla@ti.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox