From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36385C54EBC for ; Tue, 10 Jan 2023 17:26:16 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 23C7385601; Tue, 10 Jan 2023 18:26:14 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=foundries.io Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=foundries.io header.i=@foundries.io header.b="a4SAy3gW"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5C60285602; Tue, 10 Jan 2023 18:26:12 +0100 (CET) Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 85411855A1 for ; Tue, 10 Jan 2023 18:26:09 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=foundries.io Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jorge@foundries.io Received: by mail-wr1-x436.google.com with SMTP id j7so7538600wrn.9 for ; Tue, 10 Jan 2023 09:26:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foundries.io; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=ynxX8JppYiyLktmcvp7FTBXptt+BGaqmAfHHs7MVpZw=; b=a4SAy3gWroRicI3bmblThki7CHybrHfkeqYsS3nYMsEfOP81n58KlmlV46jij4K5Cr wGAZd4Zl+Ht54TJ2pGJRZseDBoj/h2suihbwlsdFZ6jWF3LFY92Ga13NVakMz3VxA2Ju m+Ija6c83LSJW/mXoK+guUvO3Hg5q1eZzhRvynWMM9/tdD4TKfASTz7Rchdo62KxC+bJ D3ji72fqOMcwn50CIfTXKY3Go+lXQkJHSNHMoL3NWLo8Uqw657FqDhCSqJ9GnonllRKn cTcOQ8ZM+QdAZx5gVucfE+FmOi2lg49H9IGL3IoNkJOz9v2JHJh/rdCOmkRD8X5NA6vs OHnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ynxX8JppYiyLktmcvp7FTBXptt+BGaqmAfHHs7MVpZw=; b=INs6RBwICEe1MXgzaxxoJ3rktJ4wOMD13EjXACr0u2VDCLtuvVa0miAZEIhLGj5yZd AKLtoU0X78eUoA71e5H3GVWtXzfmWayTwQ/sWKqjFvqBe5wlmSBhO1/MXBa+WgRvDGvi j81dItEoAV7XbfjNIaQsApA7ifx9PgI63KzNQuKbiosvau80Up8bmOvkcLXiySYl2mSp uzeuzFXq/GTdkW84Ch0dpikTEpCssqtl89Z0WO6lTuosQzVWUa89MkqILn6hzUGH48Ji lSWS4ELSHtP3ry4Ja2XenUyKPvS/pVLmJ3j18seioY/vGmYp2wYX8NyyJ+y2sdBkoYTJ cF9w== X-Gm-Message-State: AFqh2ko7blYJTq1yNn9DdXaKfulCxMODSsdpqh2/eFKASXtjX57tKWIS dxGp1Uv9DkFtfMdonceH0bNN/sHknM542Q6o X-Google-Smtp-Source: AMrXdXvvD2AXCUg0YmlbfCRlEdAs9ICvPScKHPD2WwlAmVbBsgRHSPUz7U595NrBbwifbNgIjsz9Ew== X-Received: by 2002:a5d:4948:0:b0:2bc:858a:3def with SMTP id r8-20020a5d4948000000b002bc858a3defmr2580233wrs.5.1673371569065; Tue, 10 Jan 2023 09:26:09 -0800 (PST) Received: from trex (87.red-81-38-136.dynamicip.rima-tde.net. [81.38.136.87]) by smtp.gmail.com with ESMTPSA id l6-20020a5d6686000000b002bb3229a03csm10682508wru.34.2023.01.10.09.26.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 09:26:08 -0800 (PST) From: "Jorge Ramirez-Ortiz, Foundries" X-Google-Original-From: "Jorge Ramirez-Ortiz, Foundries" Date: Tue, 10 Jan 2023 18:26:07 +0100 To: Andrew Davis Cc: Jorge Ramirez-Ortiz , vigneshr@ti.com, lokeshvutla@ti.com, trini@konsulko.com, u-boot@lists.denx.de Subject: Re: [PATCH] firmware: ti_sci: fix typo in boot authentication message name Message-ID: <20230110172607.GA4005767@trex> References: <20230110123004.3765851-1-jorge@foundries.io> <03533436-c401-81ca-e281-31c69106b585@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <03533436-c401-81ca-e281-31c69106b585@ti.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 10/01/23, Andrew Davis wrote: > On 1/10/23 6:30 AM, Jorge Ramirez-Ortiz wrote: > > Fix AUTH_BOOT message identifier (s/IMIAGE/IMAGE) > > > > Signed-off-by: Jorge Ramirez-Ortiz > > --- > > Looks like this typo got copy/pasted over to ATF also[0].. > I'll add your reported-by and go fix it over there > (unless you are wanting to do that). no no, please do. I was just reading code for secure boot and this typo was annoying me for some reason (go figure..) thanks! > > Acked-by: Andrew Davis > > [0] https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/tree/plat/ti/k3/common/drivers/ti_sci/ti_sci_protocol.h#n50 > > > drivers/firmware/ti_sci.c | 2 +- > > drivers/firmware/ti_sci.h | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c > > index 727e090e8a..bd7379ae55 100644 > > --- a/drivers/firmware/ti_sci.c > > +++ b/drivers/firmware/ti_sci.c > > @@ -1935,7 +1935,7 @@ static int ti_sci_cmd_proc_auth_boot_image(const struct ti_sci_handle *handle, > > info = handle_to_ti_sci_info(handle); > > - xfer = ti_sci_setup_one_xfer(info, TISCI_MSG_PROC_AUTH_BOOT_IMIAGE, > > + xfer = ti_sci_setup_one_xfer(info, TISCI_MSG_PROC_AUTH_BOOT_IMAGE, > > TI_SCI_FLAG_REQ_ACK_ON_PROCESSED, > > (u32 *)&req, sizeof(req), sizeof(*resp)); > > if (IS_ERR(xfer)) { > > diff --git a/drivers/firmware/ti_sci.h b/drivers/firmware/ti_sci.h > > index e4a087c2ba..101210eb21 100644 > > --- a/drivers/firmware/ti_sci.h > > +++ b/drivers/firmware/ti_sci.h > > @@ -49,7 +49,7 @@ > > #define TISCI_MSG_PROC_HANDOVER 0xc005 > > #define TISCI_MSG_SET_PROC_BOOT_CONFIG 0xc100 > > #define TISCI_MSG_SET_PROC_BOOT_CTRL 0xc101 > > -#define TISCI_MSG_PROC_AUTH_BOOT_IMIAGE 0xc120 > > +#define TISCI_MSG_PROC_AUTH_BOOT_IMAGE 0xc120 > > #define TISCI_MSG_GET_PROC_BOOT_STATUS 0xc400 > > #define TISCI_MSG_WAIT_PROC_BOOT_STATUS 0xc401