* [PATCH] firmware: ti_sci: fix typo in boot authentication message name
@ 2023-01-10 12:30 Jorge Ramirez-Ortiz
2023-01-10 13:35 ` Oleksandr Suvorov
2023-01-10 16:55 ` Andrew Davis
0 siblings, 2 replies; 6+ messages in thread
From: Jorge Ramirez-Ortiz @ 2023-01-10 12:30 UTC (permalink / raw)
To: jorge, afd, vigneshr, lokeshvutla, trini; +Cc: u-boot
Fix AUTH_BOOT message identifier (s/IMIAGE/IMAGE)
Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io>
---
drivers/firmware/ti_sci.c | 2 +-
drivers/firmware/ti_sci.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
index 727e090e8a..bd7379ae55 100644
--- a/drivers/firmware/ti_sci.c
+++ b/drivers/firmware/ti_sci.c
@@ -1935,7 +1935,7 @@ static int ti_sci_cmd_proc_auth_boot_image(const struct ti_sci_handle *handle,
info = handle_to_ti_sci_info(handle);
- xfer = ti_sci_setup_one_xfer(info, TISCI_MSG_PROC_AUTH_BOOT_IMIAGE,
+ xfer = ti_sci_setup_one_xfer(info, TISCI_MSG_PROC_AUTH_BOOT_IMAGE,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
(u32 *)&req, sizeof(req), sizeof(*resp));
if (IS_ERR(xfer)) {
diff --git a/drivers/firmware/ti_sci.h b/drivers/firmware/ti_sci.h
index e4a087c2ba..101210eb21 100644
--- a/drivers/firmware/ti_sci.h
+++ b/drivers/firmware/ti_sci.h
@@ -49,7 +49,7 @@
#define TISCI_MSG_PROC_HANDOVER 0xc005
#define TISCI_MSG_SET_PROC_BOOT_CONFIG 0xc100
#define TISCI_MSG_SET_PROC_BOOT_CTRL 0xc101
-#define TISCI_MSG_PROC_AUTH_BOOT_IMIAGE 0xc120
+#define TISCI_MSG_PROC_AUTH_BOOT_IMAGE 0xc120
#define TISCI_MSG_GET_PROC_BOOT_STATUS 0xc400
#define TISCI_MSG_WAIT_PROC_BOOT_STATUS 0xc401
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] firmware: ti_sci: fix typo in boot authentication message name
2023-01-10 12:30 [PATCH] firmware: ti_sci: fix typo in boot authentication message name Jorge Ramirez-Ortiz
@ 2023-01-10 13:35 ` Oleksandr Suvorov
2023-01-10 16:55 ` Andrew Davis
1 sibling, 0 replies; 6+ messages in thread
From: Oleksandr Suvorov @ 2023-01-10 13:35 UTC (permalink / raw)
To: Jorge Ramirez-Ortiz; +Cc: afd, vigneshr, lokeshvutla, trini, u-boot
On Tue, Jan 10, 2023 at 2:30 PM Jorge Ramirez-Ortiz <jorge@foundries.io> wrote:
>
> Fix AUTH_BOOT message identifier (s/IMIAGE/IMAGE)
>
> Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io>
Reviewed-by: Oleksandr Suvorov <oleksandr.suvorov@foundries.io>
> ---
> drivers/firmware/ti_sci.c | 2 +-
> drivers/firmware/ti_sci.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
> index 727e090e8a..bd7379ae55 100644
> --- a/drivers/firmware/ti_sci.c
> +++ b/drivers/firmware/ti_sci.c
> @@ -1935,7 +1935,7 @@ static int ti_sci_cmd_proc_auth_boot_image(const struct ti_sci_handle *handle,
>
> info = handle_to_ti_sci_info(handle);
>
> - xfer = ti_sci_setup_one_xfer(info, TISCI_MSG_PROC_AUTH_BOOT_IMIAGE,
> + xfer = ti_sci_setup_one_xfer(info, TISCI_MSG_PROC_AUTH_BOOT_IMAGE,
> TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
> (u32 *)&req, sizeof(req), sizeof(*resp));
> if (IS_ERR(xfer)) {
> diff --git a/drivers/firmware/ti_sci.h b/drivers/firmware/ti_sci.h
> index e4a087c2ba..101210eb21 100644
> --- a/drivers/firmware/ti_sci.h
> +++ b/drivers/firmware/ti_sci.h
> @@ -49,7 +49,7 @@
> #define TISCI_MSG_PROC_HANDOVER 0xc005
> #define TISCI_MSG_SET_PROC_BOOT_CONFIG 0xc100
> #define TISCI_MSG_SET_PROC_BOOT_CTRL 0xc101
> -#define TISCI_MSG_PROC_AUTH_BOOT_IMIAGE 0xc120
> +#define TISCI_MSG_PROC_AUTH_BOOT_IMAGE 0xc120
> #define TISCI_MSG_GET_PROC_BOOT_STATUS 0xc400
> #define TISCI_MSG_WAIT_PROC_BOOT_STATUS 0xc401
>
> --
> 2.34.1
>
--
Best regards
Oleksandr
Oleksandr Suvorov
cryosay@gmail.com
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] firmware: ti_sci: fix typo in boot authentication message name
2023-01-10 12:30 [PATCH] firmware: ti_sci: fix typo in boot authentication message name Jorge Ramirez-Ortiz
2023-01-10 13:35 ` Oleksandr Suvorov
@ 2023-01-10 16:55 ` Andrew Davis
2023-01-10 17:26 ` Jorge Ramirez-Ortiz, Foundries
1 sibling, 1 reply; 6+ messages in thread
From: Andrew Davis @ 2023-01-10 16:55 UTC (permalink / raw)
To: Jorge Ramirez-Ortiz, vigneshr, lokeshvutla, trini; +Cc: u-boot
On 1/10/23 6:30 AM, Jorge Ramirez-Ortiz wrote:
> Fix AUTH_BOOT message identifier (s/IMIAGE/IMAGE)
>
> Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io>
> ---
Looks like this typo got copy/pasted over to ATF also[0]..
I'll add your reported-by and go fix it over there
(unless you are wanting to do that).
Acked-by: Andrew Davis <afd@ti.com>
[0] https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/tree/plat/ti/k3/common/drivers/ti_sci/ti_sci_protocol.h#n50
> drivers/firmware/ti_sci.c | 2 +-
> drivers/firmware/ti_sci.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
> index 727e090e8a..bd7379ae55 100644
> --- a/drivers/firmware/ti_sci.c
> +++ b/drivers/firmware/ti_sci.c
> @@ -1935,7 +1935,7 @@ static int ti_sci_cmd_proc_auth_boot_image(const struct ti_sci_handle *handle,
>
> info = handle_to_ti_sci_info(handle);
>
> - xfer = ti_sci_setup_one_xfer(info, TISCI_MSG_PROC_AUTH_BOOT_IMIAGE,
> + xfer = ti_sci_setup_one_xfer(info, TISCI_MSG_PROC_AUTH_BOOT_IMAGE,
> TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
> (u32 *)&req, sizeof(req), sizeof(*resp));
> if (IS_ERR(xfer)) {
> diff --git a/drivers/firmware/ti_sci.h b/drivers/firmware/ti_sci.h
> index e4a087c2ba..101210eb21 100644
> --- a/drivers/firmware/ti_sci.h
> +++ b/drivers/firmware/ti_sci.h
> @@ -49,7 +49,7 @@
> #define TISCI_MSG_PROC_HANDOVER 0xc005
> #define TISCI_MSG_SET_PROC_BOOT_CONFIG 0xc100
> #define TISCI_MSG_SET_PROC_BOOT_CTRL 0xc101
> -#define TISCI_MSG_PROC_AUTH_BOOT_IMIAGE 0xc120
> +#define TISCI_MSG_PROC_AUTH_BOOT_IMAGE 0xc120
> #define TISCI_MSG_GET_PROC_BOOT_STATUS 0xc400
> #define TISCI_MSG_WAIT_PROC_BOOT_STATUS 0xc401
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] firmware: ti_sci: fix typo in boot authentication message name
2023-01-10 16:55 ` Andrew Davis
@ 2023-01-10 17:26 ` Jorge Ramirez-Ortiz, Foundries
0 siblings, 0 replies; 6+ messages in thread
From: Jorge Ramirez-Ortiz, Foundries @ 2023-01-10 17:26 UTC (permalink / raw)
To: Andrew Davis; +Cc: Jorge Ramirez-Ortiz, vigneshr, lokeshvutla, trini, u-boot
On 10/01/23, Andrew Davis wrote:
> On 1/10/23 6:30 AM, Jorge Ramirez-Ortiz wrote:
> > Fix AUTH_BOOT message identifier (s/IMIAGE/IMAGE)
> >
> > Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io>
> > ---
>
> Looks like this typo got copy/pasted over to ATF also[0]..
> I'll add your reported-by and go fix it over there
> (unless you are wanting to do that).
no no, please do. I was just reading code for secure boot and this typo was
annoying me for some reason (go figure..)
thanks!
>
> Acked-by: Andrew Davis <afd@ti.com>
>
> [0] https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/tree/plat/ti/k3/common/drivers/ti_sci/ti_sci_protocol.h#n50
>
> > drivers/firmware/ti_sci.c | 2 +-
> > drivers/firmware/ti_sci.h | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
> > index 727e090e8a..bd7379ae55 100644
> > --- a/drivers/firmware/ti_sci.c
> > +++ b/drivers/firmware/ti_sci.c
> > @@ -1935,7 +1935,7 @@ static int ti_sci_cmd_proc_auth_boot_image(const struct ti_sci_handle *handle,
> > info = handle_to_ti_sci_info(handle);
> > - xfer = ti_sci_setup_one_xfer(info, TISCI_MSG_PROC_AUTH_BOOT_IMIAGE,
> > + xfer = ti_sci_setup_one_xfer(info, TISCI_MSG_PROC_AUTH_BOOT_IMAGE,
> > TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
> > (u32 *)&req, sizeof(req), sizeof(*resp));
> > if (IS_ERR(xfer)) {
> > diff --git a/drivers/firmware/ti_sci.h b/drivers/firmware/ti_sci.h
> > index e4a087c2ba..101210eb21 100644
> > --- a/drivers/firmware/ti_sci.h
> > +++ b/drivers/firmware/ti_sci.h
> > @@ -49,7 +49,7 @@
> > #define TISCI_MSG_PROC_HANDOVER 0xc005
> > #define TISCI_MSG_SET_PROC_BOOT_CONFIG 0xc100
> > #define TISCI_MSG_SET_PROC_BOOT_CTRL 0xc101
> > -#define TISCI_MSG_PROC_AUTH_BOOT_IMIAGE 0xc120
> > +#define TISCI_MSG_PROC_AUTH_BOOT_IMAGE 0xc120
> > #define TISCI_MSG_GET_PROC_BOOT_STATUS 0xc400
> > #define TISCI_MSG_WAIT_PROC_BOOT_STATUS 0xc401
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] firmware: ti_sci: fix typo in boot authentication message name
@ 2023-01-10 17:29 Jorge Ramirez-Ortiz
2023-01-19 14:45 ` Tom Rini
0 siblings, 1 reply; 6+ messages in thread
From: Jorge Ramirez-Ortiz @ 2023-01-10 17:29 UTC (permalink / raw)
To: jorge, afd, trini; +Cc: u-boot
Fix AUTH_BOOT message identifier (s/IMIAGE/IMAGE)
Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io>
Reviewed-by: Oleksandr Suvorov <oleksandr.suvorov@foundries.io>
Acked-by: Andrew Davis <afd@ti.com>
---
drivers/firmware/ti_sci.c | 2 +-
drivers/firmware/ti_sci.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
index 727e090e8a..bd7379ae55 100644
--- a/drivers/firmware/ti_sci.c
+++ b/drivers/firmware/ti_sci.c
@@ -1935,7 +1935,7 @@ static int ti_sci_cmd_proc_auth_boot_image(const struct ti_sci_handle *handle,
info = handle_to_ti_sci_info(handle);
- xfer = ti_sci_setup_one_xfer(info, TISCI_MSG_PROC_AUTH_BOOT_IMIAGE,
+ xfer = ti_sci_setup_one_xfer(info, TISCI_MSG_PROC_AUTH_BOOT_IMAGE,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
(u32 *)&req, sizeof(req), sizeof(*resp));
if (IS_ERR(xfer)) {
diff --git a/drivers/firmware/ti_sci.h b/drivers/firmware/ti_sci.h
index e4a087c2ba..101210eb21 100644
--- a/drivers/firmware/ti_sci.h
+++ b/drivers/firmware/ti_sci.h
@@ -49,7 +49,7 @@
#define TISCI_MSG_PROC_HANDOVER 0xc005
#define TISCI_MSG_SET_PROC_BOOT_CONFIG 0xc100
#define TISCI_MSG_SET_PROC_BOOT_CTRL 0xc101
-#define TISCI_MSG_PROC_AUTH_BOOT_IMIAGE 0xc120
+#define TISCI_MSG_PROC_AUTH_BOOT_IMAGE 0xc120
#define TISCI_MSG_GET_PROC_BOOT_STATUS 0xc400
#define TISCI_MSG_WAIT_PROC_BOOT_STATUS 0xc401
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-01-19 14:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-10 12:30 [PATCH] firmware: ti_sci: fix typo in boot authentication message name Jorge Ramirez-Ortiz
2023-01-10 13:35 ` Oleksandr Suvorov
2023-01-10 16:55 ` Andrew Davis
2023-01-10 17:26 ` Jorge Ramirez-Ortiz, Foundries
-- strict thread matches above, loose matches on Subject: below --
2023-01-10 17:29 Jorge Ramirez-Ortiz
2023-01-19 14:45 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox