From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9D70C46467 for ; Wed, 11 Jan 2023 00:12:21 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4EE3485595; Wed, 11 Jan 2023 01:12:20 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="WmXBHIHp"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 53800843E4; Wed, 11 Jan 2023 01:12:19 +0100 (CET) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3CEE5855E5 for ; Wed, 11 Jan 2023 01:12:17 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D4C6EB80AE6; Wed, 11 Jan 2023 00:12:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C978C433D2; Wed, 11 Jan 2023 00:12:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673395935; bh=ze97JdBsMUyP/ygRL9xSSE5I/lUUAG+sI+TCLmMk2G8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WmXBHIHptxpTT/YoPf3veYqxZIio66HrD0EQbmhXtyFzRKU44A58sJmX9IrO9p9uJ ntqKlFEdvlZg0PBAxAc20FnZUhUCj/34Ueb+J6F2HyYosRadksfUIvT8nUqwf2QY1Y uaGr3H6fcAnXHFDA4NNTh9Vmdwb6O6GR2K49xIXL/V+Kzxx/rvXkQ+4TEd5c44/GhR qqtQTbTHKyDKywdbvDTKqtYacoy34Pk/iszaU6p0Vxq9tuFVJiGjc6H23ZetFmiHFU /JbJ4MVQGe/Iy2wvEGSVKU/exKOt0jabLNrWyiyshPqw/eGIb8e7xbPN1m9qjbWoiX hTfIIlwmtGemQ== Received: by pali.im (Postfix) id 8A6967C5; Wed, 11 Jan 2023 01:12:12 +0100 (CET) Date: Wed, 11 Jan 2023 01:12:12 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Simon Glass Cc: Tom Rini , Heiko Schocher , u-boot@lists.denx.de Subject: Re: [PATCH u-boot 2/2] Makefile: Build working u-boot-dtb.bin target also for mpc85xx Message-ID: <20230111001212.hel2amjcdjd5mdsz@pali> References: <20221230154437.a7nxjwn5tx3bvcfp@pali> <20221230160649.zzlq7k3tv7xq4s5l@pali> <20221230175504.hd6seyyy2xrjb6hr@pali> <20221230191238.6rcnia6rzoqcezx6@pali> <20230103170522.xngoc64fkyul5ojz@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Friday 06 January 2023 17:13:41 Simon Glass wrote: > Hi Pali, > > On Tue, 3 Jan 2023 at 10:05, Pali Rohár wrote: > > > > On Tuesday 03 January 2023 11:02:17 Simon Glass wrote: > > > > > > > 3. Add a common binman image for u-boot.bin (used by every board) > > > > > > > > > > > > It should be u-boot-dtb.bin (not u-boot.bin). At least this is the > > > > > > current file name. (See this my patch series again, which aligns this > > > > > > naming also for powerpc/mpc85xx). > > > > > > > > > > We changed this 6 years ago and I'm not keen on going back. > > > > > > > > > > ad1ecd2063d fdt: Build a U-Boot binary without device tree > > > > > > > > I just do not understand you because in that commit is exactly what I > > > > wrote. In file u-boot-dtb.bin is u-boot binary with DTB and in file > > > > u-boot-nodtb.bin is u-boot binary without DTB. > > > > > > > > So binman should take input files u-boot-nodtb.bin and DTB binary. And > > > > should produce output file u-boot-dtb.bin. Is there any issue with it? > > > > > > Actually u-boot-dtb.bin is a hangover from that commit, left in to > > > allow people to adjust. So I think we should remove creation of > > > u-boot-dtb.bin > > > > Ok, complete remove of u-boot-dtb.bin creation also works. > > OK good. > > > - Simon I would suggest to take patch 1/2 to have all mpc85xx boards standard output file u-boot.bin. And prevent to repeat issue that building of the final image with custom name was unintentionally turned off as a side effect of some change.